Re: [O] [PATCH] Fix `org-refresh-category-properties'

2015-04-28 Thread Samuel Loury
Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 Hello,

 Samuel Loury konubi...@gmail.com writes:

 Samuel Loury konubi...@gmail.com writes:

 Dear Nicolas,

 [...]

 --8---cut here---start-8---
 #+CATEGORY: c
 * foo
   :PROPERTIES:
   :CATEGORY: a
   :END:
 ** bar
:PROPERTIES:
:CATEGORY: b
:END:

 --8---cut here---end---8---

 `org-get-category' in the bar headline returns 'a', while I would expect
 it to return 'b'.

 [...]

 I don't understand why one would want to remove this behavior. Does it
 raise a technical issue?

 No, it's a bug.

 After a quick look at the code, I wonder if this new behavior is a
 technical choice or hopefully a simple mistake.

 The latter.

 Please find attached a patch that restores the behavior of taking into
 account the CATEGORY keyword in sub-trees also.
 

 Applied, with an additional test. Thank you.

Thank you for the fast answer.

-- 
Konubinix
GPG Key: 7439106A
Fingerprint: 5993 BE7A DA65 E2D9 06CE  5C36 75D2 3CED 7439 106A


signature.asc
Description: PGP signature


Re: [O] [PATCH] Fix `org-refresh-category-properties'

2015-04-28 Thread Nicolas Goaziou
Hello,

Samuel Loury konubi...@gmail.com writes:

 Samuel Loury konubi...@gmail.com writes:

 Dear Nicolas,

 [...]

 --8---cut here---start-8---
 #+CATEGORY: c
 * foo
   :PROPERTIES:
   :CATEGORY: a
   :END:
 ** bar
:PROPERTIES:
:CATEGORY: b
:END:

 --8---cut here---end---8---

 `org-get-category' in the bar headline returns 'a', while I would expect
 it to return 'b'.

 [...]

 I don't understand why one would want to remove this behavior. Does it
 raise a technical issue?

No, it's a bug.

 After a quick look at the code, I wonder if this new behavior is a
 technical choice or hopefully a simple mistake.

The latter.

 Please find attached a patch that restores the behavior of taking into
 account the CATEGORY keyword in sub-trees also.


Applied, with an additional test. Thank you.


Regards,

-- 
Nicolas Goaziou