Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-12-13 Thread Kaushal Modi
On Thu, Dec 13, 2018 at 11:25 AM Nicolas Goaziou wrote: > > > +(unless (org-capture-get :no-save) > > + ;; Save the target file. > > + (save-buffer)) > > The comment does not look terribly useful. I would put the whole > `unless' in a single line. > > Barring that nitpicking of

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-12-13 Thread Nicolas Goaziou
Hello, Kaushal Modi writes: > I have formatted 2 patches to address this (attached). If they look fine, I > can commit them to master. Thank you. > +(unless (org-capture-get :no-save) > + ;; Save the target file. > + (save-buffer)) The comment does not look terribly useful. I

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-12-13 Thread Kaushal Modi
On Thu, Dec 13, 2018 at 10:24 AM Kaushal Modi wrote: > > I have formatted 2 patches to address this (attached). If they look fine, > I can commit them to master. > I forgot to properly format the commit messages.. locally, I have fixed the commit message of 0002 patch to the below: = Add

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-12-13 Thread Kaushal Modi
On Thu, Dec 13, 2018 at 10:08 AM Kaushal Modi wrote: > Hello Nicolas, > > While we are planning to cut Org 9.2 release this week, this one > regression in the Org Capture and auto-saving behavior comes to my mind, > that I think should be fixed. > > Summary: > > In Org 9.1.x, org-capture target

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-12-13 Thread Kaushal Modi
Hello Nicolas, While we are planning to cut Org 9.2 release this week, this one regression in the Org Capture and auto-saving behavior comes to my mind, that I think should be fixed. Summary: In Org 9.1.x, org-capture target files got auto-saved after C-c C-c when ending the capture. In Org

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-29 Thread Van L
>> Then saving should be the default again, and not saving optional. > > I believe this would be the best option. Very, very strongly concur with this belief.

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-29 Thread Eric S Fraga
On Saturday, 29 Sep 2018 at 08:31, Nicolas Goaziou wrote: > Then saving should be the default again, and not saving optional. I believe this would be the best option. -- Eric S Fraga via Emacs 27.0.50, Org release_9.1.13-783-g97fac4

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-29 Thread Nicolas Goaziou
Kaushal Modi writes: > Sorry. Here's the original thread: > https://lists.gnu.org/r/emacs-orgmode/2018-04/msg00204.html Thank you. > My email client shows the whole thread from then to now, so I forgot > pasting that. Mine (Gnus) also used to, but, for some reason, it doesn't anymore. >

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-28 Thread Kaushal Modi
On Fri, Sep 28, 2018 at 4:50 PM Nicolas Goaziou wrote: > Hello, > > Kaushal Modi writes: > > > @Nicolas, tumashu: Would love to get your comments. > > I don't remember the initial report. > Sorry. Here's the original thread: https://lists.gnu.org/r/emacs-orgmode/2018-04/msg00204.html My email

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-28 Thread Nicolas Goaziou
Hello, Kaushal Modi writes: > @Nicolas, tumashu: Would love to get your comments. I don't remember the initial report. However, saving the capture buffer may be problematic if there was unsaved modifications before the capture process. Saving silently the file would also save unrelated

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-28 Thread Kaushal Modi
On Thu, Sep 27, 2018, 9:33 AM Kaushal Modi wrote: > > Summary: > > - Proposal to revert > https://code.orgmode.org/bzg/org-mode/commit/b4422add3745c26ec3b2e11b8da425844b2e9d3d > - Use the above advice if you don't want to save buffer during org-capture. > @Nicolas, tumashu: Would love to get

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-27 Thread Kaushal Modi
On Thu, Sep 27, 2018 at 1:47 AM Eric S Fraga wrote: > On Wednesday, 26 Sep 2018 at 13:11, Kaushal Modi wrote: > > I had been wondering for quite some time (about since 5 months :P) why > > my Org captures have stopped auto-saving. > > This has been really annoying me for some time. Thanks for

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-26 Thread Eric S Fraga
On Wednesday, 26 Sep 2018 at 13:11, Kaushal Modi wrote: > I had been wondering for quite some time (about since 5 months :P) why > my Org captures have stopped auto-saving. This has been really annoying me for some time. Thanks for the code you've posted which I will try out. I use at least 2

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-26 Thread Kaushal Modi
> Also that suggestion to use org-capture-after-finalize-hook does not > work.. I am investigating to find the right way. I got the captures to auto-save with the below work-around: (with-eval-after-load 'org-capture (defvar modi/org-capture-base-buffer nil) (defun

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-26 Thread Kaushal Modi
> On Sat, Apr 14, 2018 at 5:43 AM tumashu wrote: > > > > Agree this idea, If user want to save-buffer when capture finish, they can > > add save-buffer to org-capture-after-finalize-hook or just type C-x C-s Also that suggestion to use org-capture-after-finalize-hook does not work.. I am

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-09-26 Thread Kaushal Modi
On Sat, Apr 14, 2018 at 5:43 AM tumashu wrote: > > At 2018-04-14 15:44:00, "Nicolas Goaziou" wrote: > >Hello, > > > >tumashu writes: > > > >> I do not know why must save-buffer, may be for information safe :-) > > > >If there is no objection, I suggest to simply remove this call to >

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-26 Thread Bastien
Hi Tumashu, Nicolas Goaziou writes: > AFAIC, I'd rather deal with email than with a web interface. However, > Bastien accepted PR from code.orgmode.org in the past. PS: Just to be clear, we don't accept PR from code.orgmode.org, this was just a left-over from the

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-16 Thread Nicolas Goaziou
Hello, tumashu writes: > From: Feng Shu > Date: Mon, 16 Apr 2018 09:02:13 +0800 > Subject: [PATCH] org-capture: Do not save buffer when run > org-capture-finalize. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-15 Thread tumashu
At 2018-04-14 17:42:27, "tumashu" wrote: > > > > > > > > > > >At 2018-04-14 15:44:00, "Nicolas Goaziou" wrote: >>Hello, >> >>tumashu writes: >> >>> I do not know why must save-buffer, may be for information safe :-) >> >>If

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-14 Thread tumashu
At 2018-04-14 15:44:00, "Nicolas Goaziou" wrote: >Hello, > >tumashu writes: > >> I do not know why must save-buffer, may be for information safe :-) > >If there is no objection, I suggest to simply remove this call to >`save-buffer' instead of

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-14 Thread Nicolas Goaziou
Hello, tumashu writes: > I do not know why must save-buffer, may be for information safe :-) If there is no objection, I suggest to simply remove this call to `save-buffer' instead of introducing a new variable. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-12 Thread tumashu
At 2018-04-12 21:22:21, "Nicolas Goaziou" wrote: >Hello, > >tumashu writes: > >> I use org-capture to capture text to a file of my mobile phone >> with the help of tramp and termux's sshd, the save buffer is very >> slow, so I want to

Re: [O] [PATCH] org-capture: Add a custom to control save target file or not.

2018-04-12 Thread Nicolas Goaziou
Hello, tumashu writes: > I use org-capture to capture text to a file of my mobile phone > with the help of tramp and termux's sshd, the save buffer is very > slow, so I want to org-capture-finalize just update buffer, and > I save buffer manually when need. Thank you. Comments