Re: [O] [PATCH] org-mime supports emacs24

[Nicolas Goaziou]

Hello,

Kaushal Modi  writes:

> I noticed that org-mime was recently added to Melpa:
> https://melpa.org/#/org-mime

I guess we can remove "org-mime.el" from contrib/ then. Any objection?

Regards,

-- 
Nicolas Goaziou

Re: [O] [PATCH] org-mime supports emacs24

[Kaushal Modi]

I noticed that org-mime was recently added to Melpa:
https://melpa.org/#/org-mime

On Mon, Sep 12, 2016 at 7:32 PM chen bin  wrote:

> On Tue, Sep 6, 2016 at 1:57 AM, Nicolas Goaziou 
> wrote:
> > project, tho. It could be useful to add yours to any ELPA and have the
>
> Sure, I will contact marmelade and melpa maintainer asap, for now,
> There are also some pull request and bugs I need handle. So it could
> take a few days.
>
> --
> help me, help you.
>
> --

Kaushal Modi

Re: [O] [PATCH] org-mime supports emacs24

[chen bin]

On Tue, Sep 6, 2016 at 1:57 AM, Nicolas Goaziou  wrote:
> project, tho. It could be useful to add yours to any ELPA and have the

Sure, I will contact marmelade and melpa maintainer asap, for now,
There are also some pull request and bugs I need handle. So it could
take a few days.

-- 
help me, help you.

Re: [O] [PATCH] org-mime supports emacs24

[Nicolas Goaziou]

Hello,

chen bin  writes:

> I agree with you, maybe pointing to project is the better solution.

There is an "org-mime" on Marmelade already. It doesn't seem to be your
project, tho. It could be useful to add yours to any ELPA and have the
previous one removed so as to avoid confusion.

I'll remove org-mime.el from contrib as soon as yours is readily
available, if no one objects.

Regards,

-- 
Nicolas Goaziou

Re: [O] [PATCH] org-mime supports emacs24

[chen bin]

On Sat, Sep 3, 2016 at 6:41 PM, Nicolas Goaziou  wrote:
> maintainer anymore. If you want to get maintainership, we could as well
Yes, I'd like to maintain the org-mime.el in the future.

I agree with you, maybe pointing to project is the better solution.

I updated code at https://github.com/redguardtoo/org-mime according to
your review.

Regards,
Chen


-- 
help me, help you.

Re: [O] [PATCH] org-mime supports emacs24

[Nicolas Goaziou]

Hello,

Chen Bin  writes:

> I got one patch to make org-mime.el usable at Emacs24.

Thank you. Note that I don't think "org-mime.el" has an active
maintainer anymore. If you want to get maintainership, we could as well
remove "org-mime.el" from contrib/ directory and let your repository be
the official one.

> I also clean out the obsolete code to make it not dependent on ascii
> and org export backend any more.

Why is it an issue ?

> +(eval-when-compile
> +  (require 'cl))

I suggest to (require 'cl-lib) instead and use "cl-" prefix accordingly.

>  ('semi (concat

"'semi" is probably a typo, assuming it is a `case' branch. It should be
simply "semi".

>  "--" "<>-{\n"
>  "--" "[[text/plain]]\n" plain
> - (if (and images (> (length images) 0))
> - (concat "--" "<>-{\n"
> - "--" "[[text/html]]\n"  html
> - images
> - "--" "}-<>\n")
> -   (concat "--" "[[text/html]]\n"  html
> -   images))
> + (when images (concat "--" "<>-{\n"))
> +"--" "[[text/html]]\n"  html
> + images
> + (when images (concat "--" "}-<>\n"))
>  "--" "}-<>\n"))
>  ('vm "?")))

Ditto.


Regards,

-- 
Nicolas Goaziou