Re: [O] [PATCH 2/2] org-notify: Fix compatibility with latest org-element (uppercase properties)

2013-06-27 Thread Bastien
Hi Peter,

Peter Münster pmli...@free.fr writes:

 * contrib/lisp/org-notify.el (org-notify-make-todo): Properties from
 org-element are all uppercase now.

Mhh... not sure what it means -- do you have a pointer?

 -(let* ((list (nth 1 heading))  (notify (or (get :notify) default))
 +(let* ((list (nth 1 heading))  (notify (or (get :NOTIFY) default))

I feel dull: please let me know why this is needed.

Thanks!

-- 
 Bastien



Re: [O] [PATCH 2/2] org-notify: Fix compatibility with latest org-element (uppercase properties)

2013-06-27 Thread Peter Münster
On Thu, Jun 27 2013, Bastien wrote:

 * contrib/lisp/org-notify.el (org-notify-make-todo): Properties from
 org-element are all uppercase now.

 Mhh... not sure what it means -- do you have a pointer?

Yes, here: http://article.gmane.org/gmane.emacs.orgmode/73628

Citation:

  | (defun org-element-headline-parser (limit optional raw-secondary-p)
  |   Parse a headline.
  |
  | Return a list whose CAR is `headline' and CDR is a plist
  | containing `:raw-value', `:title', `:alt-title', `:begin',
  | `:end', `:pre-blank', `:hiddenp', `:contents-begin' and
  | `:contents-end', `:level', `:priority', `:tags',
  | `:todo-keyword',`:todo-type', `:scheduled', `:deadline',
  | `:closed', `:quotedp', `:archivedp', `:commentedp' and
  | `:footnote-section-p' keywords.
  |
  | The plist also contains any property set in the property drawer,
  | with its name in upper cases and colons added at the
  | beginning (i.e. `:CUSTOM_ID').
  |
[...]


 -(let* ((list (nth 1 heading))  (notify (or (get :notify) default))
 +(let* ((list (nth 1 heading))  (notify (or (get :NOTIFY) default))

 I feel dull: please let me know why this is needed.

No problem. Here another pointer:
http://article.gmane.org/gmane.emacs.orgmode/73637

-- 
   Peter