Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-14 Thread Bastien
Hi Florian,

Florian Beck f...@miszellen.de writes:

 On 13.03.2014 20:46, Bastien wrote:
 Ok, let me take some fresh air and come back to this later on.

 How about this:

 (while (re-search-forward \\(^\\).+ nil t)
   (replace-match indent nil nil nil 1)))

Works fine here, I pushed this solution.  Thanks!

-- 
 Bastien



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-14 Thread Arun Persaud
On 03/14/2014 02:00 AM, Bastien wrote:
 Hi Florian,
 
 Florian Beck f...@miszellen.de writes:
 
 On 13.03.2014 20:46, Bastien wrote:
 Ok, let me take some fresh air and come back to this later on.

 How about this:

 (while (re-search-forward \\(^\\).+ nil t)
   (replace-match indent nil nil nil 1)))
 
 Works fine here, I pushed this solution.  Thanks!

Thanks everyone for fixing this!

Arun



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Bastien
Hi Charles,

Charles Berry ccbe...@ucsd.edu writes:

 This seems to have broken org-edit-src-exit. :-(

 I cannot figure out what triggers it (hence no ECM), but I sometimes get an
 'End of buffer' error from inside the while loop.

I just pushed a fix.  Can you confirm you don't see the error anymore?

Thanks!

-- 
 Bastien



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Charles Berry
Bastien bzg at gnu.org writes:

 
 Hi Charles,
 
 Charles Berry ccberry at ucsd.edu writes:
 
  This seems to have broken org-edit-src-exit. 
 
  I cannot figure out what triggers it (hence no ECM), but I sometimes 
  get an
  'End of buffer' error from inside the while loop.
 
 I just pushed a fix.  Can you confirm you don't see the error anymore?
 


Time to failure seems longer. But now I get an infinite loop.

The error message is gone. C-g stops the loop, but attempting to exit via 
C-c ' re-indents the code and the loop starts again.

Chuck





Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Bastien
Charles Berry ccbe...@ucsd.edu writes:

 Time to failure seems longer. But now I get an infinite loop.

Er, sorry for the confusion; should be fixed again.

-- 
 Bastien



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Charles Berry
Bastien bzg at gnu.org writes:

 
 Charles Berry ccberry at ucsd.edu writes:
 
  Time to failure seems longer. But now I get an infinite loop.
 
 Er, sorry for the confusion; should be fixed again.
 

It is not. I am now back to getting the 'End of Buffer' msg

Chuck




Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Bastien
Charles Berry ccbe...@ucsd.edu writes:

 Bastien bzg at gnu.org writes:

 
 Charles Berry ccberry at ucsd.edu writes:
 
  Time to failure seems longer. But now I get an infinite loop.
 
 Er, sorry for the confusion; should be fixed again.

 It is not. I am now back to getting the 'End of Buffer' msg

Ok, let me take some fresh air and come back to this later on.

-- 
 Bastien



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Charles C. Berry

On Thu, 13 Mar 2014, Bastien wrote:


Charles Berry ccbe...@ucsd.edu writes:


Bastien bzg at gnu.org writes:



Charles Berry ccberry at ucsd.edu writes:


Time to failure seems longer. But now I get an infinite loop.


Er, sorry for the confusion; should be fixed again.


It is not. I am now back to getting the 'End of Buffer' msg


Ok, let me take some fresh air and come back to this later on.


Perhaps

- (forward-char 1
+ (forward-line 1

as the latter will not throw an error when (eobp) ?

Chuck




Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-13 Thread Florian Beck

On 13.03.2014 20:46, Bastien wrote:

Ok, let me take some fresh air and come back to this later on.



How about this:

(while (re-search-forward \\(^\\).+ nil t)
  (replace-match indent nil nil nil 1)))

--
Florian Beck



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-12 Thread Bastien
Hi Arun,

Arun Persaud apers...@lbl.gov writes:

 I tried to fix this in org. It seems to work over here, but my elisp as
 well as my understanding of org-mode is not perfect ;) Let me know if it
 needs more work.

Applied, thanks!

-- 
 Bastien



Re: [O] [Patch] don't add indent for empty line when exiting, a code edit

2014-03-12 Thread Charles Berry
Bastien bzg at gnu.org writes:

 
 Hi Arun,
 
 Arun Persaud apersaud at lbl.gov writes:
 
  I tried to fix this in org. It seems to work over here, but my elisp as
  well as my understanding of org-mode is not perfect ;) Let me know if it
  needs more work.
 
 Applied, thanks!
 


Bastien,

This seems to have broken org-edit-src-exit. :-(

I cannot figure out what triggers it (hence no ECM), but I sometimes get an
'End of buffer' error from inside the while loop.

I cannot exit the src edit buffer until I revert org-edit-src-exit to its
old version.

HTH,

Chuck