Re: [O] [patch] structure snippet completions

"Berry, Charles" writes: >> On Dec 8, 2017, at 1:20 PM, Rasmus wrote: >> > >>> >>> A minor gotcha: if you `(require 'org-tempo)' after an org buffer has >>> been created you will need to (org-mode-restart) the buffer to enable >>> completions. I got stuck

Re: [O] [patch] structure snippet completions

> On Dec 8, 2017, at 1:20 PM, Rasmus wrote: > >> >> A minor gotcha: if you `(require 'org-tempo)' after an org buffer has >> been created you will need to (org-mode-restart) the buffer to enable >> completions. I got stuck trying to add custom templates until I >> realized

Re: [O] [patch] structure snippet completions

"numbch...@gmail.com" writes: > error report when I `(require 'org-tempo)` Because your org-structure-template-alist is mal-formatted: ("Q" "#+BEGIN_SRC sql-mode ?\n\n#+END_SRC" "#+BEGIN_SRC sql-mode ?\n\n#+END_SRC") Rasmus -- The right to be left alone is a human right

Re: [O] [patch] structure snippet completions

error report when I `(require 'org-tempo)` Debugger entered--Lisp error: (error "Format specifier doesn’t match argument type") format("<%c" "Q") (closure (t) (pair) (format "<%c" (car pair)))(("Q" "#+BEGIN_SRC sql-mode ?\n\n#+END_SRC" "#+BEGIN_SRC sql-mode ?\n\n#+END_SRC")) mapcar((closure

Re: [O] [patch] structure snippet completions

"Berry, Charles" writes: >> On Dec 7, 2017, at 3:37 PM, Rasmus wrote: >> >> I have also pushed the code. "> enabled by requiring org-tempo. >> > > Thanks. I was in a deep funk without "

Re: [O] [patch] structure snippet completions

> On Dec 7, 2017, at 3:37 PM, Rasmus wrote: > > I have also pushed the code. " enabled by requiring org-tempo. > Thanks. I was in a deep funk without " Let me know about any issues. > Maybe make

Re: [O] [patch] structure snippet completions

Kaushal Modi writes: > On Thu, Dec 7, 2017 at 6:51 PM Rasmus wrote: > >> Rasmus writes: >> One possible "bug" that I discovered is illustrated by the following >> example. >> >> * foo >> suggested indention >> > >> When I tab

Re: [O] [patch] structure snippet completions

On Thu, Dec 7, 2017 at 6:51 PM Rasmus wrote: > Rasmus writes: > One possible "bug" that I discovered is illustrated by the following > example. > > * foo > suggested indention > > When I tab at point ("|") extra indention will be stripped. I don’t >

Re: [O] [patch] structure snippet completions

Rasmus writes: > Hi, > > Nicolas Goaziou writes: > >> It looks like a typo, but the two lines above are commented. > > Indeed. Thanks. > >> Also, would it make sense to add a few tests? > > I never feel very creative about tests but I have added some. > >

Re: [O] [patch] structure snippet completions

Hi, Nicolas Goaziou writes: > It looks like a typo, but the two lines above are commented. Indeed. Thanks. > Also, would it make sense to add a few tests? I never feel very creative about tests but I have added some. I have also pushed the code. "

Re: [O] [patch] structure snippet completions

Hello, Rasmus writes: > +@cindex Tempo > +@cindex Template expansion > +@cindex template insertion > +@cindex insertion, of templates > +@vindex org-tempo-keywords-alist > +@vindex org-structure-template-alist > +Org Tempo expands snippets to structures defined in > +@c

Re: [O] [patch] structure snippet completions

Rasmus writes: > Eric Abrahamsen writes: > >> Rasmus writes: >> >>> Hi, >>> >>> The attached patch adds expansions of ">> would like to include this in the next version of Org in anticipation of >>> the

Re: [O] [patch] structure snippet completions

Eric Abrahamsen writes: > Rasmus writes: > >> Hi, >> >> The attached patch adds expansions of "> would like to include this in the next version of Org in anticipation of >> the changes to the template system. > > Cool!

Re: [O] [patch] structure snippet completions

Hi, Thanks for the comments. I have attached a new version that addresses the issues you raised. I think Org Tempo should pretty much work as this point, but of course additional testing would be great. And more cool key expansions of course. >> +@vindex org-tempo > > Is it worth mentioning

Re: [O] [patch] structure snippet completions

Rasmus writes: > Hi, > > The attached patch adds expansions of " would like to include this in the next version of Org in anticipation of > the changes to the template system. Cool! We were talking about shifting the alist keys to strings, do we

Re: [O] [patch] structure snippet completions

Hello, Rasmus writes: > The attached patch adds expansions of " would like to include this in the next version of Org in anticipation of > the changes to the template system. Thank you. Some, mostly cosmetics, comments follow. > > In at least