Re: [O] Bug: Org Table Performance Issue/Regression
> On Sep 3, 2018, at 2:59 AM, Nicolas Goaziou wrote: > > I think master branch behaves better now. Could you confirm it? It behaves better and is usable again. It's still not quite as fast as version 8.2.10 that came with Emacs 25.3, but I think I’m using Org tables in an atypical way and have a workaround for my particular situation. Thanks for the work and fixes. Tim
Re: [O] Bug: Org Table Performance Issue/Regression
Hello, Tim Baumgard writes: >> On Jun 26, 2018, at 4:58 AM, Nicolas Goaziou wrote: >> >> Could you send the result of your profiling (using both Elp and >> profiler would be nice) on an uncompiled Org? > > I've attached ten profiler results: Two are from 25.3 with the garbage > collector > running normally, two are from 25.3 with the garbage collector "disabled" as > described in my previous email, two are from 26.1 with the garbage collector > running normally, two are from 26.1 with the garbage collector "disabled," and > two are the Elp profiles--I used elp-instrument-package--for both versions. > > In case it helps, my process to obtain these has been: > > 1. I use the test.org file from my previous email with the test row duplicated >so that it occurs 3500 times. I can't remember how many rows I used in my >previous tests. > 2. I invoke Emacs by calling "Emacs.app/Contents/MacOS/Emacs -Q" > 3. I use "M-x load-file" to load the test init.el file I included in my > previous >email, with the last two lines commented out or not depending on what I'm >testing. > 4. I then open the test.org file and go to column A in the last row. > 5. I then start one of the profilers, hit enter, hit shift+enter >(org-table-copy-down), and then get the report from the profiler. > > Let me know if I can provide anything else. I think master branch behaves better now. Could you confirm it? Regards, -- Nicolas Goaziou0x80A93738
Re: [O] Bug: Org Table Performance Issue/Regression
Hello, Tim Baumgard writes: > I recently updated Emacs from 25.3 (Org mode v. 8.2.10) to 26.1 (Org mode > v. 9.1.9) and noticed a performance issue/regression in one of my Org files > that > contains a table that currently has nine columns, around 1,200 rows, and uses > formulas. In 25.3, I could create a new row or use org-table-copy-down without > issues. In 26.1, there’s a multi-second delay each time I try to do either of > these things. As mentioned below, this issue also occurs in the latest commits > to both Emacs and Org mode. > > I did some profiling and found that garbage-collect was being called quite a > bit. I set gc-cons-threshold in both versions to a large value to effectively > disable garbage collection and noticed two things: 1) it largely fixed the > performance issues—though performance still wasn’t as good as it was in > 25.3—and > 2) Emacs/Org mode was using about four times as much memory as it did after > creating a new row and doing calling org-table-copy-down three > times. Specifically, Emacs 25.3 was using a little under 200 MB and Emacs 26.3 > was using a around 800 MB. Could you send the result of your profiling (using both Elp and profiler would be nice) on an uncompiled Org? Thank you. Regards, -- Nicolas Goaziou
