Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-27 Thread Rasmus
Ken Mankoff mank...@gmail.com writes:

 I'm still experiencing this bug, although with a slightly different error
 message. When C-c C-c on a headline, I see:

 org-set-tags: Wrong type argument: listp, org-tags-completion-function

Do you see this from emacs -q?  If not, how can I get to the state where
this happens from emacs -q?

Thanks,
Rasmus

-- 
Warning: Everything saved will be lost




Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-27 Thread Ken Mankoff
On 2015-04-27 at 04:26, Rasmus ras...@gmx.us wrote:
 Ken Mankoff mank...@gmail.com writes:

 I'm still experiencing this bug, although with a slightly different error
 message. When C-c C-c on a headline, I see:

 org-set-tags: Wrong type argument: listp, org-tags-completion-function

 Do you see this from emacs -q?  If not, how can I get to the state where
 this happens from emacs -q?

A make clean before make autoloads fixed it.

Sorry for the noise,

  -k.



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-26 Thread Ken Mankoff
Hi,

I'm still experiencing this bug, although with a slightly different error
message. When C-c C-c on a headline, I see:

org-set-tags: Wrong type argument: listp, org-tags-completion-function

Compared to the original report of:

apply: Wrong type argument: listp, org-tags-completion-function

I'm running latest git head:
Org-mode version 8.3beta (release_8.3beta-1078-gd13a2b @
/Users/mankoff/local/src/org-mode/lisp/)


  -k.



On Mon, Apr 20, 2015 at 4:02 PM, Marc Ihm m...@ihm.name wrote:

 Works for me too, and probably better than my suggestion :-)

 best regards
 Marc




Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-20 Thread Rasmus
Hi,

Rasmus ras...@gmx.us writes:

 I still don't know how to reproduce the error.  I have tried with Emacs
 24.4 and the git version.

Sorry for the noise.  This should be fixed now.

Thanks,
Rasmus

-- 
I feel emotional landscapes they puzzle me



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-20 Thread Rasmus
Hi,

Marc Ihm m...@ihm.name writes:

 Okay, this one only tries to fix, what seems broken ...
 Could someone please check ?

Please run pull the latest version and create your patch using git am.

I still don't know how to reproduce the error.  I have tried with Emacs
24.4 and the git version.

Combining your two diffs I get:

diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,11 +10512,11 @@ from.
  (listp (second args)))
 'org-iswitchb-completing-read)
(t (or (and (boundp 'completing-read-function)
-   completing-read-function)
-  'completing-read)))
+   completing-read-function))
+  'completing-read))
   (concat (car args))

which seems wrong (notice that the or becomes irrelevant).

What is completing-read-function?

Thanks,
Rasmus

-- 
You people at the NSA are becoming my new best friends!



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-20 Thread Marc Ihm
Works for me too, and probably better than my suggestion :-)

best regards
Marc



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-19 Thread Marc Ihm
Vicente Vera vicente...@gmail.com writes:

 Hi.
 Don't think there are more details to provide. The error message
 appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
 on a headline, doesn't matter which level.
 It happened in 3 different Org files, one of which was created for testing.
 Also tried with emacs -q but the error persisted.

 Strange message though, org-tags-completion-function is a function,
 not a variable, so why is Emacs complaining that it isn't a list?
 Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?

I see this error too; the patch below fixes it for me (and corrects the
nexting level of 'completing-read too ...)

best regards
Marc


diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,10 +10512,11 @@ from.
  (listp (second args)))
 'org-iswitchb-completing-read)
(t (or (and (boundp 'completing-read-function)
-   completing-read-function)
-  'completing-read)))
+   completing-read-function))
+  'completing-read))
   (concat (car args))
-  (if (consp (car (nth 1 args)))
+  (if (and (consp (nth 1 args))
+  (consp (car (nth 1 args
  (mapcar 'car (nth 1 args))
(nth 1 args))
   (cddr args)



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-19 Thread Vicente Vera
Worked for me.

2015-04-19 13:05 GMT-03:00 Marc Ihm m...@ihm.name:

 Okay, this one only tries to fix, what seems broken ...
 Could someone please check ?

 best regards
 Marc


 diff --git a/lisp/org.el b/lisp/org.el
 index 24b3a69..8a00847 100755
 --- a/lisp/org.el
 +++ b/lisp/org.el
 @@ -10515,8 +10515,7 @@ from.
 completing-read-function)
'completing-read)))
(concat (car args))
 -  (if (and (consp (nth 1 args))
 -  (consp (car (nth 1 args
 +  (if (consp (car (nth 1 args)))
   (mapcar 'car (nth 1 args))
 (nth 1 args))
(cddr args)



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-19 Thread Rasmus
Hi Marc (and Vincent),

Marc Ihm m...@ihm.name writes:

 Vicente Vera vicente...@gmail.com writes:

 Don't think there are more details to provide. The error message
 appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
 on a headline, doesn't matter which level.
 It happened in 3 different Org files, one of which was created for testing.
 Also tried with emacs -q but the error persisted.

Thanks for confirming.

 Strange message though, org-tags-completion-function is a function,
 not a variable, so why is Emacs complaining that it isn't a list?
 Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?

 I see this error too; the patch below fixes it for me (and corrects the
 nexting level of 'completing-read too ...)

Thanks for confirming.  Do you (also) see it when starting Emacs with
emacs -q, as Vincent?

Finally, can you repost post the patch via git am against master?

Thanks,
Rasmus

-- 
Summon the Mothership!




Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-19 Thread Vicente Vera
Hello Marc. Yes, upon further inspection it seems the problem is in
org-icompleting-read. This function is complaining that
org-tags-completion--function---one of its arguments---is not a list.

2015-04-19 11:36 GMT-03:00 Marc Ihm m...@ihm.name:
 Vicente Vera vicente...@gmail.com writes:

 Hi.
 Don't think there are more details to provide. The error message
 appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
 on a headline, doesn't matter which level.
 It happened in 3 different Org files, one of which was created for testing.
 Also tried with emacs -q but the error persisted.

 Strange message though, org-tags-completion-function is a function,
 not a variable, so why is Emacs complaining that it isn't a list?
 Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?

 I see this error too; the patch below fixes it for me (and corrects the
 nexting level of 'completing-read too ...)

 best regards
 Marc


 diff --git a/lisp/org.el b/lisp/org.el
 index 8a00847..f440382 100755
 --- a/lisp/org.el
 +++ b/lisp/org.el
 @@ -10512,10 +10512,11 @@ from.
   (listp (second args)))
  'org-iswitchb-completing-read)
 (t (or (and (boundp 'completing-read-function)
 -   completing-read-function)
 -  'completing-read)))
 +   completing-read-function))
 +  'completing-read))
(concat (car args))
 -  (if (consp (car (nth 1 args)))
 +  (if (and (consp (nth 1 args))
 +  (consp (car (nth 1 args
   (mapcar 'car (nth 1 args))
 (nth 1 args))
(cddr args)



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-19 Thread Marc Ihm

Okay, this one only tries to fix, what seems broken ...
Could someone please check ?

best regards
Marc


diff --git a/lisp/org.el b/lisp/org.el
index 24b3a69..8a00847 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10515,8 +10515,7 @@ from.
completing-read-function)
   'completing-read)))
   (concat (car args))
-  (if (and (consp (nth 1 args))
-  (consp (car (nth 1 args
+  (if (consp (car (nth 1 args)))
  (mapcar 'car (nth 1 args))
(nth 1 args))
   (cddr args)



Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-18 Thread Rasmus
Hi Vicenet,

Vicente Vera vicente...@gmail.com writes:

 Hello. This shows up when trying to add tags to a headline with
 org-ctrl-c-ctrl-c:

 apply: Wrong type argument: listp, org-tags-completion-function

I can't reproduce by clicking C-c C-c on a headline.  Can you be more
specific as to how you trigger the error?  Do you see it when you start
Emacs via emacs -q?

Thanks,
Rasmus

-- 
Need more coffee. . .




Re: [O] Error when using org-ctrl-c-ctrl-c to add tags

2015-04-18 Thread Vicente Vera
Hi.
Don't think there are more details to provide. The error message
appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
on a headline, doesn't matter which level.
It happened in 3 different Org files, one of which was created for testing.
Also tried with emacs -q but the error persisted.

Strange message though, org-tags-completion-function is a function,
not a variable, so why is Emacs complaining that it isn't a list?
Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?