Re: [O] M-S-RET doesn't work anymore?
Kaushal Modi writes: > On Wed, Jan 23, 2019 at 3:54 PM Marco Wahl wrote: > > As a workaround you can evaluate the lines (that were active before the > commit) > > (org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) > (org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) > (org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-heading) > > or put them into your init file AFAICS. > > Yep, that commit broke the - bindings for me too. I'll have to do the > same. > > Copying Kevin who originally requested the change of these bindings (this > switching of bindings between RET and feels like dejavu to me .. I > have seen this done before in Org repo). > > Is this a reliable fix to add these lines to the source code again? > To be honest I don't see clearly. > > May be those keys should be bound to both RET and variants? > > For Emacs GUI, I think that the variant is needed, RET does nothing. Gah! Apologies for the breakage. I assumed that in GUI frames, since is translated to RET when the former is not bound explicitly[1], *modifier*- would also be translated to *modifier*-RET, but that does not seem to be the case[2]. My previous experience with M-RET in markdown-mode[3] led me to assume I could suggest this change without breaking anything… Next time I'll know better and write those unit tests :) Thank you for catching this and again, sorry for the disruption. [1]: In fundamental-mode: C-h k ⇒ RET (translated from ) runs the command newline… [2]: In fundamental-mode: M-: (global-set-key (kbd "S-RET") (lambda () (interactive) (message "foo"))) C-h k S- ⇒ RET (translated from ) runs the command newline… M-: (global-set-key (kbd "M-S-RET") (lambda () (interactive) (message "bar"))) C-h M-S- ⇒ is undefined M-: (global-set-key (kbd "M-RET") (lambda () (interactive) (message "baz"))) C-h M- ⇒ M-RET (translated from ) runs the command (lambda…) [3]: https://github.com/jrblevin/markdown-mode/commit/c0fc52461e845baa3c55d9b6f9e67c451a9ffa8d
Re: [O] M-S-RET doesn't work anymore?
Nicolas Goaziou writes: >> May be those keys should be bound to both RET and variants? > > This is what I just did in master. Thank you. Thanks!! It works great again :) I really like the pairing of C-RET, C-S-RET which creates a TODO and M-RET and M-S-RET which creates a checkbox. Converting lists to headings with C-c * and back again with C-c - just feels natural when the key bindings work this way. Having to use C-M-S-m just felt awkward and wrong to me :) Thanks for all your excellent work on Org! Regards, Bernt
Re: [O] M-S-RET doesn't work anymore?
Helo, Kaushal Modi writes: > May be those keys should be bound to both RET and variants? This is what I just did in master. Thank you. Regards, -- Nicolas Goaziou
Re: [O] M-S-RET doesn't work anymore?
On Wed, Jan 23, 2019, 7:45 PM Amin Bandali > Also notice the left over greater sign ‘>’ on the fourth line. > Yeah, that was fixed in a later commit. I was surprised to see that too, but confirmed that the latest master doesn't have that. >
Re: [O] M-S-RET doesn't work anymore?
> #+begin_src diff > -(org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) > -(org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) > -(org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-heading) > +(org-defkey org-mode-map (kbd "S-RET>") #'org-table-copy-down) > +(org-defkey org-mode-map (kbd "M-S-RET") #'org-insert-todo-heading) > +(org-defkey org-mode-map (kbd "ESC S-RET") #'org-insert-todo-heading) > #+end_src Also notice the left over greater sign ‘>’ on the fourth line.
Re: [O] M-S-RET doesn't work anymore?
On Wed, Jan 23, 2019 at 3:54 PM Marco Wahl wrote: > As a workaround you can evaluate the lines (that were active before the > commit) > > (org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) > (org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) > (org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-heading) > > or put them into your init file AFAICS. > Yep, that commit broke the - bindings for me too. I'll have to do the same. Copying Kevin who originally requested the change of these bindings (this switching of bindings between RET and feels like dejavu to me .. I have seen this done before in Org repo). Is this a reliable fix to add these lines to the source code again? > To be honest I don't see clearly. > May be those keys should be bound to both RET and variants? For Emacs GUI, I think that the variant is needed, RET does nothing.
Re: [O] M-S-RET doesn't work anymore?
Hi! > I regularly create checkbox lists on the fly with > > 1. [ ] blah and M-S-RET to create the second entry > > 2. [ ] I can confirm this. > But the checkbox is missing today. Has this functionality changed? > > I am running the latest master from git on windows emacs 25.1 I guess the new behavior is due to commit 8a1957d59201940613ee90be9ed0a49e70131f37. #+begin_src diff -(org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) -(org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) -(org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-heading) +(org-defkey org-mode-map (kbd "S-RET>") #'org-table-copy-down) +(org-defkey org-mode-map (kbd "M-S-RET") #'org-insert-todo-heading) +(org-defkey org-mode-map (kbd "ESC S-RET") #'org-insert-todo-heading) #+end_src I think you could use M-S-C-m with the current code. As a workaround you can evaluate the lines (that were active before the commit) (org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) (org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) (org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-heading) or put them into your init file AFAICS. Is this a reliable fix to add these lines to the source code again? To be honest I don't see clearly. Ciao, Marco
Re: [O] M-S-RET doesn't work anymore?
On Wed, Jan 23, 2019 at 3:13 PM Bernt Hansen wrote: > Hi, > > I regularly create checkbox lists on the fly with > > 1. [ ] blah and M-S-RET to create the second entry > > 2. [ ] > > But the checkbox is missing today. Has this functionality changed? > > I am running the latest master from git on windows emacs 25.1 > Possible a regression caused by https://code.orgmode.org/bzg/org-mode/commit/8a1957d59201940613ee90be9ed0a49e70131f37 ?
