Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Grant Rettke]

On Wed, Jun 27, 2018 at 9:28 AM, Nicolas Goaziou  wrote:
> Grant Rettke  writes:
>> From: Grant Rettke 
>> +;; provides the 'includegraphics' command to tell LaTeX where to find
>> +;; the logo. 'includegraphics' needs to know the logo's directory and
>
> I added two spaces after the periods.

Thank you I will do that in the future.

Have a great day.

Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Nicolas Goaziou]

Hello,

Grant Rettke  writes:

> From b12a9f806cfc218bee2cfff1e550341f5999c70d Mon Sep 17 00:00:00 2001
> From: Grant Rettke 
> Date: Sat, 23 Jun 2018 20:08:09 -0500
> Subject: [PATCH] ox-koma-letter.el: Adds FROM_LOGO example
>
> FROM_LOGO uses LaTeX markup probably unfamiliar to the user.
>
> This example provides detailed documentation and examples of it's use.

I applied it with some minor changes.

> +;; Unlike other variables, FROM_LOGO uses LaTeX markup. FROM_LOGO

I removed the "unlike other variables", which isn't true.

> +;; provides the 'includegraphics' command to tell LaTeX where to find
> +;; the logo. 'includegraphics' needs to know the logo's directory and

I added two spaces after the periods.

> +;;   Logos specified using absolute paths on Linux or Windows:
> +;;
> +;;   \includegraphics{/Users/you/correspondence/logo}
> +;;   \includegraphics{/Users/you/correspondence/logos/production/logo}

I used "~/correspondence", which is more common.

Thank you!

Regards,

-- 
Nicolas Goaziou

Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Grant Rettke]

On Thu, Jun 21, 2018 at 4:37 AM, Nicolas Goaziou  wrote:
> Grant Rettke  writes:
>> If you like the additional documentation, then I will update it with
>> this and send a new patch.
>
> Let's first merge the complete documentation, then apply it, if you
> don't mind.

Happy to, mistakenly said patch.

Here is the new version. I included detail and examples.

The first one I sent was, well, woefully inadequate!


0001-ox-koma-letter.el-Adds-FROM_LOGO-example.patch
Description: Binary data

Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Nicolas Goaziou]

Hello,

Grant Rettke  writes:

> When I wrote this, I felt like because ox-koma-letter makes it so easy
> for non LaTeX Org users, that a reminder would help because this
> variable is I think the only one that requires any LaTeX knowledge.
>
> That was the context for my statement. I'm making a big assumption
> that non latex org users would benefit here.

The problem is that your assumption makes the wording inaccurate.
I think it would be better to expound this a bit, maybe with a couple of
examples, or by using meta syntactic variables:

  \includegraphics{path/to/logo}

> If you like the additional documentation, then I will update it with
> this and send a new patch.

Let's first merge the complete documentation, then apply it, if you
don't mind.

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Van L]

> If you like the additional documentation,
> then I will update it with
> this and send a new patch.

Can the documentation in the standard distribution 
include step-by-step example using XeTeX comparing 
plain TeX and LaTeX for writing a letter to PDF 
with an SVG logo placed well?

Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Grant Rettke]

On Tue, Jun 19, 2018 at 3:11 AM, Nicolas Goaziou  wrote:
> Hello,
>
> Grant Rettke  writes:
>
>> Although the function document ion mentions the markup to use, it
>> doesn't explain that the user needs to provide a logo file in the same
>> directory as the letter.
>
> Is it really necessary?

If you are comfortable with LaTeX, then it probably isn't necessary
because you already know how \includegraphics{logo} works, or you
would look it up.

When I wrote this, I felt like because ox-koma-letter makes it so easy
for non LaTeX Org users, that a reminder would help because this
variable is I think the only one that requires any LaTeX knowledge.

That was the context for my statement. I'm making a big assumption
that non latex org users would benefit here.

> Couldn't you use, e.g., \includegraphics{subdir/logo}

Yes.

If you like the additional documentation, then I will update it with
this and send a new patch.

WDYT?

Re: [O] Patch adding from-logo commentary ox-koma-letter.el

[Nicolas Goaziou]

Hello,

Grant Rettke  writes:

> Although the function document ion mentions the markup to use, it
> doesn't explain that the user needs to provide a logo file in the same
> directory as the letter.

Is it really necessary? Couldn't you use, e.g., \includegraphics{subdir/logo}

regards,

-- 
Nicolas Goaziou

Re: [O] Patch adding from-logo to ox-koma-letter.el

[Bastien]

Hi Grant,

Grant Rettke  writes:

> Here is how it works, the same way as the other ones:

If needed, don't hesitate to advertize this in the comment section
of the code.

Thanks!

-- 
 Bastien

Re: [O] Patch adding from-logo to ox-koma-letter.el

[Bastien]

Hi Grant,

Grant Rettke  writes:

> This patch adds from-logo support to ox-koma-letter.el.

Applied, thanks!

-- 
 Bastien

Re: [O] Patch adding from-logo to ox-koma-letter.el

[Grant Rettke]

On Fri, Apr 27, 2018 at 11:30 PM, Grant Rettke  wrote:
> Tested it manually with Elisp and also in buffer properties. There are
> four combinations (both in properties, both in Elisp, and then the two
> permutations).

Here is how it works, the same way as the other ones:

#+name: 
org_gcr_2018-04-27T22-46-38-05-00_mara_081C9DD8-1C37-4A55-833C-1BEC6AA754FF
#+begin_src sh
#+FROM_LOGO: \includegraphics{wnw-from-logo-1inx1in}
#+OPTIONS: from-logo:t
#+end_src

#+name: 
org_gcr_2018-04-27T22-46-38-05-00_mara_F28B56C1-0226-4AFB-B044-702315603A99
#+begin_src emacs-lisp
(setq org-koma-letter-from-logo "\\includegraphics{wnw-from-logo-1inx1in}")
(setq org-koma-letter-use-from-logo t)
#+end_src

If eventually this patch is accepted then I will update Worg with this variable.