Re: [O] Patch for testing `org-open-at-point'

2014-06-03 Thread Bastien
Hi Achim, Achim Gratz strom...@nexgo.de writes: Bastien writes: Achim Gratz strom...@nexgo.de writes: Shouldn't the test check that the desired target is actually reached? That would be too complicated. Checking that `org-open-at-point' does not throw an error is enough IMO. I don't

Re: [O] Patch for testing `org-open-at-point'

2014-06-02 Thread Achim Gratz
Bastien writes: Achim Gratz strom...@nexgo.de writes: Shouldn't the test check that the desired target is actually reached? That would be too complicated. Checking that `org-open-at-point' does not throw an error is enough IMO. I don't think so. Implemented a check for that in 8e72c8fcfa.

Re: [O] Patch for testing `org-open-at-point'

2014-06-01 Thread Bastien
Hi York, York Zhao gtdplatf...@gmail.com writes: Thank you very much for implementing this. Really appreciated. So do you think it is a good idea to add my test (the patch) now for testing this? Yes. For your convenience, I've attached again in this message the same patch I had sent on

Re: [O] Patch for testing `org-open-at-point'

2014-06-01 Thread Achim Gratz
York Zhao writes: Thank you very much for implementing this. Really appreciated. So do you think it is a good idea to add my test (the patch) now for testing this? Shouldn't the test check that the desired target is actually reached? Regards, Achim. -- +[Q+ Matrix-12 WAVE#46+305 Neuron

Re: [O] Patch for testing `org-open-at-point'

2014-06-01 Thread Bastien
Achim Gratz strom...@nexgo.de writes: York Zhao writes: Thank you very much for implementing this. Really appreciated. So do you think it is a good idea to add my test (the patch) now for testing this? Shouldn't the test check that the desired target is actually reached? That would be

Re: [O] Patch for testing `org-open-at-point'

2014-05-31 Thread York Zhao
Hi Bastien, Thank you very much for implementing this. Really appreciated. So do you think it is a good idea to add my test (the patch) now for testing this? For your convenience, I've attached again in this message the same patch I had sent on April 10. Thanks, York On Sun, Apr 20, 2014 at

Re: [O] Patch for testing `org-open-at-point'

2014-04-20 Thread Michael Strey
Hi Bastien, On 2014-04-17, Bastien wrote: The question is this: are we fine handling raw links in properties, or do we also need Org links (e.g. bracket links) there? Speaking for me, raw links is enough, and this is what I plan to implement. But maybe other users have existing use-cases

Re: [O] Patch for testing `org-open-at-point'

2014-04-20 Thread York Zhao
Hi Bastien, I apologize that I missed your reply, I discovered it until now when I was checking the replies in the Sent folder. The question is this: are we fine handling raw links in properties, or do we also need Org links (e.g. bracket links) there? To me, raw link is hardly useful because

Re: [O] Patch for testing `org-open-at-point'

2014-04-17 Thread Bastien
Hi York, York Zhao gtdplatf...@gmail.com writes: * Peter :PROPERTIES: :ADDRESS: xxx xxx :HOME_PHONE: xxx xxx xxx :WORK_PHONE: xxx xxx xxx :URL: www.foo.bar :END: The question is this: are we fine handling raw links in properties, or do we also need Org links (e.g. bracket

Re: [O] Patch for testing `org-open-at-point'

2014-04-12 Thread York Zhao
Hi Bastien, Sorry that I didn't know this was a known issue and I appreciate that you are willing to fix it. While I agree with Nicolas that it is more appropriate to keep org schedule line from being a headline property, I also think it is totally legitimate to have an org link as headline

Re: [O] Patch for testing `org-open-at-point'

2014-04-11 Thread Nicolas Goaziou
Hello, York Zhao gtdplatf...@gmail.com writes: I found a bug that `org-open-at-point' doesn't work if the link is a heading property. This is expected, as node properties cannot contain Org syntax. See also http://permalink.gmane.org/gmane.emacs.orgmode/84300 Regards, -- Nicolas

Re: [O] Patch for testing `org-open-at-point'

2014-04-11 Thread Bastien
Hi York, York Zhao gtdplatf...@gmail.com writes: I found a bug that `org-open-at-point' doesn't work if the link is a heading property. This is a known issue and we will address it soon. This used to work and was broken recently. I have written a test for this. The test is suppose to fail