Hello,
Thierry Banel tbanelweb...@free.fr writes:
This new patch takes into account all your feedback.
Thanks again for the time spent !
Patch applied (with tiny changes to comments formatting, and a few
trailing whitespaces).
Thank you for this work.
Regards,
--
Nicolas Goaziou
Le 29/08/2014 11:54, Nicolas Goaziou a écrit :
Patch applied (with tiny changes to comments formatting, and a few
trailing whitespaces).
Great!
I will now write a few words of documentation.
This page [[info:org#Org-Plot]] seems to be the right place, unless
someone has a better idea.
Hi Nicolas.
This new patch takes into account all your feedback.
Thanks again for the time spent !
Thierry
Le 28/08/2014 01:28, Nicolas Goaziou a écrit :
You forgot a space at the end of the sentence. Actually, this is the
case in all your docstrings.
Right. Fixed.
Use
Hereafter is an enhanced version of orgtbl-ascii-plot.
Thanks, Nicolas, for your feedback. Enhancements you suggested include:
- let-binding (instead of setq)
- better support for table headers (correct parsing of 'hline)
- no dependency on cl-lib (hopefully achieving Emacs 23 support)
- use
Thierry Banel tbanelweb...@free.fr writes:
Hereafter is an enhanced version of orgtbl-ascii-plot.
Thanks, Nicolas, for your feedback. Enhancements you suggested include:
- let-binding (instead of setq)
- better support for table headers (correct parsing of 'hline)
- no dependency on cl-lib
Hello,
Thierry Banel tbanelweb...@free.fr writes:
Sorry for the late answer, I was on the road.
The patch is attached hereafter.
Thank you for the patch. Some comments follow.
From 5fddaba2208c2cb4ce3b6bc24d0d10571124fb39 Mon Sep 17 00:00:00 2001
From: Thierry Banel tbanelweb...@free.fr
Thanks Nicolas
for your valuable insight. I will apply your recommendations.
Le 26/08/2014 10:29, Nicolas Goaziou a écrit :
(orgtbl-ascii-plot): top-level function
(orgtbl-ascii-draw), (orgtbl-uc-draw-grid),
Thierry Banel tbanelweb...@free.fr writes:
I'll change to let-binding. What is the rational for that ? Better
byte-code ?
This is faster, indeed. Also, the scope of the binding is explicit. It
is sometimes hard to tell where the value of a setq'ed variable comes
from.
Can I limit VALUE to
Le 26/08/2014 22:27, Nicolas Goaziou a
écrit :
Thierry Banel tbanelweb...@free.fr writes:
I'll change to let-binding. What is the rational for that ? Better
byte-code ?
This is faster, indeed. Also, the scope of the binding is
Thierry Banel tbanelweb...@free.fr writes:
Do you recommend to stay away from CL CL-LIB for ORG stuff ?
`DOLIST' comes from CL as well...
Actually, `dolist' is a macro from subr.el, which is then shadowed by
`cl-dolist', so there's no problem here.
BTW, you can use macros from cl (cl-lib
Everything is clear now.
Thanks Nicolas for those guidelines.
Regards,
Thierry
Le 27/08/2014 00:09, Nicolas Goaziou a écrit :
Actually, `dolist' is a macro from subr.el, which is then shadowed by
`cl-dolist', so there's no problem here.
BTW, you can use macros from cl (cl-lib doesn't exist in
Le 28/07/2014 16:40, Bastien a écrit :
Of course, I am still open to Dominik Carsten suggestion
to add it into the core (org-table.el).
http://thread.gmane.org/gmane.emacs.orgmode/79668
Please go ahead and provide a patch for this, I agree this
is a nice addition for Org's core.
Sorry for
Hi Thierry,
Thierry Banel tbanelweb...@free.fr writes:
I moved orgtbl-ascii-plot to MELPA (it was in Worg).
(orgtbl-ascii-plot draws plots in pure Emacs by typing C-c p).
Thanks for this.
Of course, I am still open to Dominik Carsten suggestion
to add it into the core (org-table.el).
13 matches
Mail list logo
