Re: [PATCH] Fix behavior of lambda default header arg vars

2022-07-08 Thread Ihor Radchenko
Matt Huszagh writes: > ... Try these. Thanks! Applied onto main via e8dd98d15 and 8be689f11 with amendments. I have modified the commit messages to provide the properly formatted changelog entries that include the modified function/defcustom name. Also, I have changed the commit messages and

Re: [PATCH] Fix behavior of lambda default header arg vars

2022-07-08 Thread Matt Huszagh
Ihor Radchenko writes: > This patch does not apply. It does not appear to be based on the > original main branch: > > Applying: ob-core.el: Improve org-babel-default-header-args docstring > error: sha1 information is lacking or useless (lisp/ob-core.el). > error: could not build fake ancestor

Re: [PATCH] Fix behavior of lambda default header arg vars

2022-06-29 Thread Ihor Radchenko
Matt Huszagh writes: > Modifications made and split into two patches. Let me know if any > remaining issues. > From 7af7ad3990410ca388c841e045ec66ce694b404a Mon Sep 17 00:00:00 2001 > From: Matt Huszagh > Date: Mon, 27 Jun 2022 20:42:27 -0700 > Subject: [PATCH 2/2] ob-core.el: Improve

Re: [PATCH] Fix behavior of lambda default header arg vars

2022-06-27 Thread Matt Huszagh
Hi Ihor, Modifications made and split into two patches. Let me know if any remaining issues. Thanks Matt >From fdc6e103932c68b450c72d44d062b4746ec2202c Mon Sep 17 00:00:00 2001 From: Matt Huszagh Date: Mon, 27 Jun 2022 20:41:02 -0700 Subject: [PATCH 1/2] ob-core.el: Fix behavior of lambda

Re: [PATCH] Fix behavior of lambda default header arg vars

2022-06-10 Thread Ihor Radchenko
Matt Huszagh writes: >> It would help if closure part and multi-variable part were split into >> separate paragraphs. > > The closure part and muliple header argument part are already in > separate paragraphs. The multiple header argument part, however, is > incorporated into an introductory

Re: [PATCH] Fix behavior of lambda default header arg vars

2022-06-05 Thread Matt Huszagh
> It would help if closure part and multi-variable part were split into > separate paragraphs. The closure part and muliple header argument part are already in separate paragraphs. The multiple header argument part, however, is incorporated into an introductory paragraph that very briefly

Re: [PATCH] Fix behavior of lambda default header arg vars

2022-06-05 Thread Ihor Radchenko
Matt Huszagh writes: > :var header arguments can be provided multiple times. This is supported > directly at the source block and through the default header argument > facility. However, this was not handled correctly when the var was > evaluated from a closure in a default header argument (only

Re: [PATCH] Fix behavior of lambda default header arg vars

2021-12-02 Thread Matt Huszagh
Matt Huszagh writes: > Hey Timothy, > > Any thoughts on this bug fix? > > Thanks > Matt Apologies, meant to include the org-mode mailing list in this too. Thanks Matt