Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

2024-02-14 Thread Ihor Radchenko
Anders Johansson writes: > Included is a patch for the filtering (I assumed cl-intersection was > reasonable to use since cl-lib is a requirement). > > However, I do not think this is enough, since it can cause quite > unexpected results when canonical is used without specifying the > format,

Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

2021-09-02 Thread Anders Johansson
> >> I think a proper fix would be to change `org-duration-from-minutes' so > >> it removes any unknown unit from what is provided from fmt or > >> `org-duration-format', and defaults to (special . h:mm) if nothing is > >> left. > >> > >> WDYT? > >> > > Perhaps. I don't understand

Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

2021-08-31 Thread Nicolas Goaziou
Hello, Anders Johansson writes: >> I think a proper fix would be to change `org-duration-from-minutes' so >> it removes any unknown unit from what is provided from fmt or >> `org-duration-format', and defaults to (special . h:mm) if nothing is >> left. >> >> WDYT? >> > Perhaps. I don't

Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

2021-08-31 Thread Anders Johansson
Hi, Oh, I sent a response but failed to send it to the list and only to Nicolas (hard to do things right using the gmail web interface) I include it below: > I think a proper fix would be to change `org-duration-from-minutes' so > it removes any unknown unit from what is provided from fmt or >

Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

2021-08-31 Thread Timothy
Hi Anders, Did you have any thoughts on Nicolas’ comments? Nicolas Goaziou writes: > Hello, > > Anders Johansson writes: > >> org-duration-from-minutes was called with canonical = t, but without >> providing a corresponding format only using the canonical units. This >> broke if the user’s

Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

2021-08-11 Thread Nicolas Goaziou
Hello, Anders Johansson writes: > org-duration-from-minutes was called with canonical = t, but without > providing a corresponding format only using the canonical units. This > broke if the user’s org-duration-format used other than the canonical > units. I think a proper fix would be to