Re: [PATCH] Skip entries with no ID when updating ID locations

2020-02-21 Thread Roland Everaert 
A note related to duplicate IDs, the messages only shows one of the
duplicate, so it is not easy to know which one to change.

This have implication when creating links to headline using their IDs.

And does the current algorithm for finding duplicates check their
reference through the "org db"? 

Regards,

Roland.

Bastien writes:

> Hi Eric,
>
> Eric Abrahamsen  writes:
>
>> Would the attached patch be acceptable? It's no big deal, just skips
>> entries with no ID property when updating all ID locations. I couldn't
>> figure out why I had several thousand "Duplicate ID "nil"" warnings in
>> the *Messages* buffer after updating ID locations.
>
> A welcome enhancement - applied, thanks!


-- 
Luke, use the FOSS

Sent from Emacs

Re: [PATCH] Skip entries with no ID when updating ID locations

2020-02-19 Thread Eric Abrahamsen 
Bastien  writes:

> Hi Eric,
>
> Eric Abrahamsen  writes:
>
>> Would the attached patch be acceptable? It's no big deal, just skips
>> entries with no ID property when updating all ID locations. I couldn't
>> figure out why I had several thousand "Duplicate ID "nil"" warnings in
>> the *Messages* buffer after updating ID locations.
>
> A welcome enhancement - applied, thanks!

Cool, thanks.

Re: [PATCH] Skip entries with no ID when updating ID locations

2020-02-19 Thread Bastien 
Hi Eric,

Eric Abrahamsen  writes:

> Would the attached patch be acceptable? It's no big deal, just skips
> entries with no ID property when updating all ID locations. I couldn't
> figure out why I had several thousand "Duplicate ID "nil"" warnings in
> the *Messages* buffer after updating ID locations.

A welcome enhancement - applied, thanks!

-- 
 Bastien