TEC writes:
> Kyle Meyer writes:
>
>> recent org-plot example from 8d5122fc5:
>> [...]
>> That could be rewritten as [...]
>
> Would you like me to bundle that change in somewhere?
In my view it's fine to leave it as is (it's just an example that was
fresh in my mind), but of course feel free
Kyle Meyer writes:
> Regardless of what you tend to use, you used "case" here in 73c99bf42;
> the minimal fix is to add a cl- prefix, and any other switch with the
> justification that "case is obsolete" is likely to raise a reviewer's
> eyebrow.
This makes sense.
> cl-case isn't in cl-lib,
TEC writes:
> Kyle Meyer writes:
>
>> case is still available under the cl- prefix. If you wanted to use it
>> in 73c99bf42 (org-plot.el: add utility functions for range,ticks), I
>> don't see a reason not to use it now.
>
> I tend to use pcase over cl-case (since it's completely built in, i.e.
Kyle Meyer writes:
> case is still available under the cl- prefix. If you wanted to use it
> in 73c99bf42 (org-plot.el: add utility functions for range,ticks), I
> don't see a reason not to use it now.
I tend to use pcase over cl-case (since it's completely built in, i.e.
no (require 'cl-lib)
> Subject: [PATCH] org-plot.el: fix compiler warnings
>
> * (org--plot/values-stats): Replace `log10' with `log'.
> (org--plot/nice-frequency-pick): Replace obsolete `case' with `pcase`.
case is still available under the cl- prefix. If you wanted to use it
in 73c99bf42 (org-plot.el: add utility
TEC writes:
> Kyle Meyer writes:
>
>> This series introduced some compiler warnings.
>>
>> Timothy, could you please submit a follow-up patch to address these?
>
> Absolutely. Thanks for raising this, I'll take a look shortly.
Here we go :)
>From 309907af5e76818753b85af84b3e304d8cb4568c Mon
Kyle Meyer writes:
> This series introduced some compiler warnings.
>
> Timothy, could you please submit a follow-up patch to address these?
Absolutely. Thanks for raising this, I'll take a look shortly.
--
Timothy
Bastien writes:
> Hi Timothy,
>
> TEC writes:
>
>> I'll attach all the patches to this email, so there's no ambiguity.
>> (crosses fingers for attachments working as expected)
>
> Applied, with minor modifications of the changelog entries:[...]
This series introduced some compiler warnings.
TEC writes:
> Thanks for the feedback on the patches! I tried to get it right after my
> previous (and first) attempt, but it looks like there are a few things I
> still need to take note of. Big improvement though, nonetheless,
> hopefully next time they'll be nothing to change :)
Well, It's
Bastien writes:
> Applied, with minor modifications of the changelog entries:
>
> - You need to add an entry when creating a new custom variable.
>
> - I suggest saying "option" instead of "custom variable".
>
> - Sentences should be separated by two spaces and start with an
> uppercase
Hi Timothy,
TEC writes:
> I'll attach all the patches to this email, so there's no ambiguity.
> (crosses fingers for attachments working as expected)
Applied, with minor modifications of the changelog entries:
- You need to add an entry when creating a new custom variable.
- I suggest saying
Hi Timothy,
TEC writes:
> It's now been 1.5 months, so I'm going to bump this thread.
Sure - thanks for bumping this.
I'm slowly reading emails from the past weeks, I will handle
this ASAP.
Thanks,
--
Bastien
It's now been 1.5 months, so I'm going to bump this thread.
--
Timothy
TEC writes:
> Bastien writes:
>
>> I'm not an org-plot.el user so I cannot test, but by reading the
>> patches, they look okay.
>>
>> Let's go in "optimistic merging" mode and commit your patches?
>
> Sounds good then. I
On Sat, Oct 24, 2020 at 2:21 PM TEC wrote:
> Sounds good then. I don't expect the changes to compromise any
> existing
> functionality.
I tested these patches and didn't have a problem. I didn't go out of
my way to see what changed and test it, but org-plot didn't break for
what I was doing.
I
Bastien writes:
I'm not an org-plot.el user so I cannot test, but by reading the
patches, they look okay.
Let's go in "optimistic merging" mode and commit your patches?
Sounds good then. I don't expect the changes to compromise any
existing
functionality.
Is
Hi Timothy,
TEC writes:
> I'm still hoping that someone might get back to me ... eventually,
> so here's another bump.
I'm not an org-plot.el user so I cannot test, but by reading the
patches, they look okay.
Let's go in "optimistic merging" mode and commit your patches?
Is
Hello all,
I'm still hoping that someone might get back to me ... eventually,
so here's another bump.
Timothy.
TEC writes:
Hello everyone. Just in case this has slipped through the cracks
/
fallen under the radar --- here's a little bump.
Timothy.
TEC writes:
Oooops, I've just
Hello everyone. Just in case this has slipped through the cracks /
fallen under the radar --- here's a little bump.
Timothy.
TEC writes:
> Oooops, I've just noticed my patch attachment re-send was only addressed
> to Bastien (maybe this is why I haven't heard anything?).
> This is what I get
Oooops, I've just noticed my patch attachment re-send was only addressed
to Bastien (maybe this is why I haven't heard anything?).
This is what I get for mixing mail clients and not paying attention
I guess .
If someone would be willing to have a look through my work, and comment
- that would
19 matches
Mail list logo
