Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > Unless I misunderstand what you mean, the patch seems to follow this > style. Yes, sorry, my bad, I was reacting to another patch. >> I think this should be applied to the maint branch, right? In this >> case, the patch does not apply. Can you check

Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Sébastien Miquel
Hi Bastien, Bastien writes: Also, nitpick: please don't add a full-stop at the end of the first line of the commit message (or the subject of your patch). Unless I misunderstand what you mean, the patch seems to follow this style. I think this should be applied to the maint branch, right?

Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > The issue is that currently tangling a single block by calling > `org-babel-tangle` with a prefix argument fails. This is unrelated to > the earlier thread today, but was introduced by my original commit > a2cb9b853d. > > Unfortunately, fixing it

Re: [PATCH] tangling seems to have broken today

2021-05-06 Thread Bastien
Hi Sébastien, Sébastien Miquel writes: > I apologise again for the troubles. No problem. So we're all set here? Also, nitpick: please don't add a full-stop at the end of the first line of the commit message (or the subject of your patch). Thanks, -- Bastien

Re: [PATCH] tangling seems to have broken today

2021-05-05 Thread Sébastien Miquel
Hi Bastien, The issue is that currently tangling a single block by calling `org-babel-tangle` with a prefix argument fails. This is unrelated to the earlier thread today, but was introduced by my original commit a2cb9b853d. Unfortunately, fixing it requires some refactorisation to avoid code