Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-10-26 Thread Kyle Meyer
stardiviner writes: > Bastien writes: > >> stardiviner writes: >> >>> Waited many days, seems no useful patch available. I suggest to revert that >>> commit. >> >> I will have a look over the week-end, thanks. > > Thanks for taking time to look at this problem, Bastien. As discussed at

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-10-18 Thread stardiviner
A simple temporary solution to this bug is remove hook function from ~org-cycle-hook~: #+begin_src emacs-lisp (remove-hook 'org-cycle-hook #'org-cycle-show-empty-lines) #+end_src stardiviner writes: > Bastien writes: > >> Hi, >> >> stardiviner writes: >> >>> I also did a bisect debug.

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-10-03 Thread stardiviner
Bastien writes: > stardiviner writes: > >> Waited many days, seems no useful patch available. I suggest to revert that >> commit. > > I will have a look over the week-end, thanks. Thanks for taking time to look at this problem, Bastien. -- [ stardiviner ] I try to make every word

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-10-03 Thread Bastien
stardiviner writes: > Waited many days, seems no useful patch available. I suggest to revert that > commit. I will have a look over the week-end, thanks. -- Bastien

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-10-03 Thread stardiviner
Kyle Meyer writes: > Ihor Radchenko writes: > >> Subject: [PATCH] Do not remove trailing newline when deleting planning info >> line. >> >> * lisp/org.el (org-add-planning-info): Remove front newline instead of >> trailing newline when deleting planning info is completetly removed >> from a

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-27 Thread Ihor Radchenko
> Did you intended to send a different patch? This looks to be the same > patch you sent at . I have no patch for the bug report in this thread. The patch I sent was intended for https://orgmode.org/list/87ft78608z.fsf@localhost. > But, trying

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-27 Thread Kyle Meyer
Ihor Radchenko writes: > Subject: [PATCH] Do not remove trailing newline when deleting planning info > line. > > * lisp/org.el (org-add-planning-info): Remove front newline instead of > trailing newline when deleting planning info is completetly removed > from a heading. Fixes "Cycling through

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-23 Thread Ihor Radchenko
> I did a git bisect test, found the bad commit. > "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back" Additional observation: The unfolding does not happen because org-cycle-show-empty-lines _always_ reveals trailing empty lines at the end of buffer. It breaks the assumption in

[PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-23 Thread Ihor Radchenko
> Also, if you can provide a patch, please go ahead. Here it is. >From 8e99e5dea780041d314f666f506a120224f064eb Mon Sep 17 00:00:00 2001 From: Ihor Radchenko Date: Wed, 23 Sep 2020 21:54:47 +0800 Subject: [PATCH] Do not remove trailing newline when deleting planning info line. * lisp/org.el

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-23 Thread stardiviner
Bastien writes: > Hi, > > stardiviner writes: > >> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ >> in hook >> ~org-cycle-hook~ caused this problem. > > Did you find the commit that introduces this bug? I did a git bisect test, found the bad commit. "ee3c3b554

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-23 Thread Bastien
Hi, stardiviner writes: > I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in > hook > ~org-cycle-hook~ caused this problem. Did you find the commit that introduces this bug? Also, if you can provide a patch, please go ahead. Thanks! -- Bastien

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-23 Thread Bastien
Hi Nicholas, "Nicholas Savage" writes: > I can reproduce this. PS: when confirming a bug, you can add either reply with "Confirmed" at the beginning of a line, or add X-Woof-Bug: confirmed as a header, then the bug will appeaer in https://updates.orgmode.org. See

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-22 Thread stardiviner
I can reproduce this problem too. I'm on Emacs 28.0.50 with Org Mode master branch latest commit "aea1109ef". I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook ~org-cycle-hook~ caused this problem. Nicholas Savage writes: > I can reproduce this. I'm on the

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-09-19 Thread Nicholas Savage
I can reproduce this. I'm on the most recent master with Emacs 28.0.50. Once the last line is deleted, org-cycle won't show the "**" line and the minibuffer continues to say "FOLDING" instead of cycling through the various states. On Sat, Sep 19, 2020, at 12:10, B Goodr wrote: > Hi, > > Still