Re: Possible fix for :includes header argument in org-babel C source blocks

2020-06-01 Thread Brandon Guttersohn
Note that IIUC, for non-system includes to work, either - the filenames must be absolute, or - the compiler must be given -I arguments through org-babel-C-compiler. This variable can be set (e.g. to "gcc -I .") with file or directory-local variables. Should we promote this method in NEWS?

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-06-01 Thread Kévin Le Gouguec
Bastien writes: > Brandon Guttersohn writes: > >> So this patch is sort of a >> new feature, but a trivial one. > > Agreed. Could you or Kevin propose a sentence to advertise this small > enhancement in etc/ORG-NEWS? Here goes nothing. >From b18f6dc66ea4a05c95a4ee6825723da4beaa1c83 Mon Sep

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-06-01 Thread Bastien
Brandon Guttersohn writes: > So this patch is sort of a > new feature, but a trivial one. Agreed. Could you or Kevin propose a sentence to advertise this small enhancement in etc/ORG-NEWS? -- Bastien

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-30 Thread Brandon Guttersohn
I don't know if it's been mentioned in the "issue tracker?" thread, but if I could pick just *one* feature off web-based forges, it'd be automated testing with CI… [...] Automated testing has been a massive time-saver everywhere I've seen it used, though I'm not sure I've ever seen it

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-29 Thread Kévin Le Gouguec
Brandon Guttersohn writes: > Apologies for the regression, and thank you for fixing it. I neglected > to run the tests before suggesting that fix -- I'll try not to do that > again.. No biggie, that got me to finally try out Babel ;) I don't know if it's been mentioned in the "issue tracker?"

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-28 Thread Brandon Guttersohn
Hey Kévin, Apologies for the regression, and thank you for fixing it. I neglected to run the tests before suggesting that fix -- I'll try not to do that again.. I can at least confirm that the patch wasn't intended to change how C-header-files are specified in the org-babel-block-header. The

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-28 Thread Kyle Meyer
Kévin Le Gouguec writes: > Here is a patch to fix the regression: Thanks, applied (6506ea1). > And here is a patch to add a test for the unquoted-single-header case, > since otherwise it's hard to tell whether this behaviour is intentional: Looks good to me. Thanks for taking the time to add

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-28 Thread Kyle Meyer
Kévin Le Gouguec writes: > BTW, does the change from 44cb98fdb deserve an ORG-NEWS entry? Hmm, my impression from the thread/patch was that it was a plain bug fix, in which case I think the lack of an entry is fine.

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-28 Thread Kévin Le Gouguec
Kévin Le Gouguec writes: > That leads me to believe that the coercion was an unintended side-effect > of (format …). Never mind, the ORG-NEWS entry for 9.1 shows an example of unquoted header, so I guess it is intentional. Here is a patch to fix the regression: >From

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-28 Thread Kévin Le Gouguec
Kyle Meyer writes: > I think this discussion was on emacs-devel only, so here are some links > for others who might go looking for more context: > > https://lists.gnu.org/archive/html/emacs-devel/2020-04/msg01880.html > https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg03051.html

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-27 Thread Kyle Meyer
Kévin Le Gouguec writes: > Bastien writes: > >> Brandon Guttersohn writes: >> >>> Hey all, I think I may have a small fix for executing C source blocks >>> in org-babel. Or, possibly just a bad case of user error. >>> >>> The issue (in emacs 27 with -q) is that it doesn't seem possible to >>>

Re: Possible fix for :includes header argument in org-babel C source blocks

2020-05-27 Thread Kévin Le Gouguec
Hi, Bastien writes: > Brandon Guttersohn writes: > >> Hey all, I think I may have a small fix for executing C source blocks >> in org-babel. Or, possibly just a bad case of user error. >> >> The issue (in emacs 27 with -q) is that it doesn't seem possible to >> specify non-system header files