Re: ob-java and ob-haxe

2020-09-23 Thread Bastien
ian martins writes: > I'll submit ob-haxe to GNU ELPA after ob-java has been accepted. Thanks - I confirm contrib/ is not the place anymore for external elisp packages, better to go on GNU ELPA. -- Bastien

Re: ob-java and ob-haxe

2020-09-23 Thread Bastien
Hi Ian, ian martins writes: > Sure, I'd be happy to maintain ob-java. thanks again for maintaining ob-java.el -- I've add you as the maintainer in ob-java.el header. Org 9.4 is out, feel free to push improvements. Thanks! -- Bastien

Re: ob-java and ob-haxe

2020-09-05 Thread Bastien
Hi Ian, ian martins writes: > It primarily adds features. Okay, thanks for the feedback, let's wait a bit then. > It fixes the problem reported here [1] but that's probably not a > common problem and the person who reported it probably already > migrated. Indeed. Best, -- Bastien

Re: ob-java and ob-haxe

2020-09-05 Thread ian martins
It primarily adds features. It fixes the problem reported here [1] but that's probably not a common problem and the person who reported it probably already migrated. [1] https://orgmode.org/list/87d05nidu1@iki.fi/ On Sat, Sep 5, 2020 at 9:04 AM Bastien wrote: > Hi Ian, > > ian martins

Re: ob-java and ob-haxe

2020-09-05 Thread Bastien
Hi Ian, ian martins writes: > Sure, I'd be happy to maintain ob-java. Thanks! Does your work on ob-java.el fix bugs or does it foremost add new features? If the former, we can add it now to master, then add you as a maintainer immediately. > The drawback with keeping ob-haxe in an external

Re: ob-java and ob-haxe

2020-09-05 Thread ian martins
Hi Bastien, Sure, I'd be happy to maintain ob-java. The drawback with keeping ob-haxe in an external repo is that the tests won't run when org-mode is changed, but in practice its tests are very similar to ob-java's so the actual risk of it being broken by a change will be small if ob-java is in

Re: ob-java and ob-haxe

2020-09-04 Thread Bastien
Hi Ian, thanks for your work on this. Changes for ob-java.el should go in core after the 9.4 release. By the way, if you want to be ob-java.el maintainer, that'd be appreciated too! For ob-haxe.el, as Kyle suggests, let's prefer GNU ELPA (or upcoming Non-GNU ELPA): Elisp files in contrib/ will

Re: ob-java and ob-haxe

2020-09-03 Thread ian martins
That is understandable; they're big patches. I recommend going over ob-java first. Java is probably more familiar to you and ob-java and ob-haxe are very similar. These were mostly based on ob-python and ob-C. The tests are based on ob-Cs tests. Look carefully at org-babel-temp-dir and org-babel

Re: ob-java and ob-haxe

2020-09-02 Thread Kyle Meyer
ian martins writes: > I posted patches for ob-java and ob-haxe a couple months ago but there was > no interest. I have been given access to push to contrib. If there's no > objection I'll put them there. > > I'll rename my version ob-java-alt so it doesn't conflict with the

ob-java and ob-haxe

2020-09-02 Thread ian martins
I posted patches for ob-java and ob-haxe a couple months ago but there was no interest. I have been given access to push to contrib. If there's no objection I'll put them there. I'll rename my version ob-java-alt so it doesn't conflict with the official one. The contrib directory doesn't have