Re: Catching "no binaryen method succeeded" under Chrome

2018-10-06 Thread Beuc
Thanks a lot, -incoming with this patch runs fine in my Chromium :) - Sylvain On 06/10/2018 15:56, Alon Zakai wrote: > Looks like recent improvements make it easy to remove this specific > limitation, I opened > > https://github.com/kripken/emscripten/pull/7235 > > On Fri, Oct 5, 2018 at 4:32 PM

Re: Catching "no binaryen method succeeded" under Chrome

2018-10-06 Thread Alon Zakai
Looks like recent improvements make it easy to remove this specific limitation, I opened https://github.com/kripken/emscripten/pull/7235 On Fri, Oct 5, 2018 at 4:32 PM Beuc wrote: > Yeah that's my second point basically. > Check tools/shared.py:is_wasm_only() for the flags. > (Incidentally,

Re: Catching "no binaryen method succeeded" under Chrome

2018-10-05 Thread Beuc
Yeah that's my second point basically. Check tools/shared.py:is_wasm_only() for the flags. (Incidentally, any chance this issue could be fixed in chrom*? ;)) On 06/10/2018 01:13, Sam Clegg wrote: > I think the thing we really want to fix here is the fact the async > compilation is disabled under

Re: Catching "no binaryen method succeeded" under Chrome

2018-10-05 Thread Sam Clegg
I think the thing we really want to fix here is the fact the async compilation is disabled under certain circumstances. For projects of any reasonable size we want to always be doing async compiles, which will fix the issue on chrome. I'm not sure exactly which combination of flags trigger