I created a partial revert to keep EMSCRIPTEN_ROOT in the config for
now: https://github.com/kripken/emscripten/pull/7411
On Tue, Oct 30, 2018 at 10:09 AM Sam Clegg wrote:
>
> On Tue, Oct 30, 2018 at 2:16 AM Jukka Jylänki wrote:
> >
> > > Imagine you run `emcc` and if
> > parses the config file
On Tue, Oct 30, 2018 at 2:16 AM Jukka Jylänki wrote:
>
> > Imagine you run `emcc` and if
> parses the config file and finds EMSCRIPTEN_ROOT pointing to different
> version of emscripten.
>
> I would recommend not removing EMSCRIPTEN_ROOT, but rather issuing a
> warning if this scenario is met (if
> Imagine you run `emcc` and if
parses the config file and finds EMSCRIPTEN_ROOT pointing to different
version of emscripten.
I would recommend not removing EMSCRIPTEN_ROOT, but rather issuing a
warning if this scenario is met (if we don't already?). It would be a
good way to validate that the
Godot Engine reads EMSCRIPTEN_ROOT from the file specified by EM_CONFIG or
~/.emscripten. Since emcc is not usually available in PATH, if
EMSCRIPTEN_ROOT
is removed, it will no longer be possible to locate it automatically. The
user
has to either manually add emcc to PATH, or source the
Everything still working, so no worries :)
BUT: maybe interesting info for you, I tried removing the --em-config
argument somewhat expecting that everything still works, but got compile
errors like this:
opt: Unknown command line argument '-lower-non-em-intrinsics'. Try:
On Thu, Oct 18, 2018 at 11:51 AM Floh wrote:
>
> > However, i don't think you can change the emscripten SDK dir by using
> > --em-config (can you?).
>
> It does seem to work when using both --em-config and --cache both for emcc
> and emar. This is what I'm doing to use a "local" workspace
> However, i don't think you can change the emscripten SDK dir by using
--em-config (can you?).
It does seem to work when using both --em-config and --cache both for emcc
and emar. This is what I'm doing to use a "local" workspace emscripten
install for cmake (all emscripten tools will also
On Wed, Oct 10, 2018 at 1:56 PM Floh wrote:
>
> Does this fix change the behaviour of the the "--em-config" and "--cache"
> cmdline args of emcc and emar to point to a local emscripten SDK install?
>
> For me it's important that I don't have that "one and only" central
> emscripten SDK, but
This makes sense, if we can configure EMSCRIPTEN_ROOT automagically, all
the better.
I mentioned LLVM_ROOT since Sam's use case was "parses the config file
and finds EMSCRIPTEN_ROOT pointing to different version" - I mean if
.emscripten is out-of-sync there will be other problems, but that's when
LLVM_ROOT is somewhat different - we have to be given the path to LLVM
somehow. But emscripten code should know where emscripten is (since every
python script can tell, etc.). So there is a risk of getting out of sync
for EMSCRIPTEN_ROOT, and I think it makes sense to remove it, but not
LLVM_ROOT,
Does this fix change the behaviour of the the "--em-config" and "--cache"
cmdline args of emcc and emar to point to a local emscripten SDK install?
For me it's important that I don't have that "one and only" central
emscripten SDK, but separate versions per "workspace", and I'm using the
Hi,
I believe we'd need to deal with LLVM_ROOT as well, since the fastcomp
version needs to be in sync with emscripten's?
- Sylvain
On 10/10/2018 02:41, Sam Clegg wrote:
> TLDR: There is a field in called EMSCRIPTEN_ROOT in the config file
> which in theory can be used by external tools to find
TLDR: There is a field in called EMSCRIPTEN_ROOT in the config file
which in theory can be used by external tools to find the "active"
emscripten. I'm proposing to remove it.
---
Maintaining this field has a cost and it can get out of sync with the
emscripten you are actually using.Imagine
13 matches
Mail list logo
