Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Yair Zaslavsky
On 09/10/2012 09:09 AM, Itamar Heim wrote: On 09/10/2012 09:05 AM, Yair Zaslavsky wrote: On 09/10/2012 09:04 AM, Itamar Heim wrote: On 09/10/2012 08:55 AM, Livnat Peer wrote: The obvious advantage of keeping them in the DB vs. in code is they can be changed with no compilation required and

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Alon Bar-Lev
- Original Message - > From: "Livnat Peer" > To: "Itamar Heim" > Cc: "Alon Bar-Lev" , engine-devel@ovirt.org > Sent: Monday, September 10, 2012 9:19:00 AM > Subject: Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options > > On 10/09/12 09:04, Itamar Heim wrote: > > On 09/1

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Livnat Peer
On 10/09/12 09:04, Itamar Heim wrote: > On 09/10/2012 08:55 AM, Livnat Peer wrote: >> The obvious advantage of keeping them in the DB vs. in code is they can >> be changed with no compilation required and today you don't need to >> restart the application for changing some of them (WIP). > > you c

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Itamar Heim
On 09/10/2012 09:05 AM, Yair Zaslavsky wrote: On 09/10/2012 09:04 AM, Itamar Heim wrote: On 09/10/2012 08:55 AM, Livnat Peer wrote: The obvious advantage of keeping them in the DB vs. in code is they can be changed with no compilation required and today you don't need to restart the applicati

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Yair Zaslavsky
On 09/10/2012 09:04 AM, Itamar Heim wrote: On 09/10/2012 08:55 AM, Livnat Peer wrote: The obvious advantage of keeping them in the DB vs. in code is they can be changed with no compilation required and today you don't need to restart the application for changing some of them (WIP). you can s

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Itamar Heim
On 09/10/2012 08:55 AM, Livnat Peer wrote: The obvious advantage of keeping them in the DB vs. in code is they can be changed with no compilation required and today you don't need to restart the application for changing some of them (WIP). you can still change them in the db without code by ove

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Livnat Peer
On 10/09/12 00:58, Alon Bar-Lev wrote: > Hello All, > > I would like to discuss the method we use to manage default options. I > believe it can be significantly simplified. > > Please read though and comment. > > Thank you, > Alon Bar-Lev > > --- > > CURRENT STATE > > Most options are locate

Re: [Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Yair Zaslavsky
On 09/10/2012 12:58 AM, Alon Bar-Lev wrote: Hello All, I would like to discuss the method we use to manage default options. I believe it can be significantly simplified. Please read though and comment. Thank you, Alon Bar-Lev --- CURRENT STATE Most options are located in three different

[Engine-devel] [RFC] ovirt-engine - vdc_config default options

2012-09-09 Thread Alon Bar-Lev
Hello All, I would like to discuss the method we use to manage default options. I believe it can be significantly simplified. Please read though and comment. Thank you, Alon Bar-Lev --- CURRENT STATE Most options are located in three different locations. Let's explain by example... The Fenc

Re: [Engine-devel] commit breaks ovirt-engine due to compilation error

2012-09-09 Thread Moti Asayag
I've submitted a patch to bypass the failure created by that commit. http://gerrit.ovirt.org/#/c/7865/1 Yaniv, please submit a proper solution for it if meant differently. On 09/09/2012 12:53 PM, Eyal Edri wrote: > this commit break ovirt-engine on jenkins.ovirt.org: > > http://jenkins.ovirt.o

[Engine-devel] commit breaks ovirt-engine due to compilation error

2012-09-09 Thread Eyal Edri
this commit break ovirt-engine on jenkins.ovirt.org: http://jenkins.ovirt.org/job/ovirt_engine_animal_sniffer_check/425/org.ovirt.engine.core$vdsbroker/changes#detail0 core: add vdsName to vdsBroker log info (#853883) (details) Commit 35c2e7ceb5109c9349e3699c3f53414cbe0b4c4e by ybronhei core: add