Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-21 Thread Shubhendu Tripathi
On 11/11/2013 08:48 PM, Einav Cohen wrote: - Original Message - From: Shubhendu Tripathi shtri...@redhat.com Sent: Saturday, November 9, 2013 4:07:44 AM On 11/06/2013 07:40 PM, Einav Cohen wrote: - Original Message - From: Alexander Wels aw...@redhat.com Sent: Wednesday,

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-11 Thread Einav Cohen
- Original Message - From: Shubhendu Tripathi shtri...@redhat.com Sent: Saturday, November 9, 2013 4:07:44 AM On 11/06/2013 07:40 PM, Einav Cohen wrote: - Original Message - From: Alexander Wels aw...@redhat.com Sent: Wednesday, November 6, 2013 8:28:13 AM Looking

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-09 Thread Shubhendu Tripathi
On 11/06/2013 07:40 PM, Einav Cohen wrote: - Original Message - From: Alexander Wels aw...@redhat.com Sent: Wednesday, November 6, 2013 8:28:13 AM Looking at the code, if you start the error message with a $ it will not do the . to _ replacement. Not sure if your error message will now

[Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Shubhendu Tripathi
Hi, In the case of Gluster, as there are no one to one mappings available for all the error messages from Gluster, we set the error in the VdcFault object as NULL. We also populate the actual error from the Gluster as error message in the fault object.

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Alexander Wels
Looking at the code, if you start the error message with a $ it will not do the . to _ replacement. Not sure if your error message will now simply start with a $, but it is worth a try I guess. On Wednesday, November 06, 2013 03:37:34 PM Shubhendu Tripathi wrote: Hi, In the case of Gluster,

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Einav Cohen
- Original Message - From: Alexander Wels aw...@redhat.com Sent: Wednesday, November 6, 2013 8:28:13 AM Looking at the code, if you start the error message with a $ it will not do the . to _ replacement. Not sure if your error message will now simply start with a $, but it is worth

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Einav Cohen
but if the message is not a key, and would be displayed as-is, on . to _ replacement should take place. on - no* - Original Message - From: Einav Cohen eco...@redhat.com Sent: Wednesday, November 6, 2013 9:10:09 AM - Original Message - From: Alexander Wels

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Daniel Erez
- Original Message - From: Shubhendu Tripathi shtri...@redhat.com To: de...@redhat.com, engine-devel engine-devel@ovirt.org Cc: Dusmant Pati dp...@redhat.com Sent: Wednesday, November 6, 2013 12:07:34 PM Subject: IMP: Regarding an issue while translating the error messages for

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Shubhendu Tripathi
On 11/06/2013 07:43 PM, Daniel Erez wrote: - Original Message - From: Shubhendu Tripathi shtri...@redhat.com To: de...@redhat.com, engine-devel engine-devel@ovirt.org Cc: Dusmant Pati dp...@redhat.com Sent: Wednesday, November 6, 2013 12:07:34 PM Subject: IMP: Regarding an issue while

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Shubhendu Tripathi
On 11/06/2013 07:41 PM, Einav Cohen wrote: but if the message is not a key, and would be displayed as-is, on . to _ replacement should take place. on - no* This solution looks fine. If the error message is not found in the map, we can revert back to original message which has the .s. Request

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Daniel Erez
- Original Message - From: Shubhendu Tripathi shtri...@redhat.com To: Daniel Erez de...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Dusmant Pati dp...@redhat.com Sent: Wednesday, November 6, 2013 4:31:52 PM Subject: Re: IMP: Regarding an issue while translating the error

Re: [Engine-devel] IMP: Regarding an issue while translating the error messages for gluster using ErrorTranslator class

2013-11-06 Thread Shubhendu Tripathi
On 11/06/2013 09:29 PM, Daniel Erez wrote: - Original Message - From: Shubhendu Tripathi shtri...@redhat.com To: Daniel Erez de...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Dusmant Pati dp...@redhat.com Sent: Wednesday, November 6, 2013 4:31:52 PM Subject: Re: IMP: Regarding