On 02/15/2012 06:30 PM, Ewoud Kohl van Wijngaarden wrote:
On Wed, Feb 15, 2012 at 11:15:27AM -0500, Jon Choate wrote:
I'd like to add to that:
If you give at patch the verified flag this implies that you have:
1. pulled the patch locally and ensured that it builds
2. have run all the unit tests and ensure that they all pass
If either of these are not true, you need to give the patch "-1
Fails" If you don't do this you are as much to blame as the author.
There's a jenkins plugin that builds each patch and gives -1 or +1
depending on if it builds. Now I don't know if we have the computing
power to do the same, but it might be worth considering. See
https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger.
indeed. eyal is fighting some hopefully last maven3 conflicts between
git/gerrit plugin to get this rolling.
_______________________________________________
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
