Livnat Peer has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 2: (3 inline comments)
File
Mike Kolesnik has posted comments on this change.
Change subject: engine: [DO-NOT-MERGE] Project Lombok POC
..
Patch Set 2: Fails
Rebased, returned @NotNull validation to diskInterface.
Again, do not merge
--
To view, visit
Livnat Peer has posted comments on this change.
Change subject: core : Introducing of use of locks at related to disk commands
..
Patch Set 2: Looks good to me, approved
(3 inline comments)
I rephrased dome of the comments
Michael Kublin has posted comments on this change.
Change subject: core : Introducing of use of locks at related to disk commands
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit
ovirt_engine_unit_tests - Build # 571 - Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/571/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 2: (3 inline comments)
Answering lpeer's comments
Allon Mureinik has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 3: Verified
Fixed according to lpeer's comments from the previous patchset that did not
require additional
Allon Mureinik has posted comments on this change.
Change subject: core: Set quota as non default when edited
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3424
To unsubscribe, visit
Gilad Chaplik has abandoned this change.
Change subject: webadmin: support MSD with quota
..
Patch Set 6: Abandoned
Pushed in another patch set
--
To view, visit http://gerrit.ovirt.org/3266
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Support for reusing default quotas
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3423
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Remove PowerMockito from QuotaHelperTest
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3422
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3425
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Minor clean up in QuotaHelper
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3421
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Improvements for AddEmptyStoragePoolCommand
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3420
To unsubscribe, visit
Livnat Peer has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
--
To view, visit http://gerrit.ovirt.org/3426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Omer Frenkel has posted comments on this change.
Change subject: core: Check permissions on disk when editing disk
..
Patch Set 2: (1 inline comment)
File
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Clone VM from snapshots tweaks
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3418
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: core: Add disk actions and predefined roles
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3396
To unsubscribe, visit
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: fixing quota mode enum translation
..
webadmin: fixing quota mode enum translation
Change-Id: I80e8152fb770aa0a7f33294a1ef1a8f66983e0e2
---
M
Omer Frenkel has posted comments on this change.
Change subject: core: Check permission on Storage Domain when adding disk
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3399
To
Omer Frenkel has posted comments on this change.
Change subject: core: Check permissions on disk when removing a disk
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3401
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: QuotaEnforcementTypeEnum typo fix
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3415
To unsubscribe,
Gilad Chaplik has abandoned this change.
Change subject: webadmin: fixing quota mode enum translation
..
Patch Set 1: Abandoned
fixed already by derez
--
To view, visit http://gerrit.ovirt.org/3446
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 7:
Gal,
Now I can run ovirt-guest-agent as a service on Windows by the following steps:
ovirt_engine_unit_tests - Build # 572 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/572/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
..
Patch Set 3: (5 inline comments)
Looks good, only minor cosmetic comments
Allon Mureinik has posted comments on this change.
Change subject: core: Support for reusing default quotas
..
Patch Set 4: Verified
changed getUnlimitedQuota's API to return a PairQuota,Boolean instead of
having a RefObject
Allon Mureinik has posted comments on this change.
Change subject: core: Set quota as non default when edited
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/3424
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
..
Patch Set 4: Verified
rebase, no changes since last patchset.
--
To view, visit http://gerrit.ovirt.org/3425
Allon Mureinik has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 4: Verified
rebase, answered lpeer's comments on getUnlimitedQuota's API.
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Set quota as non default when edited
..
Patch Set 4: (1 inline comment)
File
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
..
Patch Set 4:
Answered mlipchuk's comments.
Fixes will be submitted in the next patchset.
--
To view, visit
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Clone VM from snapshots tweaks
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3418
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Improvements for AddEmptyStoragePoolCommand
..
Patch Set 3: (1 inline comment)
File
Daniel Erez has posted comments on this change.
Change subject: core: Update integer value of StorageType.All
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit
Daniel Erez has posted comments on this change.
Change subject: webadmin: QuotaEnforcementTypeEnum typo fix
..
Patch Set 3:
rebsaed
--
To view, visit http://gerrit.ovirt.org/3415
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: webadmin: QuotaEnforcementTypeEnum typo fix
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3415
To
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: QuotaEnforcementTypeEnum typo fix
..
webadmin: QuotaEnforcementTypeEnum typo fix
* Correlating with engine's typo fix:
Maor Lipchuk has posted comments on this change.
Change subject: core: Minor clean up in QuotaHelper
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3421
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove PowerMockito from QuotaHelperTest
..
Patch Set 3: (1 inline comment)
File
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 7:
Thanks Danny!
--
To view, visit http://gerrit.ovirt.org/3209
To unsubscribe, visit
ovirt_engine_unit_tests - Build # 573 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/573/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Livnat Peer has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
I wrote an optional comment, other than
Daniel Erez has posted comments on this change.
Change subject: webadmin: Clone VM from snapshots tweaks
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3418
To
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Clone VM from snapshots tweaks
..
webadmin: Clone VM from snapshots tweaks
* Use GetCommandsCompatibilityVersions query for getting
cluster's
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: quota tab availability acc to tree
..
webadmin: quota tab availability acc to tree
Show quota main tab only when tree navigation is on system or DC,
Daniel Erez has posted comments on this change.
Change subject: webadmin: quota tab availability acc to tree
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3449
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: quota tab availability acc to tree
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3449
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: quota tab availability acc to tree
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/3449
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: quota tab availability acc to tree
..
webadmin: quota tab availability acc to tree
Show quota main tab only when tree navigation is on system
Allon Mureinik has posted comments on this change.
Change subject: core: Improvements for AddEmptyStoragePoolCommand
..
Patch Set 3: (1 inline comment)
answered comments, will fix in next patchset.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove PowerMockito from QuotaHelperTest
..
Patch Set 3: (1 inline comment)
answered review, fixes in next patchset.
Allon Mureinik has posted comments on this change.
Change subject: core: Set quota as non default when edited
..
Patch Set 4: (1 inline comment)
File
Allon Mureinik has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 4: (1 inline comment)
File
Roy Golan has uploaded a new change for review.
Change subject: core: clean XML annotations
..
core: clean XML annotations
Change-Id: I59c8482f6107c962f0bfb5b1d12c1ec77bab0d4c
---
M
Roy Golan has uploaded a new change for review.
Change subject: core: share common plug/unplug messages and checks
..
core: share common plug/unplug messages and checks
Change-Id: I2430b965b8456e1a59fbb46b04fd6f59ef27a899
---
M
Roy Golan has uploaded a new change for review.
Change subject: core: extract mappers for VmNetworkDao
..
core: extract mappers for VmNetworkDao
Change-Id: I060ac8bcd295f81d34470a48d881f1e3fb028d16
---
M
Roy Golan has uploaded a new change for review.
Change subject: core: unifiy hostplug cando checks under Vmcommand
..
core: unifiy hostplug cando checks under Vmcommand
Change-Id: Ia033aaa550588016399c33929294d2da550174a4
---
M
Roy Golan has uploaded a new change for review.
Change subject: core: clean linq and convertion leftovers
..
core: clean linq and convertion leftovers
Change-Id: Ib08d030212f3d9bd64cd70bc81290cc5625f09fb
---
M
Roy Golan has uploaded a new change for review.
Change subject: core: support hot plug when adding a VM nic
..
core: support hot plug when adding a VM nic
when a VM is up the newly added nic will be hot plugged to it.
Roy Golan has uploaded a new change for review.
Change subject: core: DAL add active to vm_interface_view
..
core: DAL add active to vm_interface_view
Change-Id: I1436a4ec75b627de7700bd95207bfb5df672b173
---
M
Roy Golan has abandoned this change.
Change subject: engine-core: supported OS of plug/unplug shuould rely on
VmOsType
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3203
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: core : Renaming of AddiskToVmCommand to AddDiskCommand
..
Patch Set 2: (2 inline comments)
File
ovirt_engine_unit_tests - Build # 575 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/575/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Roy Golan has posted comments on this change.
Change subject: wip - don't submit: rest session-management
..
Patch Set 4: (2 inline comments)
File
Allon Mureinik has posted comments on this change.
Change subject: core: Improvements for AddEmptyStoragePoolCommand
..
Patch Set 4: Verified
rebsaed, answered mlipchuk's review.
--
To view, visit http://gerrit.ovirt.org/3420
Allon Mureinik has posted comments on this change.
Change subject: core: Minor clean up in QuotaHelper
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
rebsaed, no changes since last +2 reiview.
--
To
Allon Mureinik has posted comments on this change.
Change subject: core: Remove PowerMockito from QuotaHelperTest
..
Patch Set 4: Verified
rebsaed, answered mlipchuk's review.
--
To view, visit http://gerrit.ovirt.org/3422
To
Allon Mureinik has posted comments on this change.
Change subject: core: Set quota as non default when edited
..
Patch Set 5: Verified
rebsaed, answered mlipchuk's review.
--
To view, visit http://gerrit.ovirt.org/3424
To
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup UpdateStoragePoolCommand, etc.
..
Patch Set 5: Verified
rebsaed, answered mlipchuk's review.
--
To view, visit http://gerrit.ovirt.org/3425
To
Allon Mureinik has posted comments on this change.
Change subject: core: Reuse default quota on DC update
..
Patch Set 5: Verified
rebsaed, answered mlipchuk's and lpeer's review.
--
To view, visit
Allon Mureinik has uploaded a new change for review.
Change subject: core: flag RefObject as @Deprecated
..
core: flag RefObject as @Deprecated
It's a consensus in the community this class is an anti-pattern, and
should not be
Allon Mureinik has posted comments on this change.
Change subject: core: flag RefObject as @Deprecated
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3459
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core : Renaming of AddiskToVmCommand to AddDiskCommand
..
Patch Set 2: (2 inline comments)
File
Shahar Havivi has uploaded a new change for review.
Change subject: restapi: add VmPayload support
..
restapi: add VmPayload support
Change-Id: I75d42a1963e537ff4e2f1fdd50ee7f2b427c6076
---
A
Omer Frenkel has posted comments on this change.
Change subject: core: Refactor VmDeviceUtils.addImportedDevices()
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3235
To unsubscribe, visit
Michael Kublin has uploaded a new change for review.
Change subject: core : Able to create VM from template on illegal storage
domain (#811603)
..
core : Able to create VM from template on illegal storage domain (#811603)
Yair Zaslavsky has posted comments on this change.
Change subject: core : Able to create VM from template on illegal storage
domain (#811603)
..
Patch Set 1: (2 inline comments)
Omer Frenkel has posted comments on this change.
Change subject: core : Renaming of AddiskToVmCommand to AddDiskCommand
..
Patch Set 2: (1 inline comment)
File
Yair Zaslavsky has posted comments on this change.
Change subject: core : Able to create VM from template on illegal storage
domain (#811603)
..
Patch Set 1: Looks good to me, approved
Questions answered.
--
To view, visit
Omer Frenkel has posted comments on this change.
Change subject: core: Change snapshot to synchronize on config
..
Patch Set 1: (1 inline comment)
File
ovirt_engine_unit_tests - Build # 576 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/576/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Daniel Erez has posted comments on this change.
Change subject: webadmin: Renaming AddDiskToVmCommand to AddDiskCommand
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3388
To unsubscribe,
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: move/copy disks dialog - non-active sd
..
webadmin: move/copy disks dialog - non-active sd
Handling non-active storage domains on Move/Copy disks
Juan Hernandez has uploaded a new change for review.
Change subject: restapi: Add a default value for SPM priority (#808629)
..
restapi: Add a default value for SPM priority (#808629)
https://bugzilla.redhat.com/808629
Without
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Fix DAO use with templates multiple storages
..
core: Fix DAO use with templates multiple storages
The next patch has the following changes:
1. Introduce
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix DAO use with templates multiple storages
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3477
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add query for getting storages
..
core: Add query for getting storages
Adding new query for fetching all storage domains by image id.
Change-Id:
Saggi Mizrahi has abandoned this change.
Change subject: Use Shorthand methods in UpdateVdsGroupCommand
..
Patch Set 3: Abandoned
There is no reason helping those who refuse to be helped
--
To view, visit
Saggi Mizrahi has abandoned this change.
Change subject: Try and fix condition in UpdateVdsGroupCommand
..
Patch Set 3: Abandoned
There is no reason helping those who refuse to be helped
--
To view, visit
Saggi Mizrahi has abandoned this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 5: Abandoned
There is no reason helping those who refuse to be helped
--
To view, visit http://gerrit.ovirt.org/2271
To
Michael Kublin has posted comments on this change.
Change subject: core: Fix DAO use with templates multiple storages
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
Please see my comments
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix DAO use with templates multiple storages
..
Patch Set 1: (4 inline comments)
Hi Michael, thanks for the comments
The problem is that the test of the
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix DAO use with templates multiple storages
..
Patch Set 1: (1 inline comment)
File
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix DAO use with templates multiple storages
..
Patch Set 2:
Removed check if array is empty as Michael commented.
and responded to comments from last
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: move/copy disks dialog - non-active sd
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3475
To unsubscribe, visit
96 matches
Mail list logo
