Allon Mureinik has posted comments on this change.
Change subject: core: QueriesCommandBase - extracted getDbFacade()
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3970
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: QueriesCommandBase - extracted getDbFacade()
..
Patch Set 3: Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetTagUserMapByTagNameQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup SearchQuey
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending submit if
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetDedicatedVmQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAvailableClusterVersionsQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup getVdsInterfacesByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsGroupByNameQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Clean GetTemplateInterfacesByTemplateIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetoVirtISOsQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetUserVmsByUserIdAndGroupsQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetTimeLeasedUsersByVmPoolIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsFreeBondsByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsFreeBondsByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsByNameQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllChildVlanInterfacesQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllNetworksByClusterIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllNetworksQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetQuotaStorageByQuotaIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVmPoolByIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup CheckDBConnectionQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAdGroupByIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllAuditLogsByVMNameQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllAuditLogsByVMTempalteNameQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllDisksByVmIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetAllRelevantQuotasForStorageQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup GetAllRelevantQuotasForVdsGroupQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup GetAllVmPoolsAttachesToUserQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup GetAllVmSnapshotsByDriveQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup GetAllVmSnapshotsByVmIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: GetDataCentersWithPermittedActionOnClustersQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetPermissionsByAdElementIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: GetNextAvailableDiskAliasNameByVMIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: GetPermissionsToConsumeQuotaByQuotaIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup GetQuotasByAdElementIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetQuotaVdsGroupByQuotaIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetRoleActionGroupsByRoleIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetTemplatesRelatedToQuotaIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsCertificateSubjectByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Yair Zaslavsky has posted comments on this change.
Change subject: core: QueriesCommandBase - extracted getDbFacade()
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3970
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: QueriesCommandBase - extracted getDbFacade()
..
core: QueriesCommandBase - extracted getDbFacade()
Added a (protected) method to retrun the
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVmByVmIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsGroupByIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVmConfigurationBySnapshotQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetTagUserMapByTagNameQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3971
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetTagUserMapByTagNameQuery
..
core: Cleanup GetTagUserMapByTagNameQuery
Used new getDbFacade() method, replaced * import with FQCN.
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVmsByImageGuidQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup SearchQuey
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3972
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Clean GetVmTemplatesWithPermittedActionQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVmTemplatesByImageGuidQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetDedicatedVmQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3973
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetDedicatedVmQuery
..
core: Cleanup GetDedicatedVmQuery
Used new getDbFacade() method, replaced * import with FQCN.
Change-Id:
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetStoragePoolByIdQuery and its test
..
Patch Set 3: Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAvailableClusterVersionsQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3974
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAvailableClusterVersionsQuery
..
core: Cleanup GetAvailableClusterVersionsQuery
Used new getDbFacade() method, replaced FQCNs with
Allon Mureinik has posted comments on this change.
Change subject: core: clean GetStorageDomainsByStoragePoolIdQuery
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup getVdsInterfacesByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3975
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetVdsGroupByNameQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3976
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Clean GetTemplateInterfacesByTemplateIdQuery
..
core: Clean GetTemplateInterfacesByTemplateIdQuery
Used new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetUserVmsByUserIdAndGroupsQuery
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3979
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetImageByImageIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3980
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetImageByImageIdQuery
..
core: Cleanup GetImageByImageIdQuery
Used the new getDbFacade() method, replaced * imports with FQCNs.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetTimeLeasedUsersByVmPoolIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3981
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetVdsFreeBondsByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3982
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetVdsFreeBondsByVdsIdQuery
..
--
To view, visit http://gerrit.ovirt.org/3983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetVdsFreeBondsByVdsIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3983
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetVdsFreeBondsByVdsIdQuery
..
core: Cleanup GetVdsFreeBondsByVdsIdQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetVdsByNameQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3984
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAllChildVlanInterfacesQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3985
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAllNetworksByClusterIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3986
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAllNetworksByClusterIdQuery
..
core: Cleanup GetAllNetworksByClusterIdQuery
Used the new getDbFacade() method, and cleaned up the
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAllNetworksQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3987
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAllNetworksQuery
..
core: Cleanup GetAllNetworksQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetQuotaStorageByQuotaIdQuery
..
core: Cleanup GetQuotaStorageByQuotaIdQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetVmPoolByIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3989
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup CheckDBConnectionQuery
..
core: Cleanup CheckDBConnectionQuery
Used the new getDbFacade() method and added a missing @Override
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAdGroupByIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3991
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAdGroupByIdQuery
..
core: Cleanup GetAdGroupByIdQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAllAuditLogsByVMNameQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3992
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAllAuditLogsByVMNameQuery
..
core: Cleanup GetAllAuditLogsByVMNameQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAllAuditLogsByVMTempalteNameQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3993
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAllAuditLogsByVMTempalteNameQuery
..
core: Cleanup GetAllAuditLogsByVMTempalteNameQuery
Used the new getDbFacade() method.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup GetAllDisksByVmIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3994
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAllDisksByVmIdQuery
..
core: Cleanup GetAllDisksByVmIdQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup GetAllRelevantQuotasForStorageQuery
..
core: Cleanup GetAllRelevantQuotasForStorageQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup GetAllRelevantQuotasForVdsGroupQuery
..
core: cleanup GetAllRelevantQuotasForVdsGroupQuery
Used the new getDbFacade() method.
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup GetAllRolesQuery
..
core: cleanup GetAllRolesQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup GetAllVmPoolsAttachesToUserQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3998
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup GetAllVmPoolsAttachesToUserQuery
..
core: cleanup GetAllVmPoolsAttachesToUserQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup GetAllVmSnapshotsByDriveQuery
..
core: cleanup GetAllVmSnapshotsByDriveQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup GetAllVmSnapshotsByDriveQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3999
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup GetAllVmSnapshotsByVmIdQuery
..
core: cleanup GetAllVmSnapshotsByVmIdQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup GetAllVmSnapshotsByVmIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4000
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup GetClustersWithPermittedActionQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4001
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup GetClustersWithPermittedActionQuery
..
core: cleanup GetClustersWithPermittedActionQuery
Used the new getDbFacade() method.
Change-Id:
Yair Zaslavsky has posted comments on this change.
Change subject: core: GetDataCentersWithPermittedActionOnClustersQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4002
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: GetDataCentersWithPermittedActionOnClustersQuery
..
core: GetDataCentersWithPermittedActionOnClustersQuery
Clenaup - used the new getDbFacade()
Yair Zaslavsky has posted comments on this change.
Change subject: core: GetNextAvailableDiskAliasNameByVMIdQuery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4004
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: GetNextAvailableDiskAliasNameByVMIdQuery
..
core: GetNextAvailableDiskAliasNameByVMIdQuery
Cleanup - used the new getDbFacade() method.
1 - 100 of 274 matches
Mail list logo