Livnat Peer has posted comments on this change.
Change subject: core: Add console reconnect permission
..
Patch Set 2:
Hi Juan,
The changes Maor did enable adding a custom permissions validations.
For using it you need to
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Use private access with user authorization method
..
core:Use private access with user authorization method
Change accessibility level of
ol...@redhat.com has uploaded a new change for review.
Change subject: restapi: Add Setup-Netowrk params to RSDL
..
restapi: Add Setup-Netowrk params to RSDL
Change-Id: Ia27f4add387e8660939c958495459404f98f1124
---
M
Maor Lipchuk has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 5:
I think the app errors messages should be also added in
Yair Zaslavsky has posted comments on this change.
Change subject: core: Prestarted Vm Validation And Periodic Job
..
Patch Set 2: (2 inline comments)
File
Michael Kublin has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 5:
Maor, it was verified by Daniel
--
To view, visit
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding helper methods to ImagesHandler
..
Patch Set 2: (1 inline comment)
File
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing RemoveVmTemplateCommand in order to work with
multiple storage domains
..
core : Fixing RemoveVmTemplateCommand in order to work with multiple
Michael Kublin has posted comments on this change.
Change subject: DO NOT SUBMIT core: Fixing MoveOrCopyImageGroup to support new
param fields
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Omer Frenkel has posted comments on this change.
Change subject: core: Change GetAllVmSnapshotsByDriveQuery
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2639
To unsubscribe, visit
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Change GetAllVmSnapshotsByDriveQuery
..
core: Change GetAllVmSnapshotsByDriveQuery
Change query to use snapshots to query for preview/active
Michael Kublin has posted comments on this change.
Change subject: DO NOT SUBMIT common: Fixing parameter name to CTOR
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2653
To unsubscribe,
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback
using command)
..
Patch Set 7: (8 inline comments)
Please run formatter on new code.
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT common: Fixing MoveOrCopyImageGroup params
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
Generally +2, but please see comment
Michael Kublin has posted comments on this change.
Change subject: DO NOT SUBMIT core: Fixing MoveOrCopyImageGroup to support new
param fields
..
Patch Set 2: Looks good to me, approved
My bad previous comment is irrelevant
Michael Kublin has abandoned this change.
Change subject: core : Unit test for MoveOrCopyDiskCommand
..
Patch Set 4: Abandoned
no need anymore, part of the new patch
--
To view, visit http://gerrit.ovirt.org/2591
To
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT common: Fixing MoveOrCopyImageGroup params
..
Patch Set 2: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 5:
Maor correct, Daniel is wrong
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: engine-core: minor ImagesHandler cleanup
..
Patch Set 3: Looks good to me, approved
That a good idea for now to gather such null checking and
later we need to
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Add RSDL Ignore Annotation
..
restapi: Add RSDL Ignore Annotation
The annotation will tell the RSDL engine to ignore the
annotated method.
Michael Pasternak has posted comments on this change.
Change subject: restapi: Add Setup-Netowrk params to RSDL
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2690
To
Michael Pasternak has posted comments on this change.
Change subject: restapi: Add Setup-Netowrk params to RSDL
..
Patch Set 2:
Please rebase the change locally and upload again for review.
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: core:Use private access with user authorization method
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2689
To
Maor Lipchuk has posted comments on this change.
Change subject: core:Use private access with user authorization method
..
Patch Set 2: Verified; Looks good to me, approved
Already acked by Livnat
--
To view, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Use private access with user authorization method
..
core:Use private access with user authorization method
Change accessibility level of
Omer Frenkel has posted comments on this change.
Change subject: core: Remove unnecessary methods in ImagesHandler
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2641
To unsubscribe, visit
Michael Pasternak has posted comments on this change.
Change subject: restapi: Add Setup-Netowrk params to RSDL
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2690
To
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Add Setup-Netowrk params to RSDL
..
restapi: Add Setup-Netowrk params to RSDL
Change-Id: Ia27f4add387e8660939c958495459404f98f1124
---
M
Ofer Schreiber has posted comments on this change.
Change subject: packaging: ovirt-engine-3.1.0
..
Patch Set 4: Verified; Looks good to me, approved
Already acked by Doron
Verified after RPM compilation
--
To view, visit
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-3.1.0
..
packaging: ovirt-engine-3.1.0
Updated ovirt-engine version to 3.1.0
Change-Id:
Omer Frenkel has posted comments on this change.
Change subject: core: Delete image_vm_map
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2691
To unsubscribe, visit
Danny Rankevich has posted comments on this change.
Change subject: core: fix identifying network management
..
Patch Set 1: Verified; Looks good to me, approved
Verified on webadmin UI
--
To view, visit
Danny Rankevich has posted comments on this change.
Change subject: core: fix identifying network management
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2625
To unsubscribe,
Danny Rankevich has submitted this change and it was merged.
Change subject: core: fix identifying network management
..
core: fix identifying network management
The management network name that is used to identify and mark a
ovirt_engine_unit_tests - Build # 320 - Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/320/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Roy Golan has posted comments on this change.
Change subject: core: add optional field to cluster networks
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/2537
To unsubscribe, visit
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: define maven-jaxb22-plugin.version explicitly
..
restapi: define maven-jaxb22-plugin.version explicitly
since
Eli Mesika has uploaded a new change for review.
Change subject: core: removing async tasks and compensation data on upgrade
..
core: removing async tasks and compensation data on upgrade
Since async tasks and compensation data
Oved Ourfali has uploaded a new change for review.
Change subject: core: InitVdsOnUp - init virt-related resources only on virt
clusters
..
core: InitVdsOnUp - init virt-related resources only on virt clusters
This commit
Maor Lipchuk has posted comments on this change.
Change subject: core: Add disk name and description
..
Patch Set 6:
Change disk_name to disk_alias, also upgraded script to 630
--
To view, visit http://gerrit.ovirt.org/2598
Maor Lipchuk has posted comments on this change.
Change subject: core: Add basic search for disks
..
Patch Set 7:
Main chages from last patch were in DiskImageConditionFieldAutoCompleter.
Based on
Michael Pasternak has posted comments on this change.
Change subject: restapi: remove redundant url param
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2697
To unsubscribe,
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: remove redundant url param
..
restapi: remove redundant url param
Update-Vm does not require a url parameter; remove this
statement from
Doron Fediuck has posted comments on this change.
Change subject: restapi: define maven-jaxb22-plugin.version explicitly
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2695
To unsubscribe,
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: define maven-jaxb22-plugin.version explicitly
..
restapi: define maven-jaxb22-plugin.version explicitly
since
Michael Pasternak has posted comments on this change.
Change subject: restapi: define maven-jaxb22-plugin.version explicitly
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2695
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding snapshotExists to SnapshotValidator
..
Patch Set 5: (1 inline comment)
Please add unit tests
Roy Golan has uploaded a new change for review.
Change subject: core: mock config for SetupNetworksHelperTest
..
core: mock config for SetupNetworksHelperTest
mock the NetworkUtils usage of config to fetch the management
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing new query type
..
Patch Set 10: (1 inline comment)
File
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing new method in DiskImageDAO
..
Patch Set 6:
This method should support filtering, so that the query can be safely called
from
Roy Golan has posted comments on this change.
Change subject: core: refactor CollectVdsNetworkDataVDSCommand
..
Patch Set 12: Verified; Looks good to me, approved
rebase. already acked
--
To view, visit
Roy Golan has submitted this change and it was merged.
Change subject: core: refactor CollectVdsNetworkDataVDSCommand
..
core: refactor CollectVdsNetworkDataVDSCommand
a small refactor as a first step to break a long method to
Roy Golan has abandoned this change.
Change subject: core: mock config for SetupNetworksHelperTest
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/2700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has uploaded a new change for review.
Change subject: core: mock config for SetupNetworksHelperTest
..
core: mock config for SetupNetworksHelperTest
mock the NetworkUtils usage of config to fetch the management
Maor Lipchuk has posted comments on this change.
Change subject: core: mock config for SetupNetworksHelperTest
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2701
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: core: mock config for SetupNetworksHelperTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2701
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: core: mock config for SetupNetworksHelperTest
..
Patch Set 2: Verified; Looks good to me, approved
already acked
--
To view, visit http://gerrit.ovirt.org/2701
To
Roy Golan has submitted this change and it was merged.
Change subject: core: mock config for SetupNetworksHelperTest
..
core: mock config for SetupNetworksHelperTest
mock the NetworkUtils usage of config to fetch the
ovirt_engine_unit_tests - Build # 321 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/321/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding logic of query
..
Patch Set 11: (5 inline comments)
Please run formatter on code
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding logic of query
..
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
Roy Golan has posted comments on this change.
Change subject: ovirt-engine: Use config value ManagementNetwork
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1412
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Add basic search for disks
..
Patch Set 8:
Changes from last patch:
1. Adding status to search
2. Fix typos in comments
3. Changed test for disk auto
Maor Lipchuk has posted comments on this change.
Change subject: core: Add basic search for disks
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/2534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: core: Add disk name and description
..
Patch Set 7: Verified
Only rebase
--
To view, visit http://gerrit.ovirt.org/2598
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: core: minor javadoc update
..
core: minor javadoc update
Change-Id: Id9df8289efa7da53c494f8ea743e5e67ca1f7d72
---
M
Doron Fediuck has posted comments on this change.
Change subject: core: add canDoActions on several Vm flows for VmNetworks
..
Patch Set 12:
I do not understand why didn't you use just the keys set.
--
To view, visit
Daniel Erez has posted comments on this change.
Change subject: core: Add basic search for disks
..
Patch Set 8: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2534
To
Mike Kolesnik has posted comments on this change.
Change subject: core: Refactor preview restore snapshot commands
..
Patch Set 4: Verified; Looks good to me, approved
Just rebased, ack (+2) by ofrenkel
--
To view, visit
Omer Frenkel has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 6: (4 inline comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: Adding quota id when updating image
..
Patch Set 2: Verified; Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/2614
Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback
using command)
..
Patch Set 7: (1 inline comment)
Michael Kublin has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 6: (4 inline comments)
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: refactor documentation for collection based arguments
..
codegen: refactor documentation for collection based arguments
Change-Id:
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: rebase to latets api
..
sdk: rebase to latets api
- added arguments for UPDATE methods
- implemented ars doc support for collection based arguments
-
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: support actions on collection
..
codegen: support actions on collection
Change-Id: Id3720642cb3267d1bdd1e3eb66d3aeff2c5e0b10
---
M
Michael Pasternak has posted comments on this change.
Change subject: codegen: refactor documentation for collection based arguments
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: refactor documentation for collection based arguments
..
codegen: refactor documentation for collection based arguments
Change-Id:
Michael Pasternak has posted comments on this change.
Change subject: codegen: support actions on collection
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2704
To unsubscribe,
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: support actions on collection
..
codegen: support actions on collection
Change-Id: Id3720642cb3267d1bdd1e3eb66d3aeff2c5e0b10
---
M
Michael Pasternak has posted comments on this change.
Change subject: sdk: rebase to latets api
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2705
To unsubscribe, visit
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: rebase to latets api
..
sdk: rebase to latets api
- added arguments for UPDATE methods
- implemented ars doc support for collection based
Michael Pasternak has posted comments on this change.
Change subject: REST: add vm_network and bridged propertes
..
Patch Set 13: (1 inline comment)
File
Michael Pasternak has posted comments on this change.
Change subject: REST: translate VdcFault in case the error messages are empty
..
Patch Set 2: (1 inline comment)
File
ovirt_engine_unit_tests - Build # 322 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/322/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Yaniv Dary has uploaded a new change for review.
Change subject: etl: parameterized error events resend time.
..
etl: parameterized error events resend time.
Change-Id: I31a537144c974b7b29cf10c8ea050024e5410d45
---
M
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Show ISOs for oVirt node in more readable manner.
..
webadmin: Show ISOs for oVirt node in more readable manner.
Change-Id:
Roy Golan has posted comments on this change.
Change subject: core: add canDoActions on several Vm flows for VmNetworks
..
Patch Set 11: (1 inline comment)
File
Omer Frenkel has posted comments on this change.
Change subject: core: Add basic search for disks
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2534
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding logic of query
..
Patch Set 11: (5 inline comments)
File
Omer Frenkel has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 6: (1 inline comment)
Michael Kublin has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 6: (1 inline comment)
Yair Zaslavsky has posted comments on this change.
Change subject: DO NOT SUBMIT core: Tests for new query
..
Patch Set 9:
Took me about 8 resends to answer Allon, sorry for that -
I will perform the squash.
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Add basic search for disks
..
Patch Set 9: Verified; Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/2534
To
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add basic search for disks
..
core: Add basic search for disks
Adding support for basic search to diskImage.
For now only adding API to support
Maor Lipchuk has posted comments on this change.
Change subject: core: Add disk name and description
..
Patch Set 8: Verified; Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/2598
To
Omer Frenkel has posted comments on this change.
Change subject: core : Fixing RemoveVmTemplateCommand in order to work with
multiple storage domains
..
Patch Set 1: Looks good to me, approved
--
To view, visit
Michael Pasternak has posted comments on this change.
Change subject: restapi: Add console reconnect
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/819
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
..
Patch Set 7: Looks good to me, approved
--
To view, visit
ovirt_engine_gwt_admin - Build # 101 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/101/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
1 - 100 of 129 matches
Mail list logo
