On Sat 2016-10-29 10:49:23 -0400, Patrick Brunschwig wrote:
> On 29.10.16 16:26, Daniel Kahn Gillmor wrote:
>> On Sat 2016-10-29 05:09:12 -0400, Patrick Brunschwig wrote:
>>> The problem is that there is no output on stderr, even though
>>> --status-fd 2 is specified. I added --no-verbose because "verbose"
>>> options in gpg.conf make gpg ignore --status-fd 2. Apparently there is
>>> something more in your gpg.conf file with the same result.
>> 
>> I think that the command that we're talking about is:
>> 
>>    /usr/bin/gpg --charset utf-8 --display-charset utf-8 --use-agent --batch 
>> --no-tty --status-fd 2 --no-verbose --list-packets
>> 
>> Is that right?
>
> Right, this can't be the problem.
>
> The difference between your log file:
>
> 2016-10-28 14:35:35.523 [DEBUG] execution.jsm:
> EnigmailExecution.fixExitCode: agentType: gpg exitCode: 0 statusFlags
> undefined
> 2016-10-28 14:35:35.523 [CONSOLE]
> 2016-10-28 14:35:41.812 [DEBUG] enigmailMessengerOverlay.js:
> updateOptionsDisplay:
>
> and mine:
>
> 2016-10-29 16:44:30.301 [DEBUG] execution.jsm:
> EnigmailExecution.fixExitCode: agentType: gpg exitCode: 0 statusFlags
> undefined
> 2016-10-29 16:44:30.301 [CONSOLE]
> 2016-10-29 16:44:30.302 execution.jsm: EnigmailExecution.execCmd:
> subprocess = '/usr/local/bin/gpg2'
> 2016-10-29 16:44:30.302 [CONSOLE] enigmail> /usr/local/bin/gpg2
> --charset utf-8 --display-charset utf-8 --use-agent --batch --no-tty
> --status-fd 2 --import --trustdb
> /Users/pbr/Library/Caches/TemporaryItems/enigmail_import/trustdb
> --no-default-keyring --keyring
> /Users/pbr/Library/Caches/TemporaryItems/enigmail_import/keyring
>
> Do you see any exception in the Thunderbird console?

Ah, good call, sorry i didn't look there first.  When i open the key
manager dialog box, i get a small warning that i think is irrelevant to
this concern [0].

Then when i try to do the import, i see the following error:

    Timestamp: 10/30/2016 01:44:08 PM
    Error: NS_ERROR_FILE_ALREADY_EXISTS: Component returned failure code: 
0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS) [nsIFile.create]
    Source File: resource://enigmail/files.jsm
    Line: 263

That's createTempSubDir, presumably with dirName="enigmail_import".
Sure enough, i have $TMPDIR/enigmail_import already (probably leftovers
From a previous attempt that failed due to the arglist).

If i "mv $TMPDIR/enigmail_import{,.bak}" then try the import again, it
succeeds as expected. [1]

So: is it possible to use a dynamically-named temporary directory?
using $TMPDIR/enigmail_import seems prone to failure -- and for people
sharing a mode 1777 /tmp as $TMPDIR, it looks like one person could
block all other people on a given machine from doing imports.  (the same
is likely also true for "$TMPDIR/enig-imp" and "$TMPDIR/enig-exp").  On
a POSIX platform, i'd recommend mkstemp() -- but i don't know what the
equivalent is for enigmail's platform.

           --dkg

[0] The warning is:

    Timestamp: 10/30/2016 01:43:25 PM
    Warning: XUL box for a element contained an inline #text child, forcing all 
its children to be wrapped in a block.
    Source File: chrome://enigmail/content/enigmailKeyManager.xul
    Line: 0

I suspect this can be fixed with:

--- a/ui/content/enigmailKeyManager.xul
+++ b/ui/content/enigmailKeyManager.xul
@@ -454,8 +454,7 @@
     <label id="statusText" value=" "/>
     <progressmeter id="progressBar" mode="undetermined" value="0" 
collapsed="true"/>
     <description id="cancelBox" collapsed="true">
-      <a class="enigmailLink" href=""
-         id="cancelButton" 
onclick="enigSendKeyCancel()">&enigmail.keyMan.stopTransfer.label;</a>
+      <button id="cancelButton" label="&enigmail.keyMan.stopTransfer.label;" 
oncommand="enigSendKeyCancel()"/> 
     </description>
   </hbox>
 </window>



[1] As another digression, after success, i get the following warning on
the console:

    Timestamp: 10/30/2016 01:53:20 PM
    Warning: Expected ':' but found ';'.  Declaration dropped.
    Source File: chrome://enigmail/content/enigmailKeyImportInfo.xul
    Line: 0, Column: 5
    Source Code:
    plain;white-space: pre
    -----^

I think this can be fixed with the following (based on similar elements
in ui/content/keyDetailsDlg.xul):

--- a/ui/content/enigmailKeyImportInfo.xul
+++ b/ui/content/enigmailKeyImportInfo.xul
@@ -31,7 +31,7 @@
 
   <vbox align="center" flex="1" style="overflow:auto" id="outerbox">
     <hbox align="center" flex="1">
-      <description flex="1" id="keyInfo" style="plain;white-space: pre"/>
+      <description flex="1" id="keyInfo" class="plain" style="white-space: 
pre"/>
     </hbox>
   </vbox>

Attachment: signature.asc
Description: PGP signature

_______________________________________________
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net

Reply via email to