Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-12 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 09.01.14 21:38, Daniel Kahn Gillmor wrote: > This addresses http://sourceforge.net/p/enigmail/bugs/239/ --- > ui/content/enigmailCommon.js | 5 - 1 file changed, 4 > insertions(+), 1 deletion(-) > patch is committed. - -Patrick -BEGIN P

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-11 Thread Doug Barton
On 01/11/2014 02:31 AM, Patrick Brunschwig wrote: I will certainly include Daniel's patch, to ensure that those places we know are fixed. :) ___ enigmail-users mailing list enigmail-users@enigmail.net https://admin.hostpoint.ch/mailman/listinfo/enigm

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-11 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 10.01.14 09:55, Andy Ruddock wrote: > Doug Barton wrote: >> I would like to see that option since I do indeed have >> 'fingerprint' in my gpg.conf. :) One note though, you're using >> Yoda-style comparison, which would more normally be written: i

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-11 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11.01.14 04:52, Doug Barton wrote: > On 01/10/2014 01:56 AM, Patrick Brunschwig wrote: | On 09.01.14 > 21:38, Daniel Kahn Gillmor wrote: |> This addresses > http://sourceforge.net/p/enigmail/bugs/239/ --- |> > ui/content/enigmailCommon.js | 5

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Doug Barton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/10/2014 01:56 AM, Patrick Brunschwig wrote: | On 09.01.14 21:38, Daniel Kahn Gillmor wrote: |> This addresses http://sourceforge.net/p/enigmail/bugs/239/ --- |> ui/content/enigmailCommon.js | 5 - 1 file changed, 4 |> insertions(+), 1 delet

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Doug Barton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/10/2014 12:55 AM, Andy Ruddock wrote: | Doug Barton wrote: |>> I would like to see that option since I do indeed have |>> 'fingerprint' in my gpg.conf.:) One note though, you're using |>> Yoda-style comparison, which would more normally be w

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Robert J. Hansen
On 1/10/2014 4:36 PM, Daniel Kahn Gillmor wrote: > completely agreed. It had to happen sooner or later, I guess. Mark this day on the calendar. :) > That is: if we're going to be referring to keys by things that are > spoofable and relying on proper certificate validation to weed out > bad key

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Daniel Kahn Gillmor
On 01/10/2014 11:45 AM, Robert J. Hansen wrote: > Nothing can replace proper certificate validation. completely agreed. > If I have a > certificate 0xDEADBEEF that I have validated and signed, and someone > else maliciously inserts a certificate 0xDEADBEEF (a different cert, but > one that has

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Robert J. Hansen
I think including "fingerprint" in gpg.conf is important because if people are trying to refer to specific keys, i don't believe that either the short or long keyid is a reasonable identifier [0]. I (mostly) disagree. Nothing can replace proper certificate validation. If I have a certificate

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Daniel Kahn Gillmor
On 01/10/2014 04:56 AM, Patrick Brunschwig wrote: > I'm sure that adding "fingerprint" or "with-fingerprint" to gpg.conf > will cause more issues in Enigmail than just the one found in Bug 239, > including situations where Enigmail will fail because it requires that > the option is not present. I s

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 09.01.14 21:38, Daniel Kahn Gillmor wrote: > This addresses http://sourceforge.net/p/enigmail/bugs/239/ --- > ui/content/enigmailCommon.js | 5 - 1 file changed, 4 > insertions(+), 1 deletion(-) > > diff --git a/ui/content/enigmailCommon.js >

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-10 Thread Andy Ruddock
Doug Barton wrote: > I would like to see that option since I do indeed have 'fingerprint' in > my gpg.conf. :) One note though, you're using Yoda-style comparison, > which would more normally be written: if (variable == value) Depending upon compiler flags, if an "=" is missed out, if (variable

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-09 Thread Doug Barton
I would like to see that option since I do indeed have 'fingerprint' in my gpg.conf. :) One note though, you're using Yoda-style comparison, which would more normally be written: if (variable == value) hth, Doug On 01/09/2014 12:38 PM, Daniel Kahn Gillmor wrote: This addresses http://sourc

Re: [Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-09 Thread Ludwig Hügelschäfer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 09.01.14 21:38, Daniel Kahn Gillmor wrote: > This addresses http://sourceforge.net/p/enigmail/bugs/239/ > > (...) +1 Very similar to what I have tested successfully here :-) Ludwig -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (Darwin)

[Enigmail] [PATCH] select only the first fingerprint for any key, instead of the last

2014-01-09 Thread Daniel Kahn Gillmor
This addresses http://sourceforge.net/p/enigmail/bugs/239/ --- ui/content/enigmailCommon.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/content/enigmailCommon.js b/ui/content/enigmailCommon.js index b10375c..e19d9b0 100644 --- a/ui/content/enigmailCommon.js +++ b/ui/