[Enigmail] [PATCH 2/2] .xpi generation should fail if components are missing

2013-11-11 Thread Daniel Kahn Gillmor
Without this change, zip would happily carry on even if some elements are missing due to other undetected failures in the build process. It's better to catch errors in the .xpi generation at build time, rather than at install or runtime. --- genxpi | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Enigmail] enigmail picks invalid key ID

2013-11-11 Thread Ludwig Hügelschäfer
Hi Kai, On 11.11.13 20:03, Kai Poeritz wrote: Why does Enigmail pick this old 038D1C4D ID? How can I make it use the right ID? While admitting that the observed behaviour is not good, please keep to the recommendation: Set the key-Id to be used explicitly in account settings, OpenPGP section

Re: [Enigmail] enigmail picks invalid key ID

2013-11-11 Thread David Benfell
On Mon, 2013-11-11 at 14:32 -0500, Daniel Kahn Gillmor wrote: One way to work around this is to remove the old key from your gpg keyring entirely. There is also a configuration option in gpg.conf to select a default key. I believe the parameters that should be set are: default-key

[Enigmail] [PATCH] avoid warning: variable 'rv' set but not used [-Wunused-but-set-variable]

2013-11-11 Thread Daniel Kahn Gillmor
This patch allows the build to proceed cleanly when using -Wunused-but-set-variable and without FORCE_PR_LOG --- src/nsEnigMsgCompose.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nsEnigMsgCompose.cpp b/src/nsEnigMsgCompose.cpp index 2bc3f7a..91ca07e 100644 ---

[Enigmail] C99 adoption

2013-11-11 Thread Robert J. Hansen
c-comments starting with // are standard sice C99, are there still compilers out there complaining about this? They're very common. 14 years after C99, GCC still doesn't fully implement the standard, nor does the Intel C++ compiler or Clang. The only fully-conformant C99 implementation I

Re: [Enigmail] C99 adoption

2013-11-11 Thread Daniel Kahn Gillmor
On 11/11/2013 05:43 PM, Michael Norrish wrote: As for //, compilers have had this forever given that it's been in C++ forever. yes, of course all modern compilers have this option. however, there's no reason for gratuitous incompatibility against older compilers or for people who for whatever

Re: [Enigmail] C99 adoption

2013-11-11 Thread Michael Norrish
On 12/11/13 11:16, Robert J. Hansen wrote: On 11/11/2013 5:43 PM, Michael Norrish wrote: http://gcc.gnu.org/c99status.html suggests that gcc has pretty close to all of C99 implemented. (a) the world is larger than just GNU, and (b) I stand by my statements. C99's adoption has been quite

Re: [Enigmail] please tag 1.6 release in upstream git

2013-11-11 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11.11.13 20:43, Daniel Kahn Gillmor wrote: hi there enigmail folks! It looks to me like the released enigmail-1.6.tar.gz is drawn from commit id a16b43c68c9a829034f44082c392e5f9fb42e864, but that commit is not explicitly tagged (or maybe

Re: [Enigmail] [PATCH] avoid warning: variable 'rv' set but not used [-Wunused-but-set-variable]

2013-11-11 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11.11.13 21:11, Daniel Kahn Gillmor wrote: This patch allows the build to proceed cleanly when using -Wunused-but-set-variable and without FORCE_PR_LOG --- src/nsEnigMsgCompose.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)