[Enigmail] [PATCH] avoid warning: variable 'rv' set but not used [-Wunused-but-set-variable]

2013-11-11 Thread Daniel Kahn Gillmor 
This patch allows the build to proceed cleanly when using
-Wunused-but-set-variable and without FORCE_PR_LOG
---
 src/nsEnigMsgCompose.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/nsEnigMsgCompose.cpp b/src/nsEnigMsgCompose.cpp
index 2bc3f7a..91ca07e 100644
--- a/src/nsEnigMsgCompose.cpp
+++ b/src/nsEnigMsgCompose.cpp
@@ -77,8 +77,8 @@ nsEnigMsgCompose::nsEnigMsgCompose()
 
 nsEnigMsgCompose::~nsEnigMsgCompose()
 {
-  nsresult rv;
 #ifdef FORCE_PR_LOG
+  nsresult rv;
   nsCOMPtrnsIThread myThread;
   rv = ENIG_GET_THREAD(myThread);
   DEBUG_LOG((nsEnigMsgCompose::  DTOR(%p): myThread=%p\n,
-- 
1.8.4.2


___
enigmail-users mailing list
enigmail-users@enigmail.net
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net

Re: [Enigmail] [PATCH] avoid warning: variable 'rv' set but not used [-Wunused-but-set-variable]

2013-11-11 Thread Patrick Brunschwig 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 11.11.13 21:11, Daniel Kahn Gillmor wrote:
 This patch allows the build to proceed cleanly when using 
 -Wunused-but-set-variable and without FORCE_PR_LOG --- 
 src/nsEnigMsgCompose.cpp | 2 +- 1 file changed, 1 insertion(+), 1
 deletion(-)
 
 diff --git a/src/nsEnigMsgCompose.cpp b/src/nsEnigMsgCompose.cpp 
 index 2bc3f7a..91ca07e 100644 --- a/src/nsEnigMsgCompose.cpp +++
 b/src/nsEnigMsgCompose.cpp @@ -77,8 +77,8 @@
 nsEnigMsgCompose::nsEnigMsgCompose()
 
 nsEnigMsgCompose::~nsEnigMsgCompose() { -  nsresult rv; #ifdef
 FORCE_PR_LOG +  nsresult rv; nsCOMPtrnsIThread myThread; rv =
 ENIG_GET_THREAD(myThread); DEBUG_LOG((nsEnigMsgCompose:: 
 DTOR(%p): myThread=%p\n,
 

Thanks, but I won't fix anything on nsEnigMsgCompose.cpp anymore. This
code only for TB 17 and will be deleted as soon as TB 17 is end of life.

- -Patrick
-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEVAwUBUoHZ9Mk25cDiHiw+AQgvBAgAxG32X6+4HiEel12AoLhTHe39VIUI2bNC
vMX8FO8HcTWu1BOHYUzObjj0kOzyb0F68ImVcuyG46Pr+YnNpHPTDOJzKo4pr6/H
+QsWaW/J/29HtXsCdlmCNDkZeDvrv3I9ECc9T0OQykYQGzTApK4Egq8acS5lwTRf
WwWh/8EX8t14iDmIFc/cs5xh4/9H84idvLUCpTm+QE3NBVXkvtuFGXwXqLr1HDAd
UyRQYlpDhj1EUUx9DPbGhBe4ib0NDBr6uo/g5QEfUDYou9glwSSF4rda62+4EMZz
Hq40WJAkge5hvt7uEW2ShUzUI5qxfWF5JjeqtwfsnjVkj7tj/677VQ==
=WBtW
-END PGP SIGNATURE-

___
enigmail-users mailing list
enigmail-users@enigmail.net
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net