Re: [Enigmail] What is the --log-file gpg option for in Enigmail 2.0.7?

2018-06-14 Thread Patrick Brunschwig
On 14.06.18 09:50, Werner Koch wrote:
[...]
>> I therefore recommend you change --log-file XXX to --log-file /dev/null.
>> This should be OK for Enigmail and equally prevent from such attacks.
> 
> Another option for non-fixed gpg versions is to use --no-verbose.

That's implemented in Enigmail 2.0.7 - all calls to gpg contain now
--no-verbose.

-Patrick



signature.asc
Description: OpenPGP digital signature
___
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net


Re: [Enigmail] What is the --log-file gpg option for in Enigmail 2.0.7?

2018-06-14 Thread Werner Koch
On Thu, 14 Jun 2018 08:11, patr...@enigmail.net said:

> However, the problem behind is that without --log-file, you get a
> mixture of human-readable and machine-parseable output on stderr. You

Only if you use the same file descriptor for --status-fd as you do for
--logger-fd or use a filename reflecting the same file descriptor in
--log-file.  Note that --log-file defaults to stderr (2) but --status-fd
has no default.  Mozilla seems to allow only for the 3 standard file
descriptors and that is the main cause of the bug.

> I therefore recommend you change --log-file XXX to --log-file /dev/null.
> This should be OK for Enigmail and equally prevent from such attacks.

Another option for non-fixed gpg versions is to use --no-verbose.


Shalom-Salam,

   Werner

-- 
#  Please read:  Daniel Ellsberg - The Doomsday Machine  #
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.


pgpTnIU3SQiyK.pgp
Description: PGP signature
___
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net


Re: [Enigmail] What is the --log-file gpg option for in Enigmail 2.0.7?

2018-06-13 Thread Patrick Brunschwig
On 14.06.18 00:39, Micah Lee wrote:
[...]
> So my question is, is it safe for split GPG to simply ignore the
> --log-file argument altogether? Or does Enigmail try to do something
> with that log file later on, and things will break if it's not there?


From what we know *currently* it seems OK to drop the --log-file argument.

However, the problem behind is that without --log-file, you get a
mixture of human-readable and machine-parseable output on stderr. You
cannot be sure that there is no other way to trick gpg into printing
human-readable output that looks like machine-parseable, and thus make
Enigmail think the message is signed/encrypted whatever.

I therefore recommend you change --log-file XXX to --log-file /dev/null.
This should be OK for Enigmail and equally prevent from such attacks.

-Patrick




signature.asc
Description: OpenPGP digital signature
___
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net


[Enigmail] What is the --log-file gpg option for in Enigmail 2.0.7?

2018-06-13 Thread Micah Lee
Qubes OS has a feature called Split GPG where you can keep your email
client in one VM and your gpg keyring in another VM (without network
access, for example). If you're using it with Thunderbird and Enigmail,
you basically just have to configure Enigmail to make calls to
/usr/bin/qubes-gpg-client-wrapper instead of /usr/bin/gpg2. It then
basically proxies your command from your email VM to your GPG VM, then
proxies the output back.

Unfortunately Enigmail 2.0.7 caused it to break:
https://github.com/QubesOS/qubes-issues/issues/3989

It breaks because now Enigmail calls out to gpg with arguments like:

--log-file /tmp/gpgOutput.ln9Jcr

I know that 2.0.7 fixed a security bug, and presumably this was added
for a reason.

So my question is, is it safe for split GPG to simply ignore the
--log-file argument altogether? Or does Enigmail try to do something
with that log file later on, and things will break if it's not there?




signature.asc
Description: OpenPGP digital signature
___
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net