Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
On Sat, 18 Dec 2004 12:45:47 +0900 Carsten Haitzler (The Rasterman) <[EMAIL PROTECTED]> claimed: > yes - but the solution is not (in this case) strn but fixing the > problem upstream - ie blindly using string pointers without checking > them :) or for that matter passing in invalid ones (ie NULL ma

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread The Rasterman
On Fri, 17 Dec 2004 22:23:07 -0500 Frederick Heckel <[EMAIL PROTECTED]> babbled: > On Sat, 18 Dec 2004 09:58:19 +0900 Carsten Haitzler (The Rasterman) > <[EMAIL PROTECTED]> claimed: > > thanks kim :) couldn't have said it better :) as an addition - beware > > of the notion that j

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
On Sat, 18 Dec 2004 09:58:19 +0900 Carsten Haitzler (The Rasterman) <[EMAIL PROTECTED]> claimed: > thanks kim :) couldn't have said it better :) as an addition - beware > of the notion that just because you go use strncmp (or some strn > function) doesn't suddenly make your code safe. its a notion

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread The Rasterman
On Fri, 17 Dec 2004 20:03:33 +0100 Kim Woelders <[EMAIL PROTECTED]> babbled: > Frederick Heckel wrote: > > I'm a longtime fan of Enlightenment, just waiting for DR17. I did a > > CVS ebuild on my Gentoo system yesterday, and have tried out Engage. > > It's very nice, except for on

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
On Fri, 17 Dec 2004 21:57:25 + Andrew Elcock <[EMAIL PROTECTED]> claimed: > It should not be listening to directories at all - see how it passes 0 > as the recurse setup bit? anyhow all .eet icons will be moved to .eapp > soon, so this code will change. > > as for null winclasses - if (winclas

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Valdis . Kletnieks
On Fri, 17 Dec 2004 16:15:16 EST, Frederick Heckel said: > What happened here is that there was an empty directory sitting in my > mapping/ dir. It looks like e_app_new is fine with directories, but it > doesn't actually fill out the app->winclass field if > $subdir/.directory.eet doesn't exist, b

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
On Fri, 17 Dec 2004 15:56:50 -0500 [EMAIL PROTECTED] claimed: > This is just begging the question however - is this: > > 1) A proper fix, because od_icon_mapping_get() could legitimately be > called with a NULL and it should Do Something Reasonable > > 2) Papering over the *real* bug, which is th

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Valdis . Kletnieks
On Fri, 17 Dec 2004 15:11:43 EST, Frederick Heckel said: > Anyway, a null check needs to be added to Engage's icon.c, in > od_icon_mapping_get() to fix the problem. app->winclass was null. Engage > starts up fine for me with this quick change: > > 358c358,359 > < if (strcmp(winclass, app->win

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
Anyway, a null check needs to be added to Engage's icon.c, in od_icon_mapping_get() to fix the problem. app->winclass was null. Engage starts up fine for me with this quick change: 358c358,359 < if (strcmp(winclass, app->winclass) == 0) { --- > > if (winclass&&app->winclass&&strcmp(w

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
On Fri, 17 Dec 2004 20:03:33 +0100 Kim Woelders <[EMAIL PROTECTED]> claimed: > strncmp cannot simply replace strcmp. There isn't even any point in > doing so for the reason mentioned here. Segv in strcmp is typically > because one of the pointers is invalid or NULL, and strncmp will most > likely s

Re: [E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Kim Woelders
Frederick Heckel wrote: I'm a longtime fan of Enlightenment, just waiting for DR17. I did a CVS ebuild on my Gentoo system yesterday, and have tried out Engage. It's very nice, except for one thing: when I try to actually setup any launcher icons, it segfaults. Running a gdb trace, it was segfa

[E-devel] Engage / strcmp v. strncmp

2004-12-17 Thread Frederick Heckel
Hello all, I'm a longtime fan of Enlightenment, just waiting for DR17. I did a CVS ebuild on my Gentoo system yesterday, and have tried out Engage. It's very nice, except for one thing: when I try to actually setup any launcher icons, it segfaults. Running a gdb trace, it was segfaulting in strc

Re: [E-devel] API Documentation?

2004-12-17 Thread Alex
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vincent Torri wrote: | | On Thu, 16 Dec 2004, Alex wrote: | | |>I know that I have seen documentation for the APIs that the libraries |>implement, but I can't find it anymore and a search of the archive |>hasn't turned it up either. Can someone point m