Hi :-]
Your review comments in the attached patch.
Thanks for your response always.
Sincerely,
Shinwoo Kim.
2011/6/29 Vincent Torri vto...@univ-evry.fr
On Wed, 29 Jun 2011, cnook wrote:
Oh I see, I got the point. Thanks for your response.
Wherever the strcasestr() is used using
HAVE_STRCASESTR to use the glibc version
of strcase, or to use your own version
Vincent
On Wed, 29 Jun 2011, cnook wrote:
Hi
Thanks for your response.
I have no enough idea when it comes to E16.
Actually this patch comes because of the Evil Windows environments -
strcasestr does
contained in LSB 3.1
http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generi
c/baselib-strcasestr.html
-Original Message-
From: cnook [mailto:kimci...@gmail.com]
Sent: Wednesday, June 22, 2011 5:56 PM
To: Daniel Juyung Seo
Cc: enlightenment-devel
*haystack, const char *needle);
#endif
In E16/e/src/util.h
From: cnook [mailto:kimci...@gmail.com]
Sent: Tuesday, June 28, 2011 3:58 PM
To: Hyoyoung Chang
Cc: Daniel Juyung Seo; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch][Evil] evil_string has strcasestr
Hi Mr. Hermet,
I got your point, and have attached new patch based on your review comments.
Sincerely,
Shinwoo Kim.
2011년 6월 27일 오후 4:37, ChunEon Park her...@hermet.pe.kr님의 말:
hi cnook, good patch.
But it looks it does not need to deleted event callbacks in pre_hook except
ecore event
Dear All,
Hello,
I have got elm_confrom does not remove its handler while it is deleted.
This patch is for that. Please review attached patch. Thanks always.
Sincerely,
Shinwoo Kim.
Index: src/lib/elm_conform.c
===
---
Thanks for your response.
There is a possibility in newly made elementary widget.
So far, no one have used strcasestr in upstream.
Sincerely,
Shinwoo Kim.
2011/6/22 Vincent Torri vto...@univ-evry.fr
Hey
There is no strcasestr() on MinGW Env.
So this patch comes.. Please review the
Means..
How about install the mingw-langifo instead of using evil_langinfo?
Sincerely,
Shinwoo Kim.
2011/6/22 Vincent Torri vto...@univ-evry.fr
On Wed, 22 Jun 2011, cnook wrote:
Dear Mr. Vincent,
Thanks for your response.
Actually I refer to the previous version mingw-langinfo-0.1
Kim.
2011/6/22 Vincent Torri vto...@univ-evry.fr
On Wed, 22 Jun 2011, cnook wrote:
Means..
How about install the mingw-langifo instead of using evil_langinfo?
what is the licence of mingw-langinfo ?
Vincent
Sincerely,
Shinwoo Kim.
2011/6/22 Vincent Torri vto...@univ-evry.fr
...@univ-evry.fr
wrote:
On Wed, 22 Jun 2011, cnook wrote:
Thanks for your response.
There is a possibility in newly made elementary widget.
So far, no one have used strcasestr in upstream.
i won't add functions if they are not needed. Evil is minimalist and must
remain like
Hi!
Thanks for your response. The patch have been refined and attached.
I have moved MOVE,RESIZE callback handling to elm_conformant_add() from
_prop_change().
Sincerely,
Shinwoo Kim.
2011/6/20 Carsten Haitzler ras...@rasterman.com
On Thu, 16 Jun 2011 18:43:09 +0900 cnook kimci...@gmail.com
Hey
On Fri, 17 Jun 2011, cnook wrote:
Dear All,
Hello~
I add some enumeration variables for building on Windows.
And.. One question,
nl_langinfo(CODESET) gives return value properly on MinGW?
nl_langinfo is not defined on Windows. I never really tested that code...
Note
Hi All,
There is no strcasestr() on MinGW Env.
So this patch comes.. Please review the attached one.
Sincerely,
Shinwoo Kim.
Index: src/lib/evil_string.c
===
--- src/lib/evil_string.c (revision 60564)
+++ src/lib/evil_string.c
Dear All,
Hello~
I add some enumeration variables for building on Windows.
And.. One question,
nl_langinfo(CODESET) gives return value properly on MinGW?
Sincerely,
Shinwoo Kim.
Index: src/lib/evil_langinfo.c
===
---
Dear All,
Hello~
When the indicator is displayed initially and use elm_confrom as parent by
using elm_conformant_content_area_get, the indicator area (wd-shelf) does
not display properly.
Because any interested ECORE_X_EVENT_WINDOW_PROPERTY does not notify.
In this case, we have got to evaluate
Only add a subject.. :-]
2011/6/16 cnook kimci...@gmail.com
Dear All,
Hello~
When the indicator is displayed initially and use elm_confrom as parent by
using elm_conformant_content_area_get, the indicator area (wd-shelf) does
not display properly.
Because any interested
Dear All,
Hi~
If CtxPopup has elm_slider for content, the elm_slider indicator is covered
by CtxPopup arrow.
So, I have made a patch for resolving this issue. As the title the arrow
will be swallowed in the base.
Even though user uses his/her own style, the attached patch will work
properly.
cnook kimci...@gmail.com said:
thanks. still for()s in the test code have no space between for and ( - i
fixed
it though. patch in svn now!
Hello!
Thank you for your response.
I am thoroughly impressed with your in-depth review.
All of your feedback is reflected on the latest attached
:04:19 +0900 cnook kimci...@gmail.com said:
too many problems with this patch :( can you fix the below and re-submit?
1. fails. malformed patch even.
patching file src/lib/elm_diskselector.c
Hunk #5 FAILED at 136.
Hunk #19 succeeded at 780 with fuzz 2.
1 out of 29 hunks FAILED -- saving
Hi All,
Please check latest patch set.
Sincerely,
Shinwoo Kim.
2011/3/28 cnook kimci...@gmail.com
Hi All,
Thanks for your response and suggestion always.
I have attached new patch file which has following modification.
- remove warning message
- support setting by theme and api
that - BUT his
point implies that we should have a vertical diskselector mode too... use
that
for horizontally expanding items, and vice-versa).
I attached a screen shot :)
This is a screen shot from elementary_test Disk Selector which cnook
attached.
Btw, cnook, I have one comment
as the default value, and
allow people to override it from API. So it's essentially what you did
with just adding one line to the init of the object, to set
display_item_num from the theme...
--
Tom.
On Tue, 2011-03-22 at 19:36 +0900, cnook wrote:
Dear All,
Hello :)
Thanks for your
:39 PM, cnook kimci...@gmail.com wrote:
Dear All,
Hi~
Thanks for your response always!
I have changed the elm_diskselector based on your comments.
The displayed item count is described by using theme file.
And example source - example.tar.gz - have attached.
(If you have
Sincerely,
Shinwoo Kim.
2011/3/19 Daniel Juyung Seo seojuyu...@gmail.com
Check the _theme_hook().
:)
Thanks.
Daniel Juyung Seo (SeoZ)
On Sat, Mar 19, 2011 at 1:53 PM, cnook kimci...@gmail.com wrote:
Dear All,
Hi~
Thanks for your response.
I have tried to use data.item
...@profusion.mobi
wrote:
On Thu, Mar 17, 2011 at 10:45 AM, cnook kimci...@gmail.com wrote:
Dear All,
Hi Shinwoo Kim,
This is Shinwoo Kim, learned that I could contribute to EFL! :)
I'm pleased to inform you that the patch for the elm_diskselector.
Until now, the elm_diskselector only display 3
Dear All,
This is Shinwoo Kim, learned that I could contribute to EFL! :)
I'm pleased to inform you that the patch for the elm_diskselector.
Until now, the elm_diskselector only display 3 items at once,
if you accept this patch, the elm_diskselector can display more than 3
items.
For this
101 - 126 of 126 matches
Mail list logo
