Why did you revert this patch?
The commit message does not describe enough. It does not looks like
breaking any compatibility.
Thanks.
Daniel Juyung Seo (SeoZ)
On Thu, Jul 18, 2013 at 1:03 PM, ChunEon Park - Enlightenment Git <
no-re...@enlightenment.org> wrote:
> hermet pushed a commit to branch master.
>
> commit f5b62fcd97cf7697486c0c0d0ea2cf84fc99ec11
> Author: ChunEon Park <her...@hermet.pe.kr>
> Date: Thu Jul 18 13:02:19 2013 +0900
>
> elementary/layout - revert commit
> b4e1b33cbea974e7e05d61a1c37c21f97ff7eabd for the app compatibility.
> ---
> ChangeLog | 4 ----
> NEWS | 1 -
> src/lib/elm_layout.c | 10 ++++++++--
> 3 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 0aa1105..cb25155 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1510,7 +1510,3 @@
> the imf is available, the keyboard mode should be decided by ime,
> but
> not entry. This prevents the asynchronous states between ime and
> conformant.
> -
> -2013-07-17 ChunEon Park (Hermet)
> -
> - * Layout : Send visible/hidden signals whenever contents are
> set/unset (not only icon and end parts)
> diff --git a/NEWS b/NEWS
> index 44e6b82..4624a5b 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -296,7 +296,6 @@ Additions:
> * Elm_Win_Trap and elm_win_trap_set() to allow e17 integration.
> * elm_flip_go_to()
> * On focus loss, Elm_Spinner properly hide Elm_Entry and display label
> properly.
> - * Layout : Send visible/hidden signals whenever contents are set/unset
> (not only icon and end parts)
>
> Fixes:
>
> diff --git a/src/lib/elm_layout.c b/src/lib/elm_layout.c
> index 071e71b..6e44f19 100644
> --- a/src/lib/elm_layout.c
> +++ b/src/lib/elm_layout.c
> @@ -132,7 +132,11 @@ _icon_signal_emit(Elm_Layout_Smart_Data *sd,
> char buf[1024];
> const char *type;
>
> - if (sub_d->type != SWALLOW) return;
> + //FIXME: Don't limit to the icon and end here.
> + // send signals for all contents after elm 2.0
> + if (sub_d->type != SWALLOW ||
> + (strcmp("elm.swallow.icon", sub_d->part) &&
> + (strcmp("elm.swallow.end", sub_d->part)))) return;
>
> if (strncmp(sub_d->part, "elm.swallow.", sizeof("elm.swallow.") - 1)
> == 0)
> type = sub_d->part + sizeof("elm.swallow.") - 1;
> @@ -157,7 +161,9 @@ _text_signal_emit(Elm_Layout_Smart_Data *sd,
> char buf[1024];
> const char *type;
>
> - if (sub_d->type != TEXT) return;
> + //FIXME: Don't limit to "elm.text" prefix.
> + //Send signals for all text parts after elm 2.0
> + if (sub_d->type != TEXT || strcmp("elm.text", sub_d->part)) return;
>
> Elm_Widget_Smart_Data *wd = eo_data_scope_get(sd->obj,
> ELM_OBJ_WIDGET_CLASS);
>
>
> --
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
