Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_image: Fix remote image loading

2013-10-01 Thread daniel.za...@samsung.com
It's impossible! This man has a second life during the night and he can't be late. Gangnam can't live without him. On 10/01/2013 12:52 PM, Michael Blumenkrantz wrote: > commit now! test/review later! > > > On Tue, Oct 1, 2013 at 10:48 AM, Jean-Philippe André wrote: > >> Hi! >> >> Indeed, I totall

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_image: Fix remote image loading

2013-10-01 Thread Michael Blumenkrantz
commit now! test/review later! On Tue, Oct 1, 2013 at 10:48 AM, Jean-Philippe André wrote: > Hi! > > Indeed, I totally missed that case as all elementary_test cases call show() > after file_set()... > The commit to blame was dcb8b54aee3a545a1. > > So, let me explain why I introduced these change

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_image: Fix remote image loading

2013-10-01 Thread Jean-Philippe André
Hi! Indeed, I totally missed that case as all elementary_test cases call show() after file_set()... The commit to blame was dcb8b54aee3a545a1. So, let me explain why I introduced these changes in the first place. While working on cserve2 (I'll talk about it more soon!), I realized that even "huge

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_image: Fix remote image loading

2013-10-01 Thread daniel.za...@samsung.com
Yo JP, Could your commit be the cause of the non loading of the image if file_set is done after show? Now, only if show is done after file_set, it will load it. JackDanielZ, alias Daniel On 09/26/2013 01:00 PM, Jean-Philippe Andre wrote: > jpeg pushed a commit to branch master. > > http://git.