Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-29 Thread Gustavo Sverzut Barbieri
On Thu, Apr 28, 2011 at 7:11 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Apr 28, 2011 at 1:18 PM, Eduardo Felipe eduardofelip...@gmail.com wrote: I would appreciate if I'm mentioned as the author of the patch and the commit message is preserved. This is the third time a

[E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
Folks, Mac OS X does not provide an implementation of clock_gettime() even though it's POSIX, but it does provide a fast high-resolution monotonic clock through mach specific APIs that are perfectly suited for usage in ecore_timer. Without this patch ecore_timer throws a critical warning on Mac

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: Folks, Mac OS X does not provide an implementation of clock_gettime() even though it's POSIX, but it does provide a fast high-resolution monotonic clock through mach specific APIs that are perfectly suited for usage in ecore_timer. Without this

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
I would appreciate if I'm mentioned as the author of the patch and the commit message is preserved. This is the third time a patch of mine is accepted without attribution, and I think it shows a lack of care for input from users. Eduardo. On Thu, Apr 28, 2011 at 3:43 PM, Vincent Torri

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: I would appreciate if I'm mentioned as the author of the patch and the commit message is preserved. This is the third time a patch of mine is accepted without attribution, and I think it shows a lack of care for input from users. what I can do is

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Vincent Torri wrote: On Thu, 28 Apr 2011, Eduardo Felipe wrote: I would appreciate if I'm mentioned as the author of the patch and the commit message is preserved. This is the third time a patch of mine is accepted without attribution, and I think it shows a lack of

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
Reverting is dangerous. I guess should have written the changes to the Changelog myself. Should I write it now or would you do it for me? On Thu, Apr 28, 2011 at 4:21 PM, Vincent Torri vto...@univ-evry.fr wrote: On Thu, 28 Apr 2011, Vincent Torri wrote: On Thu, 28 Apr 2011, Eduardo Felipe

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: Reverting is dangerous. I guess should have written the changes to the Changelog myself. Should I write it now or would you do it for me? do it, so that you'll put exactly what you want. Vincent On Thu, Apr 28, 2011 at 4:21 PM, Vincent Torri

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
So here is the patch for the ChangeLog. Thanks, Eduardo Felipe. On Thu, Apr 28, 2011 at 4:25 PM, Vincent Torri vto...@univ-evry.fr wrote: On Thu, 28 Apr 2011, Eduardo Felipe wrote: Reverting is dangerous. I guess should have written the changes to the Changelog myself. Should I write it

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: So here is the patch for the ChangeLog. Thanks, done, sorry for not mentioning you Vincent Eduardo Felipe. On Thu, Apr 28, 2011 at 4:25 PM, Vincent Torri vto...@univ-evry.fr wrote: On Thu, 28 Apr 2011, Eduardo Felipe wrote: Reverting is

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Lucas De Marchi
On Thu, Apr 28, 2011 at 1:18 PM, Eduardo Felipe eduardofelip...@gmail.com wrote: I would appreciate if I'm mentioned as the author of the patch and the commit message is preserved. This is the third time a patch of mine is accepted without attribution, and I think it shows a lack of care for