Re: [E-devel] [PATCH] ecore/ecore_fb: Tweaks in _ecore_fb_size_get

2012-03-22 Thread The Rasterman
On Wed, 21 Mar 2012 22:29:48 +0530 Vikram Narayanan vikram...@gmail.com said: On 3/21/2012 3:28 PM, Carsten Haitzler (The Rasterman) wrote: On Sat, 17 Mar 2012 15:16:49 +0530 Vikram Narayananvikram...@gmail.com said: As the width and height are defined as static, no need to initialize it

Re: [E-devel] [PATCH] ecore/ecore_fb: Tweaks in _ecore_fb_size_get

2012-03-21 Thread The Rasterman
On Sat, 17 Mar 2012 15:16:49 +0530 Vikram Narayanan vikram...@gmail.com said: As the width and height are defined as static, no need to initialize it again to zero. Also removed checks for 'valid pointers' as it is redundant. question... why did you make these changes? did you get warnings or

Re: [E-devel] [PATCH] ecore/ecore_fb: Tweaks in _ecore_fb_size_get

2012-03-21 Thread Vikram Narayanan
On 3/21/2012 3:28 PM, Carsten Haitzler (The Rasterman) wrote: On Sat, 17 Mar 2012 15:16:49 +0530 Vikram Narayananvikram...@gmail.com said: As the width and height are defined as static, no need to initialize it again to zero. Also removed checks for 'valid pointers' as it is redundant.