I pushed this patch with the suggested changes, plese let me know if
there is anything else needed to change.
Regards, Etrunko
On Fri, Apr 19, 2013 at 11:05 AM, Eduardo Lima (Etrunko)
ebl...@gmail.com wrote:
On Fri, Apr 19, 2013 at 10:54 AM, Rafael Antognolli
antogno...@gmail.com wrote:
On
At quick glance it seems ok. Noticed a lot of formatting problems, but
those can be addressed later. I'll read through it a bit closer in the
morning.
Thanks :)
dh
On 06/24/13 20:19, Eduardo Lima (Etrunko) wrote:
I pushed this patch with the suggested changes, plese let me know if
there is
Hi Jan,
Thanks for the efforts here :)
After a quick review, this seems ok. Some of the formatting is wrong
(ie: not EFL style), however that is just a minor thing. One thing that
does concern me here tho is why:
+ wl_display_roundtrip(display);
is being called in the im_module_init ?
Also, you could use ecore_wl_registry_get instead of
wl_display_get_registry.
And ecore_wl_display_iterate instead of wl_display_dispatch.
dh
On 19/04/13 10:53, Chris Michael wrote:
Hi Jan,
Thanks for the efforts here :)
After a quick review, this seems ok. Some of the formatting is wrong
Hi!
Thanks for the quick review.
I will find a better solution for the im_module_init and fix the formatting.
Jan Arne
On 04/19/2013 11:56 AM, Chris Michael wrote:
Also, you could use ecore_wl_registry_get instead of
wl_display_get_registry.
And ecore_wl_display_iterate instead of
On Fri, Apr 19, 2013 at 6:56 AM, Chris Michael devilho...@comcast.net wrote:
Also, you could use ecore_wl_registry_get instead of
wl_display_get_registry.
And ecore_wl_display_iterate instead of wl_display_dispatch.
dh
Notice that the wl_display_dispatch (and consequently,
On Fri, Apr 19, 2013 at 10:54 AM, Rafael Antognolli
antogno...@gmail.com wrote:
On Fri, Apr 19, 2013 at 6:56 AM, Chris Michael devilho...@comcast.net wrote:
Also, you could use ecore_wl_registry_get instead of
wl_display_get_registry.
And ecore_wl_display_iterate instead of
