Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-19 Thread The Rasterman
> Regards > > Patrick > > -Original Message- > From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] > Sent: 18 września 2012 13:28 > To: Enlightenment developer list > Cc: Patryk Kaczmarek > Subject: Re: [E-devel] [Patch] [Ecore] Patch with NULL

Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-18 Thread Patryk Kaczmarek
: Enlightenment developer list Cc: Patryk Kaczmarek Subject: Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module On Mon, 17 Sep 2012 17:19:43 +0200 Patryk Kaczmarek said: did u try compile this? :) ecore_imf_evas.c: In function ‘ecore_imf_evas_event_key_up_wrap

Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-18 Thread Patryk Kaczmarek
Indeed, I had fixed that mistakes. Patch attached. -Original Message- From: Vincent Torri [mailto:vincent.to...@gmail.com] Sent: 17 września 2012 19:30 To: Enlightenment developer list Subject: Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module On

Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-18 Thread The Rasterman
On Mon, 17 Sep 2012 17:19:43 +0200 Patryk Kaczmarek said: did u try compile this? :) ecore_imf_evas.c: In function ‘ecore_imf_evas_event_key_up_wrap’: ecore_imf_evas.c:304:9: warning: implicit declaration of function ‘CRIT’ ecore_imf_evas.c:308:9: error: ‘storage’ undeclared (first use in this f

Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-17 Thread Vincent Torri
On Mon, Sep 17, 2012 at 7:29 PM, Vincent Torri wrote: > On Mon, Sep 17, 2012 at 5:19 PM, Patryk Kaczmarek > wrote: >> Hi Everyone, >> >> >> >> I had prepared patch for some Ecore functions which, in my opinion, >> critically need NULL checks. I had tried to keep each file convention. >> >> >> >>

Re: [E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-17 Thread Vincent Torri
On Mon, Sep 17, 2012 at 5:19 PM, Patryk Kaczmarek wrote: > Hi Everyone, > > > > I had prepared patch for some Ecore functions which, in my opinion, > critically need NULL checks. I had tried to keep each file convention. > > > > Then please review and consider the attachment and give some feedback

[E-devel] [Patch] [Ecore] Patch with NULL checks to some functions in ecore module

2012-09-17 Thread Patryk Kaczmarek
Hi Everyone, I had prepared patch for some Ecore functions which, in my opinion, critically need NULL checks. I had tried to keep each file convention. Then please review and consider the attachment and give some feedback. Regards, Patrick ecore_NULL_check.patch Description: B