Dear Daniel,
Overall, the patch looks good, there are a couple of comments/questions
which by themselves aren't so bad, but because there are more than a
few, I'm sending it back to them to fix them.
Several comments/questions:
1. style { name: "seg_text_style_disabled";
Why the font_size here is
Dear Daniel,
First of all, I didn't do fit, it was already there, just size_range :)
Second of all, you tarred it, you didn't tar+gzip, so the suffix of
filename is wrong (which confused fileroller)
Will review soon,
Tom.
On Thu, 2011-03-17 at 18:33 +0900, Daniel Juyung Seo wrote:
> Hello,
> Pr
elm_label usage ). He is
> >> waiting for elm_label to be patched first...
> >>
> >>
> >>
> >> Regards,
> >>
> >> Govind
> >>
> >>
> >>
> >> --- Original Message ---
> >>
> >> Se
gt;
>>
>>
>> --- Original Message ---
>>
>> Sender : Carsten Haitzler
>>
>> Date : Feb 16, 2011 11:22 (GMT+05:30)
>>
>> Title : Re: [E-devel] [Patch] New Widget elm_segment_control
>>
>> On Thu, 10 Feb 2011 19:08:08 +0530 GOVIN
> Date : Feb 16, 2011 11:22 (GMT+05:30)
>
> Title : Re: [E-devel] [Patch] New Widget elm_segment_control
>
> On Thu, 10 Feb 2011 19:08:08 +0530 GOVINDARAJU SM said:
>
> i'm waiting on the new patch here.
>
> as for the elm_label vs edje text/textblock thing...
>
On Thu, 10 Feb 2011 19:08:08 +0530 GOVINDARAJU SM said:
i'm waiting on the new patch here.
as for the elm_label vs edje text/textblock thing...
govind.. didnt i already bring that up with you? :) the EFL devs have been
trained well.. saying the same thing. :)
so let me put here what i said to
oops, gettext integration to elm is already done...:) my bad.
GOVINDARAJU SM wrote:
> Tom Hacohen wrote:
>
>> elm_label uses part TEXT to do that, why don't you do the same?
>>
>>
> I like to support multi line text with tags, so I prefer to go with
> TEXTBLOCK.
>
> but I have to repea
Atton Jonathan wrote:
>
> The widget does not fit correctly to the size of each items. I think
> the minimum width of the widget should be : min(item 1) + min(item 2)
> ... It seems not working but maybe I have done something wrong.
To accommodate all the items with in base widget size, segments
Tom Hacohen wrote:
> elm_label uses part TEXT to do that, why don't you do the same?
>
I like to support multi line text with tags, so I prefer to go with
TEXTBLOCK.
but I have to repeat the
1. text size shrinking based on item width, text wrap and item height.
2. Text size bigger even after
As you can see, I've drained my batteries for today.
--
Tom.
On Fri, 2011-02-11 at 01:18 +0900, Daniel Juyung Seo wrote:
> > Btw, ellipsis already has ellipsis support :)) but still no fit support.
>
> I guess you want to say 'TEXTBLOCK already has ellipsis support' :)
>
>
> On Fri, Feb 11, 20
> Btw, ellipsis already has ellipsis support :)) but still no fit support.
I guess you want to say 'TEXTBLOCK already has ellipsis support' :)
On Fri, Feb 11, 2011 at 12:44 AM, Tom Hacohen
wrote:
> elm_label uses part TEXT to do that, why don't you do the same?
>
> Btw, ellipsis already has ell
The widget does not fit correctly to the size of each items. I think the
minimum width of the widget should be : min(item 1) + min(item 2) ... It
seems not working but maybe I have done something wrong.
2011/2/10 Tom Hacohen
> elm_label uses part TEXT to do that, why don't you do the same?
>
> B
elm_label uses part TEXT to do that, why don't you do the same?
Btw, ellipsis already has ellipsis support :)) but still no fit support.
But as I said, TEXT does have it, you should probably use TEXT for that.
--
Tom.
On Thu, 2011-02-10 at 21:14 +0530, GOVINDARAJU SM wrote:
> Hi Tom,
>
> Its j
Hi Tom,
Its just for auto font resizing ( between Max and Min range configured in
elm-label edc) to fit the text with in widget area, and do auto ellipsis, if
the text doesn't fit in the widget area with min font size.
IMO, every widget with text requires auto text shrinking/ellipsis feature,
Well, you first have to make sure your style has a TEXT part (elm_label
does some funky stuff there, so please verify).
But that's for another email ;)
--
Tom.
On Thu, 2011-02-10 at 16:07 +0100, Nicolas Aguirre wrote:
> 2011/2/10 Nicolas Aguirre :
> > 2011/2/10 Tom Hacohen :
> >> I agree. Govind:
2011/2/10 Nicolas Aguirre :
> 2011/2/10 Tom Hacohen :
>> I agree. Govind: why are you using elm_label? any specific reason (a
>> feature not supported by part TEXTBLOCK maybe?)
>>
>> Thanks,
>> Tom.
>>
>
> +1, i don't like elm_label in a button.
>
>
> --
> Nicolas Aguirre
> Mail: aguirre.nico...@gm
2011/2/10 Tom Hacohen :
> I agree. Govind: why are you using elm_label? any specific reason (a
> feature not supported by part TEXTBLOCK maybe?)
>
> Thanks,
> Tom.
>
+1, i don't like elm_label in a button.
--
Nicolas Aguirre
Mail: aguirre.nico...@gmail.com
Web: http://enna.geexbox.org
Blog: htt
I agree. Govind: why are you using elm_label? any specific reason (a
feature not supported by part TEXTBLOCK maybe?)
Thanks,
Tom.
On Thu, 2011-02-10 at 15:31 +0100, Atton Jonathan wrote:
> I don't like teh idea to use elm_label instead of a part of type TEXT.
> All widgets (especially button) use
I don't like teh idea to use elm_label instead of a part of type TEXT. All
widgets (especially button) use a part. We can't set a specific font/color
... with elm_label.
2011/2/10 Daniel Juyung Seo
> Process looks OK here :)
> But I should have tested before I forward a patch :(
> So busy :(
>
>
Process looks OK here :)
But I should have tested before I forward a patch :(
So busy :(
On Thu, Feb 10, 2011 at 10:37 PM, Atton Jonathan
wrote:
> hehe oki :)
>
> 2011/2/10 Tom Hacohen
>
>> They found their patch, please wait for them to revise it and then we'll
>> just commit that one (just to
Ahhh wait, see my other reply :)
Regarding the != '\0', honestly, if someone doesn't understand that, I
prefer not to accept his code. But again, that's just my point of view.
--
Tom.
On Thu, 2011-02-10 at 14:37 +0100, Atton Jonathan wrote:
> I prefer to use " != '\0'" because everyone can under
hehe oki :)
2011/2/10 Tom Hacohen
> They found their patch, please wait for them to revise it and then we'll
> just commit that one (just to make the small merge easier).
>
> Thanks,
> Tom.
>
> On Thu, 2011-02-10 at 15:26 +0200, Tom Hacohen wrote:
> > It's cleaner and more readable to do to do
>
Replied to that post, we'll wait for a revised patch there.
--
Tom.
On Thu, 2011-02-10 at 18:57 +0530, GOVINDARAJU SM wrote:
> Hi Tom,
>
> I did a back track of elm_label patches submitted to EFL, found this
> patch http://sourceforge.net/mailarchive/message.php?msg_id=26890769
> submitted
They found their patch, please wait for them to revise it and then we'll
just commit that one (just to make the small merge easier).
Thanks,
Tom.
On Thu, 2011-02-10 at 15:26 +0200, Tom Hacohen wrote:
> It's cleaner and more readable to do to do
> (*replocater) instead of (*replocater != '\0').
>
Hi Tom,
I will add mirroring support to segment control and send you new patch.
Regards,
Govind
Tom Hacohen wrote:
> On Thu, 2011-02-10 at 14:01 +0100, Cedric BAIL wrote:
>
>> I prefer we make it a rule to always commit widget that work in both
>> mode, or people will never bother to fix them
I prefer to use " != '\0'" because everyone can understand this code, young
devs. But ok I commit your version.
2011/2/10 Tom Hacohen
> It's cleaner and more readable to do to do
> (*replocater) instead of (*replocater != '\0').
> But other than that it looks like a solid patch that should go in
It's cleaner and more readable to do to do
(*replocater) instead of (*replocater != '\0').
But other than that it looks like a solid patch that should go in
anyway...
--
Tom.
On Thu, 2011-02-10 at 14:19 +0100, Atton Jonathan wrote:
>
> The patch of elm_label. Maybe somsung has a better patch. Te
Hi Tom,
I did a back track of elm_label patches submitted to EFL, found this
patch http://sourceforge.net/mailarchive/message.php?msg_id=26890769
submitted on 2011-01-13, by Hyoyoung Chang.
Looks like this patch went unnoticed, due to elm_label wrap mode patch
with similar subject line. :)
The patch of elm_label. Maybe somsung has a better patch. Tell me if I
should commit it or not.
2011/2/10 GOVINDARAJU SM
> Hi Tom,
>
> SegmentControl uses elm_label internally ( for font size reduction to
> fit the text and for ellipsis ). There is a bug in elm_label which
> makes segment cont
On Thu, 2011-02-10 at 14:01 +0100, Cedric BAIL wrote:
> I prefer we make it a rule to always commit widget that work in both
> mode, or people will never bother to fix them. It's the only sane way
> to be sure to have the result at the end.
I'm fine what that.
Govind: please add ui-mirroring supp
On Thu, Feb 10, 2011 at 1:51 PM, Tom Hacohen
wrote:
> On Thu, 2011-02-10 at 13:49 +0100, Atton Jonathan wrote:
>> Maybe we should have a list of widgets which do not implement
>> ui-mirroring ? This way we will not forget to do it before a stable
>> version ?
>
> Honestly, although it's a good ide
On Thu, 2011-02-10 at 13:49 +0100, Atton Jonathan wrote:
> Maybe we should have a list of widgets which do not implement
> ui-mirroring ? This way we will not forget to do it before a stable
> version ?
Honestly, although it's a good idea, I prefer that people would just not
add widgets without mi
Maybe we should have a list of widgets which do not implement ui-mirroring ?
This way we will not forget to do it before a stable version ?
2011/2/10 Tom Hacohen
> On Thu, 2011-02-10 at 17:27 +0530, GOVINDARAJU SM wrote:
> > SegmentControl uses elm_label internally ( for font size reduction to
>
On Thu, 2011-02-10 at 17:27 +0530, GOVINDARAJU SM wrote:
> SegmentControl uses elm_label internally ( for font size reduction to
> fit the text and for ellipsis ). There is a bug in elm_label which
> makes segment control crash on opensource SVN.
> We will submit patch for elm_label to fix the
Hi Tom,
SegmentControl uses elm_label internally ( for font size reduction to
fit the text and for ellipsis ). There is a bug in elm_label which
makes segment control crash on opensource SVN.
We will submit patch for elm_label to fix the issue.
And, detail on Segment control Widget: Segment
Ok, correction:
I applied the patch and tried it, the test at elementary test segs for
me. Please make sure it works in EFL without samsung modifications.
--
Tom.
On Thu, 2011-02-10 at 07:52 +, Tom Hacohen wrote:
> Hey Daniel,
>
> Could you please explain a bit about this widget? (for those
Hey Daniel,
Could you please explain a bit about this widget? (for those of us that
are too lazy to try it)
And please also generate a patch so it'll be easier for all of us to
test.
One last comment: I didn't yet test it, so I don't know if it even makes
sense for this widget, but it doesn't ha
Hello,
Govindaraju SM and Prince Kumar Dubey sent me a new widget
elm_segment_control.
They're not allowed to send a file to out of company. :(
Anybody can review this?
I attached screenshot and patch codes.
And below are an email from them.
Thanks.
Daniel Juyung Seo (SeoZ)
--
38 matches
Mail list logo
