Wow!! This is very nice patch-review iteration :)
Good model.
Thank you all!
Daniel Juyung Seo (SeoZ)
2011. 2. 16. 오후 9:51에 "Cedric BAIL" 님이 작성:
--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
On Wed, Feb 16, 2011 at 2:00 AM, sangho park wrote:
> yes, I've tested the API.
> I added a simple example to 'ecore/examples/ecore_file_download_example.c'.
> pls review again~
Patch is in with a small fix. Thanks.
--
Cedric BAIL
On Wed, Feb 16, 2011 at 9:23 AM, Dave Andreoli wrote:
> The doxy for ecore_file_download() say:
> The @p status parameter of @p completion_cb
> will be filled with the status of the download (200, 404,...).
>
> Is this true? I never see a status different than 0 or 1.
> Is this a bug in the resu
The doxy for ecore_file_download() say:
The @p status parameter of @p completion_cb
will be filled with the status of the download (200, 404,...).
Is this true? I never see a status different than 0 or 1.
Is this a bug in the result value or just an error in the doxy?
It would be really usefu
yes, I've tested the API.
I added a simple example to 'ecore/examples/ecore_file_download_example.c'.
pls review again~
On Tue, Feb 15, 2011 at 11:04 PM, Vincent Torri wrote:
>
>
> On Tue, 15 Feb 2011, Cedric BAIL wrote:
>
> Hi,
>>
>> On Tue, Feb 15, 2011 at 1:15 PM, sangho park wrote:
>>
>>
On Tue, 15 Feb 2011, Cedric BAIL wrote:
> Hi,
>
> On Tue, Feb 15, 2011 at 1:15 PM, sangho park wrote:
>> sure~ I modified.
>> I hope that this patch is the last.. :)
>
> Sounds good to me. Will feel better if someone else also do another
> review before applying to svn. If nobody does before to
Hi,
On Tue, Feb 15, 2011 at 1:15 PM, sangho park wrote:
> sure~ I modified.
> I hope that this patch is the last.. :)
Sounds good to me. Will feel better if someone else also do another
review before applying to svn. If nobody does before tomorrow, I will
commit it to svn and wait for people to
sure~ I modified.
I hope that this patch is the last.. :)
On Tue, Feb 15, 2011 at 9:05 PM, Cedric BAIL wrote:
> On Tue, Feb 15, 2011 at 12:50 PM, sangho park wrote:
> > thanks for your comments.
> > I changed Eina_List to Eina_Hash.
> > one more attached..
>
> Thanks for the quick improvements.
On Tue, Feb 15, 2011 at 12:50 PM, sangho park wrote:
> thanks for your comments.
> I changed Eina_List to Eina_Hash.
> one more attached..
Thanks for the quick improvements. Just one last remark, could you
prefix _headers_foreach_cb in ecore file download private namespace.
Like _ecore_file_downl
thanks for your comments.
I changed Eina_List to Eina_Hash.
one more attached..
On Tue, Feb 15, 2011 at 7:05 PM, Cedric BAIL wrote:
> Hi,
>
> On Tue, Feb 15, 2011 at 10:47 AM, sangho park wrote:
> > fine. I revised and attached again.
>
> Ok, just doing a quick review. I don't like much the Ei
Hi,
On Tue, Feb 15, 2011 at 10:47 AM, sangho park wrote:
> fine. I revised and attached again.
Ok, just doing a quick review. I don't like much the Eina_List for the
header. At least it should be more documented about what should be put
inside this list, or we could rely on an Eina_Hash and use
fine. I revised and attached again.
On Tue, Feb 15, 2011 at 6:22 PM, Vincent Torri wrote:
>
>
> On Tue, 15 Feb 2011, sangho park wrote:
>
> Dear all,
>>
>> This is a patch for ecore_file_download.
>> - add 'ecore_file_download_with_additional_headers' API
>>
>
> i don't like the name.
>
> ecor
On Tue, Feb 15, 2011 at 10:22 AM, Vincent Torri wrote:
> On Tue, 15 Feb 2011, sangho park wrote:
>> Dear all,
>>
>> This is a patch for ecore_file_download.
>> - add 'ecore_file_download_with_additional_headers' API
>
> i don't like the name.
Me too.
> ecore_file_download_full ?
Sounds a little
On Tue, 15 Feb 2011, sangho park wrote:
> Dear all,
>
> This is a patch for ecore_file_download.
> - add 'ecore_file_download_with_additional_headers' API
i don't like the name.
ecore_file_download_full ?
Vincent
>
> If someone who uses 'ecore_file_download' wants to add additional headers t
Dear all,
This is a patch for ecore_file_download.
- add 'ecore_file_download_with_additional_headers' API
If someone who uses 'ecore_file_download' wants to add additional headers to
ecore_con,
(e.g : Content-type, Transfer-Encoding, User-Agent, etc) there is no API to
do that.
so, I added new A
15 matches
Mail list logo
