Re: [E-devel] E SVN: billiob trunk/BINDINGS/python/python-elementary/elementary

2009-11-08 Thread Boris 'billiob' Faure
On Sun, Nov 8, 2009 at 22:09, Nicolas Cavallari wrote: > Gustavo Sverzut Barbieri a écrit : >> Also, we need to review this in whole Elementary... it was complicate >> to get right for evas/edje/ecore, but they are correct now... you need >> to check them or ask me, if we start to spread minor err

Re: [E-devel] E SVN: billiob trunk/BINDINGS/python/python-elementary/elementary

2009-11-08 Thread Nicolas Cavallari
Gustavo Sverzut Barbieri a écrit : > Also, we need to review this in whole Elementary... it was complicate > to get right for evas/edje/ecore, but they are correct now... you need > to check them or ask me, if we start to spread minor errors like this > then we'll have hard time tracking these beas

Re: [E-devel] E SVN: billiob trunk/BINDINGS/python/python-elementary/elementary

2009-11-08 Thread Boris 'billiob' Faure
On Sun, Nov 8, 2009 at 15:09, Gustavo Sverzut Barbieri wrote: > On Sun, Nov 8, 2009 at 11:50 AM, Enlightenment SVN > wrote: > > > +        if not callable(callback): > +            raise TypeError("callback is not callable") > > you should do this check when you register the callback, not when yo

Re: [E-devel] E SVN: billiob trunk/BINDINGS/python/python-elementary/elementary

2009-11-08 Thread Gustavo Sverzut Barbieri
On Sun, Nov 8, 2009 at 11:50 AM, Enlightenment SVN wrote: +if not callable(callback): +raise TypeError("callback is not callable") you should do this check when you register the callback, not when you call it. Compare: you add one item at most 1 time, but call it multiple (N