Re: [E-devel] Ecore Glib Integration

2013-08-08 Thread Christopher Michael
On 08/08/13 21:47, Mike McCormack wrote: > On 08/08/2013 09:59 PM, Christopher Michael wrote: > >> Are you ok if I fix this (use g_source_remove_poll there). Or are you >> already planning to fix this ?? > Fixed upstream now :) > Go ahead and fix it. I've just started a new job, and am a bit sho

Re: [E-devel] Ecore Glib Integration

2013-08-08 Thread Mike McCormack
On 08/08/2013 09:59 PM, Christopher Michael wrote: > Are you ok if I fix this (use g_source_remove_poll there). Or are you > already planning to fix this ?? Go ahead and fix it. I've just started a new job, and am a bit short on time right now. I did manage to get efl/ecore building (gah! bull

Re: [E-devel] Ecore Glib Integration

2013-08-08 Thread Christopher Michael
On 08/08/13 12:03, Mike McCormack wrote: > On 08/08/2013 07:27 PM, Christopher Michael wrote: >> I believe that I have discovered a problem with the glib integration >> into ecore main loop. Basically the issue is this: >> >> _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correc

Re: [E-devel] Ecore Glib Integration

2013-08-08 Thread Michael Blumenkrantz
Random bug spotting in this case, though I can confirm that the integration is still totally functional. On Thu, Aug 8, 2013 at 12:03 PM, Mike McCormack wrote: > On 08/08/2013 07:27 PM, Christopher Michael wrote: > > I believe that I have discovered a problem with the glib integration > > into e

Re: [E-devel] Ecore Glib Integration

2013-08-08 Thread Mike McCormack
On 08/08/2013 07:27 PM, Christopher Michael wrote: > I believe that I have discovered a problem with the glib integration > into ecore main loop. Basically the issue is this: > > _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correct) > > BUT > > _ecore_main_fdh_poll_del is call

[E-devel] Ecore Glib Integration

2013-08-08 Thread Christopher Michael
I believe that I have discovered a problem with the glib integration into ecore main loop. Basically the issue is this: _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correct) BUT _ecore_main_fdh_poll_del is callback g_source_add_poll also (which smells wrong). Shouldn't t