Re: [E-devel] Esmart Text Entry Unknown string output to stderr

2005-12-14 Thread Morten Nilsen
Phuah Yee Keat wrote: else { +#if DEBUG fprintf (stderr, Unknown string %s\n, down-keyname); +#endif } wouldn't it be better if the #if was moved above else? the compiler probably optimizes it away anyway, but.. Cheers, -- Morten :wq

Re: [E-devel] Esmart Text Entry Unknown string output to stderr

2005-12-14 Thread Phuah Yee Keat
Morten Nilsen wrote: Phuah Yee Keat wrote: else { +#if DEBUG fprintf (stderr, Unknown string %s\n, down-keyname); +#endif } wouldn't it be better if the #if was moved above else? the compiler probably optimizes it away anyway, but.. Hmm, it din really occur

Re: [E-devel] Esmart Text Entry Unknown string output to stderr

2005-12-14 Thread Morten Nilsen
Phuah Yee Keat wrote: Morten Nilsen wrote: wouldn't it be better if the #if was moved above else? the compiler probably optimizes it away anyway, but.. Hmm, it din really occur to me...sorry for missing that. I guess this change doesn't need a patch from me eh? :) it's easy to miss such

Re: [E-devel] Esmart Text Entry Unknown string output to stderr

2005-12-14 Thread Brian Mattern
On Wednesday 14 December 2005 05:04, Morten Nilsen wrote: Phuah Yee Keat wrote: else { +#if DEBUG fprintf (stderr, Unknown string %s\n, down-keyname); +#endif } wouldn't it be better if the #if was moved above else? the compiler probably optimizes it away

[E-devel] Esmart Text Entry Unknown string output to stderr

2005-12-13 Thread Phuah Yee Keat
Hi, There's this TODO item in Entrance about Spewing of messages about shift and alt keys, realized that its actually from emsart, and not entrance. So if the esmart patch is acceptable, the entrance TODO list can be updated as well. :) One question, issit easier for you guys to update by

Re: [E-devel] Esmart Text Entry Unknown string output to stderr

2005-12-13 Thread Brian Mattern
Phuah Yee Keat wrote: Hi, There's this TODO item in Entrance about Spewing of messages about shift and alt keys, realized that its actually from emsart, and not entrance. So if the esmart patch is acceptable, the entrance TODO list can be updated as well. :) One question, issit easier for