[E-devel] Evas bugger

2009-08-24 Thread Christopher Michael
Looking through some code, I stumbled upon this which doesn't seem right: EAPI Evas * evas_object_evas_get(const Evas_Object *obj) { MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ); return NULL; MAGIC_CHECK_END(); if (obj-delete_me) return 0; return obj-layer-evas; } Shouldn't that

Re: [E-devel] Evas bugger

2009-08-24 Thread Christopher Michael
Christopher Michael wrote: Looking through some code, I stumbled upon this which doesn't seem right: EAPI Evas * evas_object_evas_get(const Evas_Object *obj) { MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ); return NULL; MAGIC_CHECK_END(); if (obj-delete_me) return 0;

Re: [E-devel] Evas bugger

2009-08-24 Thread Mikhail Gusarov
Twas brillig at 06:28:41 24.08.2009 UTC-04 when cpmicha...@comcast.net did gyre and gimble: CM if (obj-delete_me) return 0; CM Shouldn't that be: CM if (obj-delete_me) return NULL; ./linux/stddef.h:#define NULL 0 -- http://fossarchy.blogspot.com/ pgpxxDGlAnKXA.pgp

Re: [E-devel] Evas bugger

2009-08-24 Thread Vincent Torri
On Mon, 24 Aug 2009, Christopher Michael wrote: Christopher Michael wrote: Looking through some code, I stumbled upon this which doesn't seem right: EAPI Evas * evas_object_evas_get(const Evas_Object *obj) { MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ); return NULL;

Re: [E-devel] Evas bugger

2009-08-24 Thread Christopher Michael
Christopher Michael wrote: Christopher Michael wrote: Looking through some code, I stumbled upon this which doesn't seem right: EAPI Evas * evas_object_evas_get(const Evas_Object *obj) { MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ); return NULL; MAGIC_CHECK_END(); if

Re: [E-devel] Evas bugger

2009-08-24 Thread Christopher Michael
Vincent Torri wrote: On Mon, 24 Aug 2009, Christopher Michael wrote: Christopher Michael wrote: Looking through some code, I stumbled upon this which doesn't seem right: EAPI Evas * evas_object_evas_get(const Evas_Object *obj) { MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ);

Re: [E-devel] Evas bugger

2009-08-24 Thread Christopher Michael
Mikhail Gusarov wrote: Twas brillig at 06:28:41 24.08.2009 UTC-04 when cpmicha...@comcast.net did gyre and gimble: CM if (obj-delete_me) return 0; CM Shouldn't that be: CM if (obj-delete_me) return NULL; ./linux/stddef.h:#define NULL 0 And if we're not on linux ?? :)

Re: [E-devel] Evas bugger

2009-08-24 Thread Mikhail Gusarov
Twas brillig at 06:55:12 24.08.2009 UTC-04 when cpmicha...@comcast.net did gyre and gimble: CM regardless of platform the returns are as expected. NULL is declared as 0 in C standard. Consistency wins, I agree, but portability is not hurt by using 0 instead of NULL. --

Re: [E-devel] Evas bugger

2009-08-24 Thread Albin Tonnerre
On Mon, Aug 24, 2009 at 06:07:20PM +0700, Mikhail Gusarov wrote : Twas brillig at 06:55:12 24.08.2009 UTC-04 when cpmicha...@comcast.net did gyre and gimble: CM regardless of platform the returns are as expected. NULL is declared as 0 in C standard. Consistency wins, I agree, but