Re: [E-devel] mkstemps usage in screenshot module

2012-12-09 Thread The Rasterman
On Sat, 8 Dec 2012 13:26:36 +0100 dieter roelants said: > > Hi, > > The screenshot module makes use of the mkstemps fuction which is > non-standard. (NetBSD doesn't have it, for example.) Also, the way it is > used, it leaks a file descriptor, and the return value isn't checked > correctly. Bec

[E-devel] mkstemps usage in screenshot module

2012-12-08 Thread dieter roelants
Hi, The screenshot module makes use of the mkstemps fuction which is non-standard. (NetBSD doesn't have it, for example.) Also, the way it is used, it leaks a file descriptor, and the return value isn't checked correctly. Because the file is unlinked shortly after creating, I didn't think it nece