On Thu, Aug 20, 2009 at 8:51 AM, Vincent Torri wrote:
>
>
> On Thu, 20 Aug 2009, Gustavo Sverzut Barbieri wrote:
>
>> I'd say it's good as is, if the other is fewer lines of code, then
>> better. But please cast to const char* to avoid possible mistakes and
>> writing to that pointer.
>
> that one
On Thu, 20 Aug 2009, Gustavo Sverzut Barbieri wrote:
I'd say it's good as is, if the other is fewer lines of code, then
better. But please cast to const char* to avoid possible mistakes and
writing to that pointer.
that one is smaller:
Index: src/modules/mp/fixed_bitmap/eina_fixed_bitmap.c
I'd say it's good as is, if the other is fewer lines of code, then
better. But please cast to const char* to avoid possible mistakes and
writing to that pointer.
On Thu, Aug 20, 2009 at 3:18 AM, Vincent Torri wrote:
>
> here is a patch. Another patch would be to cast when computing the
> delta's.
here is a patch. Another patch would be to cast when computing the
delta's. Which one do you prefer ?
Vincent
Index: eina_fixed_bitmap.c
===
--- eina_fixed_bitmap.c (revision 41856)
+++ eina_fixed_bitmap.c (working copy)
@@ -62,8 +
On Wed, Aug 19, 2009 at 10:07 AM, Joerg
Sonnenberger wrote:
> On Wed, Aug 19, 2009 at 02:36:54PM +0200, Cedric BAIL wrote:
>> It's not gcc specific other decent compiler support this feature. But
>> apparently not suncc, so you can patch if needed.
>
> void arithmetic is NOT a feature. It is a hist
On Wed, Aug 19, 2009 at 02:36:54PM +0200, Cedric BAIL wrote:
> It's not gcc specific other decent compiler support this feature. But
> apparently not suncc, so you can patch if needed.
void arithmetic is NOT a feature. It is a historic accident and bug.
Code using it is simply broken. Nothing less
On Wed, 19 Aug 2009, Gustavo Sverzut Barbieri wrote:
> On Wed, Aug 19, 2009 at 9:36 AM, Cedric BAIL wrote:
>> On Wed, Aug 19, 2009 at 12:23 PM, Vincent Torri wrote:
>>> On Wed, 19 Aug 2009, Cedric BAIL wrote:
On Wed, Aug 19, 2009 at 12:04 PM, Vincent Torri
wrote:
> On Wed, 19 Aug 2
On Wed, Aug 19, 2009 at 9:36 AM, Cedric BAIL wrote:
> On Wed, Aug 19, 2009 at 12:23 PM, Vincent Torri wrote:
>> On Wed, 19 Aug 2009, Cedric BAIL wrote:
>>> On Wed, Aug 19, 2009 at 12:04 PM, Vincent Torri
>>> wrote:
On Wed, 19 Aug 2009, Cedric BAIL wrote:
> On Wed, Aug 19, 2009 at 10:40 AM,
On Wed, Aug 19, 2009 at 12:23 PM, Vincent Torri wrote:
> On Wed, 19 Aug 2009, Cedric BAIL wrote:
>> On Wed, Aug 19, 2009 at 12:04 PM, Vincent Torri
>> wrote:
>>> On Wed, 19 Aug 2009, Cedric BAIL wrote:
On Wed, Aug 19, 2009 at 10:40 AM, Vincent Torri
wrote:
> On Wed, 19 Aug 2009, Vince
On Wed, 19 Aug 2009, Cedric BAIL wrote:
> On Wed, Aug 19, 2009 at 12:04 PM, Vincent Torri wrote:
>> On Wed, 19 Aug 2009, Cedric BAIL wrote:
>>> On Wed, Aug 19, 2009 at 10:40 AM, Vincent Torri
>>> wrote:
On Wed, 19 Aug 2009, Vincent Torri wrote:
>
> Hey,
>
> in eina_fixe
On Wed, Aug 19, 2009 at 12:04 PM, Vincent Torri wrote:
> On Wed, 19 Aug 2009, Cedric BAIL wrote:
>> On Wed, Aug 19, 2009 at 10:40 AM, Vincent Torri
>> wrote:
>>>
>>> On Wed, 19 Aug 2009, Vincent Torri wrote:
Hey,
in eina_fixed_bitmap.c, lines 68, 88 and 160, offsets are computed
On Wed, 19 Aug 2009, Cedric BAIL wrote:
> On Wed, Aug 19, 2009 at 10:40 AM, Vincent Torri wrote:
>> On Wed, 19 Aug 2009, Vincent Torri wrote:
>>> Hey,
>>>
>>> in eina_fixed_bitmap.c, lines 68, 88 and 160, offsets are computed and
>>> stored in an int. But, if I'm not mistaken, on 64 bits arch, o
On Wed, 19 Aug 2009 11:59:50 +0200 Cedric BAIL said:
> On Wed, Aug 19, 2009 at 10:40 AM, Vincent Torri wrote:
> > On Wed, 19 Aug 2009, Vincent Torri wrote:
> >> Hey,
> >>
> >> in eina_fixed_bitmap.c, lines 68, 88 and 160, offsets are computed and
> >> stored in an int. But, if I'm not mistaken, o
On Wed, Aug 19, 2009 at 10:40 AM, Vincent Torri wrote:
> On Wed, 19 Aug 2009, Vincent Torri wrote:
>> Hey,
>>
>> in eina_fixed_bitmap.c, lines 68, 88 and 160, offsets are computed and
>> stored in an int. But, if I'm not mistaken, on 64 bits arch, offsets are
>> 64 bits long.
>>
>> Shouldn't we sto
On Wed, 19 Aug 2009, Vincent Torri wrote:
>
> Hey,
>
> in eina_fixed_bitmap.c, lines 68, 88 and 160, offsets are computed and
> stored in an int. But, if I'm not mistaken, on 64 bits arch, offsets are
> 64 bits long.
>
> Shouldn't we store them in long instead of int ?
and technically speaking,
Hey,
in eina_fixed_bitmap.c, lines 68, 88 and 160, offsets are computed and
stored in an int. But, if I'm not mistaken, on 64 bits arch, offsets are
64 bits long.
Shouldn't we store them in long instead of int ?
Vincent
16 matches
Mail list logo
