Re: [E-devel] [EGIT] [core/efl] master 03/03: eo: if EO_DEBUG, check if efl_super() object 'isa' the given class.

2016-12-05 Thread Gustavo Sverzut Barbieri
On Mon, Dec 5, 2016 at 3:16 PM, Tom Hacohen wrote: > This is wrong, and as JP and Stefan said, breaks things. First of all, > why add code to the non-debug variation? Also, if you're already adding > to the non-debug variation, why not include it in the commit message? >

Re: [E-devel] [EGIT] [core/efl] master 03/03: eo: if EO_DEBUG, check if efl_super() object 'isa' the given class.

2016-12-05 Thread Tom Hacohen
This is wrong, and as JP and Stefan said, breaks things. First of all, why add code to the non-debug variation? Also, if you're already adding to the non-debug variation, why not include it in the commit message? This is very misleading. Anyhow, as the tests clearly show, efl_super() is also

Re: [E-devel] [EGIT] [core/efl] master 03/03: eo: if EO_DEBUG, check if efl_super() object 'isa' the given class.

2016-12-05 Thread Stefan Schmidt
Hello. On 02/12/16 17:51, Gustavo Sverzut Barbieri wrote: > barbieri pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=04450c4ee03fd20271ec4f911667acea10ba1375 > > commit 04450c4ee03fd20271ec4f911667acea10ba1375 > Author: Gustavo Sverzut Barbieri

Re: [E-devel] [EGIT] [core/efl] master 03/03: eo: if EO_DEBUG, check if efl_super() object 'isa' the given class.

2016-12-05 Thread Jean-Philippe André
Hey Gustavo, On 3 December 2016 at 01:51, Gustavo Sverzut Barbieri wrote: > barbieri pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id= > 04450c4ee03fd20271ec4f911667acea10ba1375 > > commit 04450c4ee03fd20271ec4f911667acea10ba1375 >

[EGIT] [core/efl] master 03/03: eo: if EO_DEBUG, check if efl_super() object 'isa' the given class.

2016-12-02 Thread Gustavo Sverzut Barbieri
barbieri pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=04450c4ee03fd20271ec4f911667acea10ba1375 commit 04450c4ee03fd20271ec4f911667acea10ba1375 Author: Gustavo Sverzut Barbieri Date: Fri Dec 2 14:49:06 2016 -0200 eo: if